Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 12:04:44AM -0800, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 2 Jan 2008 07:50:33 + > > > The only non-kernel user of this known to me is silo, which should just > > have it's own header documenting the solaris sparc ufs variant it

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-02 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 2 Jan 2008 07:50:33 + > The only non-kernel user of this known to me is silo, which should just > have it's own header documenting the solaris sparc ufs variant it needs > to understand, possibly by using a copy of the kernel version at

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-02 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 2 Jan 2008 07:50:33 + The only non-kernel user of this known to me is silo, which should just have it's own header documenting the solaris sparc ufs variant it needs to understand, possibly by using a copy of the kernel version at any

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 12:04:44AM -0800, David Miller wrote: From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 2 Jan 2008 07:50:33 + The only non-kernel user of this known to me is silo, which should just have it's own header documenting the solaris sparc ufs variant it needs to

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 04:02:42AM +0200, Adrian Bunk wrote: > But userspace anyway can't use them since it doesn't know what "uspi" > is, so you should better reduce the userspace visibility of this header. We had this come up before and the header should not be exported to userspace at all.

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 08:51:40PM -0500, Mike Frysinger wrote: > Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is > exported to userspace. > > Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> > --- > diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h > index

[patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Mike Frysinger
Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is exported to userspace. Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h index 10b854d..35b6e59 100644 --- a/include/linux/ufs_fs.h +++ b/include/linux/ufs_fs.h

[patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Mike Frysinger
Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is exported to userspace. Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h index 10b854d..35b6e59 100644 --- a/include/linux/ufs_fs.h +++ b/include/linux/ufs_fs.h @@

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 08:51:40PM -0500, Mike Frysinger wrote: Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is exported to userspace. Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h index

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 04:02:42AM +0200, Adrian Bunk wrote: But userspace anyway can't use them since it doesn't know what uspi is, so you should better reduce the userspace visibility of this header. We had this come up before and the header should not be exported to userspace at all. It