Re: [patch] power: supply: lp8788: remove an unneeded NULL check

2016-10-18 Thread Sebastian Reichel
Hi Dan, On Fri, Oct 14, 2016 at 10:33:28AM +0300, Dan Carpenter wrote: > We checked that "pdata->chg_params" is non-NULL earlier in this function > so when we add "i" to it, it's still non-NULL. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/power/supply/lp8788-charger.c > b/drivers

Re: [patch] power: supply: lp8788: remove an unneeded NULL check

2016-10-16 Thread Kim, Milo
On 10/14/2016 4:33 PM, Dan Carpenter wrote: We checked that "pdata->chg_params" is non-NULL earlier in this function so when we add "i" to it, it's still non-NULL. Signed-off-by: Dan Carpenter Acked-by: Milo Kim Thanks for catching this. Best regards, Milo

[patch] power: supply: lp8788: remove an unneeded NULL check

2016-10-14 Thread Dan Carpenter
We checked that "pdata->chg_params" is non-NULL earlier in this function so when we add "i" to it, it's still non-NULL. Signed-off-by: Dan Carpenter diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index 7321b72..509e2b3 100644 --- a/drivers/power/suppl