Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Mon, 15 Oct 2007, Ingo Molnar wrote: > > > > heh. Incidentally i was thinking about using KVM for automated > > testing. > > Using emulators to test device drivers is almost certain to be > pointless. something like that wont enable 100%

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread James Bottomley
On Mon, 2007-10-15 at 10:08 -0700, Linus Torvalds wrote: > > On Mon, 15 Oct 2007, Ingo Molnar wrote: > > > > A further problem is probably that the GDTH timer is not stopped by a > > failed GDTH probe? > > Indeed. Maybe this is a better fix? > > That driver is pretty messy, and this should

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Alan Cox wrote: > > For some things. I do it a bit because you can use it to fake > failures that are tricky to do in the real world. It won't tell you the > driver works but its suprisingly good for testing for races (forcing IRQ > delivery at specific points), buggy

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Alan Cox
On Mon, 15 Oct 2007 12:38:06 -0700 (PDT) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Mon, 15 Oct 2007, Ingo Molnar wrote: > > > > heh. Incidentally i was thinking about using KVM for automated testing. > > Using emulators to test device drivers is almost certain to be pointless. For

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Ingo Molnar wrote: > > heh. Incidentally i was thinking about using KVM for automated testing. Using emulators to test device drivers is almost certain to be pointless. The problem with device drivers tends to be timing issues, odd hardware interactions, and lots of

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > Honestly, the driver is probably rarely run by people that lack the > > hardware, I bet... > > It was all "flight by instruments only". I called for HW testers and > none came forward. All these changes, apart from "successful downgrade > to

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Mon, 15 Oct 2007, Ingo Molnar wrote: > > > > A further problem is probably that the GDTH timer is not stopped by a > > failed GDTH probe? > > Indeed. Maybe this is a better fix? > > That driver is pretty messy, and this should have been found

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Boaz Harrosh
On Mon, Oct 15 2007 at 19:57 +0200, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: >> On Mon, 15 Oct 2007, Ingo Molnar wrote: >>> A further problem is probably that the GDTH timer is not stopped by a >>> failed GDTH probe? >> Indeed. Maybe this is a better fix? >> >> That driver is

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Jeff Garzik
Linus Torvalds wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found ealier. James? Boaz? FWIW, the gdth

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Ingo Molnar wrote: > > A further problem is probably that the GDTH timer is not stopped by a > failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found ealier. James? Boaz? Linus ---

[patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
the patch below fixes a bootup-crash bug merged via today's SCSI git merge: commit df3d80f5a5c74168be42788364d13cf6c83c7b9c Merge: 3d06f7a... c8e91b0... Author: Linus Torvalds <[EMAIL PROTECTED]> Date: Mon Oct 15 08:19:33 2007 -0700 Merge

[patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
the patch below fixes a bootup-crash bug merged via today's SCSI git merge: commit df3d80f5a5c74168be42788364d13cf6c83c7b9c Merge: 3d06f7a... c8e91b0... Author: Linus Torvalds [EMAIL PROTECTED] Date: Mon Oct 15 08:19:33 2007 -0700 Merge

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found ealier. James? Boaz? Linus ---

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Jeff Garzik
Linus Torvalds wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found ealier. James? Boaz? FWIW, the gdth

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Boaz Harrosh
On Mon, Oct 15 2007 at 19:57 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: Linus Torvalds wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy,

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found ealier.

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Boaz Harrosh [EMAIL PROTECTED] wrote: Honestly, the driver is probably rarely run by people that lack the hardware, I bet... It was all flight by instruments only. I called for HW testers and none came forward. All these changes, apart from successful downgrade to messy where also

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Ingo Molnar wrote: heh. Incidentally i was thinking about using KVM for automated testing. Using emulators to test device drivers is almost certain to be pointless. The problem with device drivers tends to be timing issues, odd hardware interactions, and lots of

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Alan Cox
On Mon, 15 Oct 2007 12:38:06 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: heh. Incidentally i was thinking about using KVM for automated testing. Using emulators to test device drivers is almost certain to be pointless. For some

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Linus Torvalds
On Mon, 15 Oct 2007, Alan Cox wrote: For some things. I do it a bit because you can use it to fake failures that are tricky to do in the real world. It won't tell you the driver works but its suprisingly good for testing for races (forcing IRQ delivery at specific points), buggy hardware

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread James Bottomley
On Mon, 2007-10-15 at 10:08 -0700, Linus Torvalds wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy, and this should have been found

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Ingo Molnar
* Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: heh. Incidentally i was thinking about using KVM for automated testing. Using emulators to test device drivers is almost certain to be pointless. something like that wont enable 100% coverage (or