Re: [PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-31 Thread Dimitri Sivanich
On Mon, Mar 31, 2014 at 09:30:11AM +0200, Ingo Molnar wrote: > * Dimitri Sivanich wrote: > > @@ -843,12 +843,14 @@ void uv_cpu_init(void) > > void __init uv_system_init(void) > > { > > union uvh_rh_gam_config_mmr_u m_n_config; > > + union uv3h_gr0_gam_gr_config_u m_gr_config; > >

Re: [PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-31 Thread Ingo Molnar
* Dimitri Sivanich wrote: > On Fri, Mar 21, 2014 at 08:54:16AM +0100, Ingo Molnar wrote: > > Please use the customary changelog style we use in the kernel: > > > > " Current code does (A), this has a problem when (B). > > We can improve this doing (C), because (D)." > > > > (Of if it's

Re: [PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-31 Thread Ingo Molnar
* Dimitri Sivanich sivan...@sgi.com wrote: On Fri, Mar 21, 2014 at 08:54:16AM +0100, Ingo Molnar wrote: Please use the customary changelog style we use in the kernel: Current code does (A), this has a problem when (B). We can improve this doing (C), because (D). (Of if it's

Re: [PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-31 Thread Dimitri Sivanich
On Mon, Mar 31, 2014 at 09:30:11AM +0200, Ingo Molnar wrote: * Dimitri Sivanich sivan...@sgi.com wrote: @@ -843,12 +843,14 @@ void uv_cpu_init(void) void __init uv_system_init(void) { union uvh_rh_gam_config_mmr_u m_n_config; + union uv3h_gr0_gam_gr_config_u m_gr_config;

[PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-21 Thread Dimitri Sivanich
On Fri, Mar 21, 2014 at 08:54:16AM +0100, Ingo Molnar wrote: > Please use the customary changelog style we use in the kernel: > > " Current code does (A), this has a problem when (B). > We can improve this doing (C), because (D)." > > (Of if it's a cleanup only with no functional effects

Re: [patch] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-21 Thread Ingo Molnar
* Dimitri Sivanich wrote: > Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it > independent of the socket m_val. > > Remove unneeded macros. > > Signed-off-by: Dimitri Sivanich > --- > arch/x86/include/asm/uv/uv_hub.h | 12 - >

Re: [patch] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-21 Thread Ingo Molnar
* Dimitri Sivanich sivan...@sgi.com wrote: Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it independent of the socket m_val. Remove unneeded macros. Signed-off-by: Dimitri Sivanich sivan...@sgi.com --- arch/x86/include/asm/uv/uv_hub.h | 12 -

[PATCH] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-21 Thread Dimitri Sivanich
On Fri, Mar 21, 2014 at 08:54:16AM +0100, Ingo Molnar wrote: Please use the customary changelog style we use in the kernel: Current code does (A), this has a problem when (B). We can improve this doing (C), because (D). (Of if it's a cleanup only with no functional effects then

[patch] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-20 Thread Dimitri Sivanich
Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it independent of the socket m_val. Remove unneeded macros. Signed-off-by: Dimitri Sivanich --- arch/x86/include/asm/uv/uv_hub.h | 12 - arch/x86/include/asm/uv/uv_mmrs.h | 42

[patch] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3

2014-03-20 Thread Dimitri Sivanich
Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it independent of the socket m_val. Remove unneeded macros. Signed-off-by: Dimitri Sivanich sivan...@sgi.com --- arch/x86/include/asm/uv/uv_hub.h | 12 - arch/x86/include/asm/uv/uv_mmrs.h | 42