Re: [patch -next] ext4: locking issue on error path

2012-07-22 Thread Theodore Ts'o
On Tue, Jul 17, 2012 at 04:13:51PM +0800, Zheng Liu wrote: > On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote: > > We recently changed how the locking worked here, but this error path was > > missed. > > > > Signed-off-by: Dan Carpenter > > Sorry, it is my fault. Thanks for pointin

Re: [patch -next] ext4: locking issue on error path

2012-07-17 Thread Zheng Liu
On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote: > We recently changed how the locking worked here, but this error path was > missed. > > Signed-off-by: Dan Carpenter Sorry, it is my fault. Thanks for pointing out this bug. Regards, Zheng > > diff --git a/fs/ext4/inode.c b/fs/e

[patch -next] ext4: locking issue on error path

2012-07-16 Thread Dan Carpenter
We recently changed how the locking worked here, but this error path was missed. Signed-off-by: Dan Carpenter diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 8c84070..2728fb7 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3031,8 +3031,10 @@ static ssize_t ext4_ext_direct_IO(int rw,