Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Thomas Gleixner
On Tue, 7 Jul 2015, Sudeep Holla wrote: > Yes I tested this patch for all the combinations I had mentioned in my > earlier email. Everything works as expected. Thanks a lot for the > patience. Please feel free to add: > > Tested-by: Sudeep Holla > > > { > > Index:

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Sudeep Holla
Hi Thomas, On 07/07/15 08:31, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: This triggered the below crash on boot, looks like it's accessing hrtimer->function which is null in periodic mode IIUC Regards, Sudeep Gah. I have no

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Thomas Gleixner wrote: > On Mon, 6 Jul 2015, Sudeep Holla wrote: > > This triggered the below crash on boot, looks like it's accessing > > hrtimer->function which is null in periodic mode IIUC > > > > Regards, > > Sudeep > > Gah. I have no idea how that gets queued. /me goes

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: This triggered the below crash on boot, looks like it's accessing hrtimer-function which is null in periodic mode IIUC Regards, Sudeep Gah. I have no idea how that gets queued. /me goes off to tweak

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Thomas Gleixner
On Tue, 7 Jul 2015, Sudeep Holla wrote: Yes I tested this patch for all the combinations I had mentioned in my earlier email. Everything works as expected. Thanks a lot for the patience. Please feel free to add: Tested-by: Sudeep Holla sudeep.ho...@arm.com { Index:

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-07 Thread Sudeep Holla
Hi Thomas, On 07/07/15 08:31, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: This triggered the below crash on boot, looks like it's accessing hrtimer-function which is null in periodic mode IIUC Regards, Sudeep Gah. I have no

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: > This triggered the below crash on boot, looks like it's accessing > hrtimer->function which is null in periodic mode IIUC > > Regards, > Sudeep Gah. I have no idea how that gets queued. /me goes off to tweak x86 to emulate that crap. > --->8 > > Bad

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 17:53, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 17:06, Thomas Gleixner wrote: 2. After boot I am seeing the below warning: [ cut here ] WARNING: CPU: 1 PID: 0 at kernel/time/hrtimer.c:1247

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: > On 06/07/15 17:06, Thomas Gleixner wrote: > 2. After boot I am seeing the below warning: > > [ cut here ] > WARNING: CPU: 1 PID: 0 at kernel/time/hrtimer.c:1247 > __hrtimer_run_queues+0x148/0x150() > Modules linked in: > CPU: 1

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 17:06, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 16:35, Thomas Gleixner wrote: Well, we should figure out what happens while we are at it before everything gets paged out again. True. I just wanted to mention that this patch works for all the

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: > On 06/07/15 16:35, Thomas Gleixner wrote: > > Well, we should figure out what happens while we are at it before > > everything gets paged out again. > > > > True. I just wanted to mention that this patch works for all the > practical purposes. > > > In

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 16:35, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 05/07/15 21:53, Thomas Gleixner wrote: If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: > On 05/07/15 21:53, Thomas Gleixner wrote: > > If no broadcast device is installed and the cpu local timers stop in > > deeper idle states, then there is currently nothing telling the idle > > code that it should not go into deep idle states, so the timers

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
Hi Thomas, On 05/07/15 21:53, Thomas Gleixner wrote: If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go into deep idle states, so the timers stop and nothing wakes up the cpus.

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 17:06, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 16:35, Thomas Gleixner wrote: Well, we should figure out what happens while we are at it before everything gets paged out again. True. I just wanted to mention that this patch works for all the

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: This triggered the below crash on boot, looks like it's accessing hrtimer-function which is null in periodic mode IIUC Regards, Sudeep Gah. I have no idea how that gets queued. /me goes off to tweak x86 to emulate that crap. ---8 Bad mode in

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 17:06, Thomas Gleixner wrote: 2. After boot I am seeing the below warning: [ cut here ] WARNING: CPU: 1 PID: 0 at kernel/time/hrtimer.c:1247 __hrtimer_run_queues+0x148/0x150() Modules linked in: CPU: 1 PID: 0

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 17:53, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 17:06, Thomas Gleixner wrote: 2. After boot I am seeing the below warning: [ cut here ] WARNING: CPU: 1 PID: 0 at kernel/time/hrtimer.c:1247

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: On 05/07/15 21:53, Thomas Gleixner wrote: If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go into deep idle states, so the timers stop

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
On 06/07/15 16:35, Thomas Gleixner wrote: On Mon, 6 Jul 2015, Sudeep Holla wrote: On 05/07/15 21:53, Thomas Gleixner wrote: If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Sudeep Holla
Hi Thomas, On 05/07/15 21:53, Thomas Gleixner wrote: If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go into deep idle states, so the timers stop and nothing wakes up the cpus.

Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-06 Thread Thomas Gleixner
On Mon, 6 Jul 2015, Sudeep Holla wrote: On 06/07/15 16:35, Thomas Gleixner wrote: Well, we should figure out what happens while we are at it before everything gets paged out again. True. I just wanted to mention that this patch works for all the practical purposes. In the case of

[patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-05 Thread Thomas Gleixner
If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go into deep idle states, so the timers stop and nothing wakes up the cpus. Make the broadcast_enter/exit() functions independent of

[patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

2015-07-05 Thread Thomas Gleixner
If no broadcast device is installed and the cpu local timers stop in deeper idle states, then there is currently nothing telling the idle code that it should not go into deep idle states, so the timers stop and nothing wakes up the cpus. Make the broadcast_enter/exit() functions independent of