Re: [patch 14/24] Immediate Values - x86 Optimization (updated)

2007-12-21 Thread Mathieu Desnoyers
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the bypass. We are doing non atomic writes to a code region only touched

Re: [patch 14/24] Immediate Values - x86 Optimization (updated)

2007-12-21 Thread Mathieu Desnoyers
* H. Peter Anvin ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers wrote: >> Argh.. Rusty asked to have a simplified version first, and then to >> implement the "more complex" one on top of it. However, in order to get >> the reentrancy I need for the markers, I need the complex version of the >>

Re: [patch 14/24] Immediate Values - x86 Optimization (updated)

2007-12-21 Thread Mathieu Desnoyers
* H. Peter Anvin ([EMAIL PROTECTED]) wrote: Mathieu Desnoyers wrote: Argh.. Rusty asked to have a simplified version first, and then to implement the more complex one on top of it. However, in order to get the reentrancy I need for the markers, I need the complex version of the immediate

Re: [patch 14/24] Immediate Values - x86 Optimization (updated)

2007-12-21 Thread Mathieu Desnoyers
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the bypass. We are doing non atomic writes to a code region only touched

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread H. Peter Anvin
Mathieu Desnoyers wrote: Argh.. Rusty asked to have a simplified version first, and then to implement the "more complex" one on top of it. However, in order to get the reentrancy I need for the markers, I need the complex version of the immediate values. Therefore, you find, in this patchset,

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread Mathieu Desnoyers
* H. Peter Anvin ([EMAIL PROTECTED]) wrote: > This patch is modified by another patch in the sequence. This feels > needlessly confusing when reviewing (especially since the comment doesn't > look to match the code, e.g. w.r.t to "Q" and "R" constraints); can you > reorder the patchset to

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread H. Peter Anvin
This patch is modified by another patch in the sequence. This feels needlessly confusing when reviewing (especially since the comment doesn't look to match the code, e.g. w.r.t to "Q" and "R" constraints); can you reorder the patchset to avoid that? -hpa -- To unsubscribe from this

[patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread Mathieu Desnoyers
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the bypass. We are doing non atomic writes to a code region only touched

[patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread Mathieu Desnoyers
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the bypass. We are doing non atomic writes to a code region only touched

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread H. Peter Anvin
This patch is modified by another patch in the sequence. This feels needlessly confusing when reviewing (especially since the comment doesn't look to match the code, e.g. w.r.t to Q and R constraints); can you reorder the patchset to avoid that? -hpa -- To unsubscribe from this list:

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread Mathieu Desnoyers
* H. Peter Anvin ([EMAIL PROTECTED]) wrote: This patch is modified by another patch in the sequence. This feels needlessly confusing when reviewing (especially since the comment doesn't look to match the code, e.g. w.r.t to Q and R constraints); can you reorder the patchset to avoid that?

Re: [patch 14/24] Immediate Values - x86 Optimization

2007-12-20 Thread H. Peter Anvin
Mathieu Desnoyers wrote: Argh.. Rusty asked to have a simplified version first, and then to implement the more complex one on top of it. However, in order to get the reentrancy I need for the markers, I need the complex version of the immediate values. Therefore, you find, in this patchset, the