Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg KH
On Mon, Nov 19, 2007 at 02:32:41PM -0800, David Miller wrote: > From: David Brownell <[EMAIL PROTECTED]> > Date: Mon, 19 Nov 2007 11:59:55 -0800 > > > > This addition certainly won't hurt. Did we ever get any feedback as to > > > whether it actually helped? > > > > ISTR that davem refused to

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Miller
From: David Brownell <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 11:59:55 -0800 > > This addition certainly won't hurt. Did we ever get any feedback as to > > whether it actually helped? > > ISTR that davem refused to try it, after reporting an > intermittent failure on the original patch

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Brownell
> This addition certainly won't hurt. Did we ever get any feedback as to > whether it actually helped? ISTR that davem refused to try it, after reporting an intermittent failure on the original patch (which only addresses one end of that hardware race). So, no ... but given we know that

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Alan Stern
On Mon, 19 Nov 2007, David Brownell wrote: > Still needs the following update, IMO ... > > ==CUT HERE > A recent patch added software synchronization during EHCI startup, > so ports aren't switched away from the companion controllers after > resets have started. This patch adds a

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg KH
On Mon, Nov 19, 2007 at 10:41:28AM -0800, David Brownell wrote: > Still needs the following update, IMO ... Yes, but that patch isn't in Linus's tree yet, so I can't add it to the -stable trees. It's in my queue to send to Linus, but that's not going to happen until next week at the earliest...

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Brownell
Still needs the following update, IMO ... == CUT HERE A recent patch added software synchronization during EHCI startup, so ports aren't switched away from the companion controllers after resets have started. This patch adds a short delay letting hardware get a chance to finish that port

[patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg Kroah-Hartman
2.6.22-stable review patch. If anyone has any objections, please let us know. -- From: Alan Stern <[EMAIL PROTECTED]> patch 32fe01985aa2cb2562f6fc171e526e279abe10db in mainline. This patch (as999) fixes a problem that sometimes shows up when host controller driver modules are

[patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg Kroah-Hartman
2.6.22-stable review patch. If anyone has any objections, please let us know. -- From: Alan Stern [EMAIL PROTECTED] patch 32fe01985aa2cb2562f6fc171e526e279abe10db in mainline. This patch (as999) fixes a problem that sometimes shows up when host controller driver modules are

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Brownell
Still needs the following update, IMO ... == CUT HERE A recent patch added software synchronization during EHCI startup, so ports aren't switched away from the companion controllers after resets have started. This patch adds a short delay letting hardware get a chance to finish that port

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg KH
On Mon, Nov 19, 2007 at 10:41:28AM -0800, David Brownell wrote: Still needs the following update, IMO ... Yes, but that patch isn't in Linus's tree yet, so I can't add it to the -stable trees. It's in my queue to send to Linus, but that's not going to happen until next week at the earliest...

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Alan Stern
On Mon, 19 Nov 2007, David Brownell wrote: Still needs the following update, IMO ... ==CUT HERE A recent patch added software synchronization during EHCI startup, so ports aren't switched away from the companion controllers after resets have started. This patch adds a short

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Brownell
This addition certainly won't hurt. Did we ever get any feedback as to whether it actually helped? ISTR that davem refused to try it, after reporting an intermittent failure on the original patch (which only addresses one end of that hardware race). So, no ... but given we know that closing

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread David Miller
From: David Brownell [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 11:59:55 -0800 This addition certainly won't hurt. Did we ever get any feedback as to whether it actually helped? ISTR that davem refused to try it, after reporting an intermittent failure on the original patch (which only

Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

2007-11-19 Thread Greg KH
On Mon, Nov 19, 2007 at 02:32:41PM -0800, David Miller wrote: From: David Brownell [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 11:59:55 -0800 This addition certainly won't hurt. Did we ever get any feedback as to whether it actually helped? ISTR that davem refused to try it, after