Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-22 Thread Nick Piggin
On Thu, Feb 22, 2007 at 02:33:00PM -0800, Suresh B wrote: > On Thu, Feb 22, 2007 at 04:26:54AM +0100, Nick Piggin wrote: > > This is really ugly, sorry :( > > hm. myself and others too thought it was a simple and nice idea. The idea is not bad. I won't guarantee mine will be as good or better,

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-22 Thread Siddha, Suresh B
On Thu, Feb 22, 2007 at 04:26:54AM +0100, Nick Piggin wrote: > This is really ugly, sorry :( hm. myself and others too thought it was a simple and nice idea. > My suggestion for handling this was to increase the maximum balance > interval for an idle CPU, and just implement a global shutdown

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-22 Thread Siddha, Suresh B
On Thu, Feb 22, 2007 at 04:26:54AM +0100, Nick Piggin wrote: This is really ugly, sorry :( hm. myself and others too thought it was a simple and nice idea. My suggestion for handling this was to increase the maximum balance interval for an idle CPU, and just implement a global shutdown when

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-22 Thread Nick Piggin
On Thu, Feb 22, 2007 at 02:33:00PM -0800, Suresh B wrote: On Thu, Feb 22, 2007 at 04:26:54AM +0100, Nick Piggin wrote: This is really ugly, sorry :( hm. myself and others too thought it was a simple and nice idea. The idea is not bad. I won't guarantee mine will be as good or better, but I

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Nick Piggin
On Fri, Feb 16, 2007 at 06:08:42PM -0800, Suresh B wrote: > Changes since v1: > > - Move the idle load balancer selection from schedule() > to the first busy scheduler_tick() after restarting the tick. > This will avoid the unnecessay ownership changes when > softirq's(which are

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Nick Piggin
On Wed, Feb 21, 2007 at 12:23:44PM -0800, Andrew Morton wrote: > On Fri, 16 Feb 2007 18:08:42 -0800 > > +int select_nohz_load_balancer(int stop_tick) > > +{ > > + int cpu = smp_processor_id(); > > + > > + if (stop_tick) { > > + cpu_set(cpu, nohz.cpu_mask); > > +

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Andrew Morton
On Fri, 16 Feb 2007 18:08:42 -0800 "Siddha, Suresh B" <[EMAIL PROTECTED]> wrote: > Changes since v1: > > - Move the idle load balancer selection from schedule() > to the first busy scheduler_tick() after restarting the tick. > This will avoid the unnecessay ownership changes when >

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Andrew Morton
On Fri, 16 Feb 2007 18:08:42 -0800 Siddha, Suresh B [EMAIL PROTECTED] wrote: Changes since v1: - Move the idle load balancer selection from schedule() to the first busy scheduler_tick() after restarting the tick. This will avoid the unnecessay ownership changes when

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Nick Piggin
On Wed, Feb 21, 2007 at 12:23:44PM -0800, Andrew Morton wrote: On Fri, 16 Feb 2007 18:08:42 -0800 +int select_nohz_load_balancer(int stop_tick) +{ + int cpu = smp_processor_id(); + + if (stop_tick) { + cpu_set(cpu, nohz.cpu_mask); +

Re: [patch 2/2] sched: dynticks idle load balancing - v2

2007-02-21 Thread Nick Piggin
On Fri, Feb 16, 2007 at 06:08:42PM -0800, Suresh B wrote: Changes since v1: - Move the idle load balancer selection from schedule() to the first busy scheduler_tick() after restarting the tick. This will avoid the unnecessay ownership changes when softirq's(which are run in

[patch 2/2] sched: dynticks idle load balancing - v2

2007-02-16 Thread Siddha, Suresh B
Changes since v1: - Move the idle load balancer selection from schedule() to the first busy scheduler_tick() after restarting the tick. This will avoid the unnecessay ownership changes when softirq's(which are run in softirqd context in certain -rt configurations) like timer,

[patch 2/2] sched: dynticks idle load balancing - v2

2007-02-16 Thread Siddha, Suresh B
Changes since v1: - Move the idle load balancer selection from schedule() to the first busy scheduler_tick() after restarting the tick. This will avoid the unnecessay ownership changes when softirq's(which are run in softirqd context in certain -rt configurations) like timer,