Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Rusty Russell
On Wednesday 09 January 2008 03:18:46 Ingo Molnar wrote: > * DM <[EMAIL PROTECTED]> wrote: > > On Jan 8, 2008 3:26 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > Why use sprintf? If a module name contains the % character we could > > > > overflow the buffer. Or is module-unloading

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Ingo Molnar
* DM <[EMAIL PROTECTED]> wrote: > On Jan 8, 2008 3:26 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > > > Why use sprintf? If a module name contains the % character we could > > > overflow the buffer. Or is module-unloading root-only and we don't > > > care? > > > > module loading isn't

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread DM
On Jan 8, 2008 3:26 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > Why use sprintf? If a module name contains the % character we could > > overflow the buffer. Or is module-unloading root-only and we don't > > care? > > module loading isn't just root only; the name comes from an already

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Arjan van de Ven
On Tue, 8 Jan 2008 14:51:37 +0100 DM <[EMAIL PROTECTED]> wrote: > On Jan 7, 2008 12:19 AM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > [...] > > This patch tracks the last unloaded module, and prints this as part > > of the module list in the oops trace. > > > [...] > >} > > + /*

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread DM
On Jan 7, 2008 12:19 AM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: [...] > This patch tracks the last unloaded module, and prints this as part of the > module list in the oops trace. > [...] >} > + /* Store the name of the last unloaded module for diagnostic purposes > */ > +

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Rusty Russell
On Tuesday 08 January 2008 22:23:31 Ingo Molnar wrote: > * Rusty Russell <[EMAIL PROTECTED]> wrote: > > > Right now, only the last 1 module is tracked; I expect that this is > > > enough for the vast majority of cases where this information > > > matters; if it turns out that tracking more is

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Ingo Molnar
* Rusty Russell <[EMAIL PROTECTED]> wrote: > > Right now, only the last 1 module is tracked; I expect that this is > > enough for the vast majority of cases where this information > > matters; if it turns out that tracking more is important, we can > > always extend it to that. > > > >

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Ingo Molnar
* Rusty Russell [EMAIL PROTECTED] wrote: Right now, only the last 1 module is tracked; I expect that this is enough for the vast majority of cases where this information matters; if it turns out that tracking more is important, we can always extend it to that. Signed-off-by: Arjan

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Rusty Russell
On Tuesday 08 January 2008 22:23:31 Ingo Molnar wrote: * Rusty Russell [EMAIL PROTECTED] wrote: Right now, only the last 1 module is tracked; I expect that this is enough for the vast majority of cases where this information matters; if it turns out that tracking more is important, we

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread DM
On Jan 7, 2008 12:19 AM, Arjan van de Ven [EMAIL PROTECTED] wrote: [...] This patch tracks the last unloaded module, and prints this as part of the module list in the oops trace. [...] } + /* Store the name of the last unloaded module for diagnostic purposes */ +

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Arjan van de Ven
On Tue, 8 Jan 2008 14:51:37 +0100 DM [EMAIL PROTECTED] wrote: On Jan 7, 2008 12:19 AM, Arjan van de Ven [EMAIL PROTECTED] wrote: [...] This patch tracks the last unloaded module, and prints this as part of the module list in the oops trace. [...] } + /* Store the name of

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread DM
On Jan 8, 2008 3:26 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: Why use sprintf? If a module name contains the % character we could overflow the buffer. Or is module-unloading root-only and we don't care? module loading isn't just root only; the name comes from an already loaded

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Ingo Molnar
* DM [EMAIL PROTECTED] wrote: On Jan 8, 2008 3:26 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: Why use sprintf? If a module name contains the % character we could overflow the buffer. Or is module-unloading root-only and we don't care? module loading isn't just root only; the

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-08 Thread Rusty Russell
On Wednesday 09 January 2008 03:18:46 Ingo Molnar wrote: * DM [EMAIL PROTECTED] wrote: On Jan 8, 2008 3:26 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: Why use sprintf? If a module name contains the % character we could overflow the buffer. Or is module-unloading root-only and we don't

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 10:19:46 Arjan van de Ven wrote: > Subject: track and print last unloaded module in the oops trace > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > > Based on a suggestion from Andi: > In various cases,

[patch 2/2] track and print last unloaded module in the oops trace

2008-01-06 Thread Arjan van de Ven
Subject: track and print last unloaded module in the oops trace From: Arjan van de Ven <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Based on a suggestion from Andi: In various cases, the unload of a module may leave some bad state around that causes a

[patch 2/2] track and print last unloaded module in the oops trace

2008-01-06 Thread Arjan van de Ven
Subject: track and print last unloaded module in the oops trace From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Based on a suggestion from Andi: In various cases, the unload of a module may leave some bad state around that causes a

Re: [patch 2/2] track and print last unloaded module in the oops trace

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 10:19:46 Arjan van de Ven wrote: Subject: track and print last unloaded module in the oops trace From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Based on a suggestion from Andi: In various cases, the