Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-14 Thread Len Brown
On Thursday 14 December 2006 02:16, Holger Macht wrote: > On Mon 11. Dec - 12:05:08, Kristen Carlson Accardi wrote: > > Ok - how is this? > > Looks good to me, thanks! > > Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> > > Signed-off-by: Holger Macht <[EMAIL PROTECTED]> Applied.

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-14 Thread Len Brown
On Thursday 14 December 2006 02:16, Holger Macht wrote: On Mon 11. Dec - 12:05:08, Kristen Carlson Accardi wrote: Ok - how is this? Looks good to me, thanks! Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Signed-off-by: Holger Macht [EMAIL PROTECTED] Applied. thanks, -Len

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Holger Macht
On Mon 11. Dec - 12:05:08, Kristen Carlson Accardi wrote: > On Sat, 9 Dec 2006 12:59:58 +0100 > Holger Macht <[EMAIL PROTECTED]> wrote: > > > Well, I like to have them ;-) > > Ok - how is this? Looks good to me, thanks! > Send a uevent to indicate a device change whenever we dock or > undock,

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Stefan Schmidt
Hello. On Wed, 2006-12-13 at 10:14, Kay Sievers wrote: > On Wed, 2006-12-13 at 00:26 +0100, Stefan Schmidt wrote: > > On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: > > > > > > I did have different dock/undock events a few months ago - but > > > after some discussion we scrapped

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Kay Sievers
On Wed, 2006-12-13 at 00:26 +0100, Stefan Schmidt wrote: > On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: > > > > I did have different dock/undock events a few months ago - but > > after some discussion we scrapped them because Kay wants to avoid driver > > specific events. The

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Kay Sievers
On Wed, 2006-12-13 at 00:26 +0100, Stefan Schmidt wrote: On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: I did have different dock/undock events a few months ago - but after some discussion we scrapped them because Kay wants to avoid driver specific events. The change event

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Stefan Schmidt
Hello. On Wed, 2006-12-13 at 10:14, Kay Sievers wrote: On Wed, 2006-12-13 at 00:26 +0100, Stefan Schmidt wrote: On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: I did have different dock/undock events a few months ago - but after some discussion we scrapped them because

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-13 Thread Holger Macht
On Mon 11. Dec - 12:05:08, Kristen Carlson Accardi wrote: On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well, I like to have them ;-) Ok - how is this? Looks good to me, thanks! Send a uevent to indicate a device change whenever we dock or undock, so that

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Stefan Schmidt
Hello. On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: > > I did have different dock/undock events a few months ago - but > after some discussion we scrapped them because Kay wants to avoid driver > specific events. The "change" event is the only thing that makes sense, > given the

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Kristen Carlson Accardi
On Tue, 12 Dec 2006 14:31:10 -0800 Jesse Barnes <[EMAIL PROTECTED]> wrote: > On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote: > > Hello. > > > > On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: > > > On Sat, 9 Dec 2006 12:59:58 +0100 > > > > > > Holger Macht <[EMAIL

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Jesse Barnes
On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote: > Hello. > > On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: > > On Sat, 9 Dec 2006 12:59:58 +0100 > > > > Holger Macht <[EMAIL PROTECTED]> wrote: > > > Well, I like to have them ;-) > > > > Ok - how is this? > > > > Send a

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Stefan Schmidt
Hello. On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: > On Sat, 9 Dec 2006 12:59:58 +0100 > Holger Macht <[EMAIL PROTECTED]> wrote: > > > Well, I like to have them ;-) > > Ok - how is this? > > Send a uevent to indicate a device change whenever we dock or > undock, so that

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Stefan Schmidt
Hello. On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well, I like to have them ;-) Ok - how is this? Send a uevent to indicate a device change whenever we dock or undock, so that userspace may now

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Jesse Barnes
On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote: Hello. On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well, I like to have them ;-) Ok - how is this? Send a uevent to indicate a

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Kristen Carlson Accardi
On Tue, 12 Dec 2006 14:31:10 -0800 Jesse Barnes [EMAIL PROTECTED] wrote: On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote: Hello. On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote:

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Stefan Schmidt
Hello. On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: I did have different dock/undock events a few months ago - but after some discussion we scrapped them because Kay wants to avoid driver specific events. The change event is the only thing that makes sense, given the set of

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-11 Thread Kristen Carlson Accardi
On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht <[EMAIL PROTECTED]> wrote: > Well, I like to have them ;-) Ok - how is this? Send a uevent to indicate a device change whenever we dock or undock, so that userspace may now check the dock status via sysfs. Signed-off-by: Kristen Carlson Accardi

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-11 Thread Kristen Carlson Accardi
On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well, I like to have them ;-) Ok - how is this? Send a uevent to indicate a device change whenever we dock or undock, so that userspace may now check the dock status via sysfs. Signed-off-by: Kristen Carlson Accardi

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-09 Thread Holger Macht
On Mon 04. Dec - 14:49:58, Kristen Carlson Accardi wrote: > From: [EMAIL PROTECTED] > > Add 2 sysfs files for user interface. > 1) docked - 1/0 (read only) - indicates whether the software believes the > laptop is docked in a docking station. > 2) undock - (write only) - writing to this file

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-09 Thread Holger Macht
On Mon 04. Dec - 14:49:58, Kristen Carlson Accardi wrote: From: [EMAIL PROTECTED] Add 2 sysfs files for user interface. 1) docked - 1/0 (read only) - indicates whether the software believes the laptop is docked in a docking station. 2) undock - (write only) - writing to this file causes

[patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-04 Thread Kristen Carlson Accardi
From: [EMAIL PROTECTED] Add 2 sysfs files for user interface. 1) docked - 1/0 (read only) - indicates whether the software believes the laptop is docked in a docking station. 2) undock - (write only) - writing to this file causes the software to initiate an undock request to the firmware.

[patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-04 Thread Kristen Carlson Accardi
From: [EMAIL PROTECTED] Add 2 sysfs files for user interface. 1) docked - 1/0 (read only) - indicates whether the software believes the laptop is docked in a docking station. 2) undock - (write only) - writing to this file causes the software to initiate an undock request to the firmware.