Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 7 Apr 2007 20:39:16 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Sat, Apr 07, 2007 at 10:59:47AM -0700, Andrew Morton wrote: > > On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> > > wrote: > > > > > I don't have a x86-64 compile environment on > > >

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Sam Ravnborg
On Sat, Apr 07, 2007 at 10:59:47AM -0700, Andrew Morton wrote: > On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> > wrote: > > > I don't have a x86-64 compile environment on > > hand, so the 64 bits are completely untested > >

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > I don't have a x86-64 compile environment on > hand, so the 64 bits are completely untested http://userweb.kernel.org/~akpm/cross-compilers/ - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Jeremy Fitzhardinge
Andrew Morton wrote: > x86_64 uses this too. > > WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to > .init.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at > offset 0x655) > OK, two patches to follow: a x86-64 variant of the bugs.h cleanup, and a

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > identify_cpu() is used to identify both the boot CPU and secondary > CPUs, but it performs some actions which only apply to the boot CPU. > Those functions are therefore really __init functions, but because >

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: identify_cpu() is used to identify both the boot CPU and secondary CPUs, but it performs some actions which only apply to the boot CPU. Those functions are therefore really __init functions, but because they're

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Jeremy Fitzhardinge
Andrew Morton wrote: x86_64 uses this too. WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to .init.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at offset 0x655) OK, two patches to follow: a x86-64 variant of the bugs.h cleanup, and a replacement

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: I don't have a x86-64 compile environment on hand, so the 64 bits are completely untested http://userweb.kernel.org/~akpm/cross-compilers/ - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Sam Ravnborg
On Sat, Apr 07, 2007 at 10:59:47AM -0700, Andrew Morton wrote: On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: I don't have a x86-64 compile environment on hand, so the 64 bits are completely untested http://userweb.kernel.org/~akpm/cross-compilers/

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 7 Apr 2007 20:39:16 +0200 Sam Ravnborg [EMAIL PROTECTED] wrote: On Sat, Apr 07, 2007 at 10:59:47AM -0700, Andrew Morton wrote: On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: I don't have a x86-64 compile environment on hand, so the 64 bits

[patch 2/4] clean up identify_cpu

2007-04-06 Thread Jeremy Fitzhardinge
identify_cpu() is used to identify both the boot CPU and secondary CPUs, but it performs some actions which only apply to the boot CPU. Those functions are therefore really __init functions, but because they're called by identify_cpu(), they must be marked __cpuinit. This patch splits

[patch 2/4] clean up identify_cpu

2007-04-06 Thread Jeremy Fitzhardinge
identify_cpu() is used to identify both the boot CPU and secondary CPUs, but it performs some actions which only apply to the boot CPU. Those functions are therefore really __init functions, but because they're called by identify_cpu(), they must be marked __cpuinit. This patch splits