Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Nick Piggin
Paul E. McKenney wrote: On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: OK thanks for the good explanation. So I'll keep it as is for now, and whatever needs cleaning up later can be worked out as it comes up. Looking forward to the split of synchronize_kernel() into

Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Paul E. McKenney
On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: > Ingo Molnar wrote: > >* Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > > >>>At a minimum i think we need the fix+comment below. > >> > >>Well if we say "this is actually RCU", then yes. And we should > >>probably change the

Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Paul E. McKenney
On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: At a minimum i think we need the fix+comment below. Well if we say this is actually RCU, then yes. And we should probably change the preempt_{dis|en}ables in other

Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Nick Piggin
Paul E. McKenney wrote: On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: OK thanks for the good explanation. So I'll keep it as is for now, and whatever needs cleaning up later can be worked out as it comes up. Looking forward to the split of synchronize_kernel() into

Re: [patch 4/5] sched: RCU sched domains

2005-04-07 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: At a minimum i think we need the fix+comment below. Well if we say "this is actually RCU", then yes. And we should probably change the preempt_{dis|en}ables in other places to rcu_read_lock. OTOH, if we say we just want all running

Re: [patch 4/5] sched: RCU sched domains

2005-04-07 Thread Ingo Molnar
* Nick Piggin <[EMAIL PROTECTED]> wrote: > > At a minimum i think we need the fix+comment below. > > Well if we say "this is actually RCU", then yes. And we should > probably change the preempt_{dis|en}ables in other places to > rcu_read_lock. > > OTOH, if we say we just want all running

Re: [patch 4/5] sched: RCU sched domains

2005-04-07 Thread Ingo Molnar
* Nick Piggin [EMAIL PROTECTED] wrote: At a minimum i think we need the fix+comment below. Well if we say this is actually RCU, then yes. And we should probably change the preempt_{dis|en}ables in other places to rcu_read_lock. OTOH, if we say we just want all running threads to

Re: [patch 4/5] sched: RCU sched domains

2005-04-07 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: At a minimum i think we need the fix+comment below. Well if we say this is actually RCU, then yes. And we should probably change the preempt_{dis|en}ables in other places to rcu_read_lock. OTOH, if we say we just want all running

Re: [patch 4/5] sched: RCU sched domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: 4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you may traverse

Re: [patch 4/5] sched: RCU sched domains

2005-04-06 Thread Ingo Molnar
* Nick Piggin <[EMAIL PROTECTED]> wrote: > 4/5 > One of the problems with the multilevel balance-on-fork/exec is that > it needs to jump through hoops to satisfy sched-domain's locking > semantics (that is, you may traverse your own domain when not > preemptable, and you may traverse others'

Re: [patch 4/5] sched: RCU sched domains

2005-04-06 Thread Ingo Molnar
* Nick Piggin [EMAIL PROTECTED] wrote: 4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you may traverse others'

Re: [patch 4/5] sched: RCU sched domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: 4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you may traverse

[patch 4/5] sched: RCU sched domains

2005-04-05 Thread Nick Piggin
4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you may traverse others' domains when holding their runqueue lock).

[patch 4/5] sched: RCU sched domains

2005-04-05 Thread Nick Piggin
4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you may traverse others' domains when holding their runqueue lock).