Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

2008-01-06 Thread Olof Johansson
On Sun, Jan 06, 2008 at 10:16:04PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-05 at 19:12 -0800, Arjan van de Ven wrote: > > From: Olof Johansson <[EMAIL PROTECTED]> > > > > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about > > 4K text on a ppc64_defconfig.

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

2008-01-06 Thread Benjamin Herrenschmidt
On Sat, 2008-01-05 at 19:12 -0800, Arjan van de Ven wrote: > From: Olof Johansson <[EMAIL PROTECTED]> > > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about > 4K text on a ppc64_defconfig. The main reason seems to be that prepping > the arguments to the conditional trap in

[patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

2008-01-05 Thread Arjan van de Ven
From: Olof Johansson <[EMAIL PROTECTED]> Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about 4K text on a ppc64_defconfig. The main reason seems to be that prepping the arguments to the conditional trap instructions is more work than just doing a compare and branch. Signed-