Re: [patch 6/10] mm: be sure to trim blocks

2007-01-19 Thread Nick Piggin
On Tue, Jan 16, 2007 at 08:14:16PM +0100, Peter Zijlstra wrote: > On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote: > > buf, bytes); > > > @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb > > >

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-19 Thread Nick Piggin
On Sun, Jan 14, 2007 at 05:25:44PM +0300, Dmitriy Monakhov wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, > > then > > we may have failed the write operation despite prepare_write having > > instantiated blocks

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-19 Thread Nick Piggin
On Sun, Jan 14, 2007 at 05:25:44PM +0300, Dmitriy Monakhov wrote: Nick Piggin [EMAIL PROTECTED] writes: If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size.

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-19 Thread Nick Piggin
On Tue, Jan 16, 2007 at 08:14:16PM +0100, Peter Zijlstra wrote: On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote: buf, bytes); @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-16 Thread Peter Zijlstra
On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote: > buf, bytes); > > @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb > > cur_iov, iov_offset, bytes); > >

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-16 Thread Peter Zijlstra
On Sat, 2007-01-13 at 04:25 +0100, Nick Piggin wrote: > If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then > we may have failed the write operation despite prepare_write having > instantiated blocks past i_size. Fix this, and consolidate the trimming into > one place. >

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-16 Thread Peter Zijlstra
On Sat, 2007-01-13 at 04:25 +0100, Nick Piggin wrote: If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place.

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-16 Thread Peter Zijlstra
On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote: buf, bytes); @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb cur_iov, iov_offset, bytes);

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-14 Thread Dmitriy Monakhov
Nick Piggin <[EMAIL PROTECTED]> writes: > If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then > we may have failed the write operation despite prepare_write having > instantiated blocks past i_size. Fix this, and consolidate the trimming into > one place. > >

Re: [patch 6/10] mm: be sure to trim blocks

2007-01-14 Thread Dmitriy Monakhov
Nick Piggin [EMAIL PROTECTED] writes: If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place. Signed-off-by:

[patch 6/10] mm: be sure to trim blocks

2007-01-12 Thread Nick Piggin
If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index:

[patch 6/10] mm: be sure to trim blocks

2007-01-12 Thread Nick Piggin
If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: