Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-16 Thread Johannes Weiner
On Wed, Jan 15, 2014 at 10:57:21AM +0800, Bob Liu wrote: > On 01/15/2014 03:16 AM, Johannes Weiner wrote: > > On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: > >> Good job! This patch looks good to me and with nice descriptions. > >> But it seems that this patch only fix the issue

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-16 Thread Johannes Weiner
On Wed, Jan 15, 2014 at 10:57:21AM +0800, Bob Liu wrote: On 01/15/2014 03:16 AM, Johannes Weiner wrote: On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: Good job! This patch looks good to me and with nice descriptions. But it seems that this patch only fix the issue working set

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Zhang Yanfei
Hello On 01/15/2014 10:57 AM, Bob Liu wrote: > > On 01/15/2014 03:16 AM, Johannes Weiner wrote: >> On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: >>> Hi Johannes, >>> >>> On 01/11/2014 02:10 AM, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists.

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Bob Liu
On 01/15/2014 03:16 AM, Johannes Weiner wrote: > On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: >> Hi Johannes, >> >> On 01/11/2014 02:10 AM, Johannes Weiner wrote: >>> The VM maintains cached filesystem pages on two types of lists. One >>> list holds the pages recently faulted into

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Johannes Weiner
On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: > Hi Johannes, > > On 01/11/2014 02:10 AM, Johannes Weiner wrote: > > The VM maintains cached filesystem pages on two types of lists. One > > list holds the pages recently faulted into the cache, the other list > > holds pages that have

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Johannes Weiner
On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Bob Liu
On 01/15/2014 03:16 AM, Johannes Weiner wrote: On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-14 Thread Zhang Yanfei
Hello On 01/15/2014 10:57 AM, Bob Liu wrote: On 01/15/2014 03:16 AM, Johannes Weiner wrote: On Tue, Jan 14, 2014 at 09:01:09AM +0800, Bob Liu wrote: Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-13 Thread Bob Liu
Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: > The VM maintains cached filesystem pages on two types of lists. One > list holds the pages recently faulted into the cache, the other list > holds pages that have been referenced repeatedly on that first list. > The idea is to prefer

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-13 Thread Bob Liu
Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-12 Thread Minchan Kim
On Fri, Jan 10, 2014 at 01:10:41PM -0500, Johannes Weiner wrote: > The VM maintains cached filesystem pages on two types of lists. One > list holds the pages recently faulted into the cache, the other list > holds pages that have been referenced repeatedly on that first list. > The idea is to

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-12 Thread Minchan Kim
On Fri, Jan 10, 2014 at 01:10:41PM -0500, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-10 Thread Rik van Riel
On 01/10/2014 01:10 PM, Johannes Weiner wrote: > This patch solves one half of the problem by decoupling the ability to > detect working set changes from the inactive list size. By > maintaining a history of recently evicted file pages it can detect > frequently used pages with an arbitrarily

[patch 7/9] mm: thrash detection-based file cache sizing

2014-01-10 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from

[patch 7/9] mm: thrash detection-based file cache sizing

2014-01-10 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2014-01-10 Thread Rik van Riel
On 01/10/2014 01:10 PM, Johannes Weiner wrote: This patch solves one half of the problem by decoupling the ability to detect working set changes from the inactive list size. By maintaining a history of recently evicted file pages it can detect frequently used pages with an arbitrarily small

[patch 7/9] mm: thrash detection-based file cache sizing

2013-12-02 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from

[patch 7/9] mm: thrash detection-based file cache sizing

2013-12-02 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-26 Thread Johannes Weiner
On Tue, Nov 26, 2013 at 12:56:23PM +1100, Ryan Mallon wrote: > > + * fault + > > + * | > > + * +--+ |+-+ > > + * reclaim <- | inactive | <-+-- demotion |active | <--+ > > + *

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-26 Thread Johannes Weiner
On Tue, Nov 26, 2013 at 12:56:23PM +1100, Ryan Mallon wrote: + * fault + + * | + * +--+ |+-+ + * reclaim - | inactive | -+-- demotion |active | --+ + *

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Johannes Weiner
On Mon, Nov 25, 2013 at 03:50:11PM -0800, Andrew Morton wrote: > On Sun, 24 Nov 2013 18:38:26 -0500 Johannes Weiner wrote: > > > ... > > > > + * Access frequency and refault distance > > + * > > + * A workload is trashing when its pages are frequently used but they > > + * are evicted

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Ryan Mallon
On 25/11/13 10:38, Johannes Weiner wrote: > The VM maintains cached filesystem pages on two types of lists. One > list holds the pages recently faulted into the cache, the other list > holds pages that have been referenced repeatedly on that first list. > The idea is to prefer reclaiming young

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Andrew Morton
On Sun, 24 Nov 2013 18:38:26 -0500 Johannes Weiner wrote: > ... > > + * Access frequency and refault distance > + * > + * A workload is trashing when its pages are frequently used but they > + * are evicted from the inactive list every time before another access > + * would have

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Andrew Morton
On Sun, 24 Nov 2013 18:38:26 -0500 Johannes Weiner han...@cmpxchg.org wrote: ... + * Access frequency and refault distance + * + * A workload is trashing when its pages are frequently used but they + * are evicted from the inactive list every time before another access + * would

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Ryan Mallon
On 25/11/13 10:38, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Johannes Weiner
On Mon, Nov 25, 2013 at 03:50:11PM -0800, Andrew Morton wrote: On Sun, 24 Nov 2013 18:38:26 -0500 Johannes Weiner han...@cmpxchg.org wrote: ... + * Access frequency and refault distance + * + * A workload is trashing when its pages are frequently used but they + * are

[patch 7/9] mm: thrash detection-based file cache sizing

2013-11-24 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from

[patch 7/9] mm: thrash detection-based file cache sizing

2013-11-24 Thread Johannes Weiner
The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages over those that have shown to benefit from