Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-22 Thread Johannes Weiner
On Tue, Aug 20, 2013 at 01:59:24PM -0700, Andrew Morton wrote: > On Sat, 17 Aug 2013 15:31:23 -0400 Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-22 Thread Johannes Weiner
On Tue, Aug 20, 2013 at 01:59:24PM -0700, Andrew Morton wrote: On Sat, 17 Aug 2013 15:31:23 -0400 Johannes Weiner han...@cmpxchg.org wrote: Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-20 Thread Andrew Morton
On Sat, 17 Aug 2013 15:31:23 -0400 Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This is

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-20 Thread Andrew Morton
On Sat, 17 Aug 2013 15:31:23 -0400 Johannes Weiner han...@cmpxchg.org wrote: Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are

[patch 9/9] mm: workingset: keep shadow entries in check

2013-08-17 Thread Johannes Weiner
Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are reclaimed. This is problematic for bigger files that are still in use after they have a

[patch 9/9] mm: workingset: keep shadow entries in check

2013-08-17 Thread Johannes Weiner
Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are reclaimed. This is problematic for bigger files that are still in use after they have a

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-14 Thread Johannes Weiner
Hey Andi! On Mon, Aug 12, 2013 at 01:56:31AM +0200, Andi Kleen wrote: > > I really like the idea of using the spare slots in the radix tree > for something useful. It's amazing we haven't used that before. > > I wonder if with some clever encoding even more information could be fit? What do

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-14 Thread Johannes Weiner
Hey Andi! On Mon, Aug 12, 2013 at 01:56:31AM +0200, Andi Kleen wrote: I really like the idea of using the spare slots in the radix tree for something useful. It's amazing we haven't used that before. I wonder if with some clever encoding even more information could be fit? What do you

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-11 Thread Andi Kleen
I really like the idea of using the spare slots in the radix tree for something useful. It's amazing we haven't used that before. I wonder if with some clever encoding even more information could be fit? e.g. I assume you don't really need all bits of the refault distance, just a good enough

Re: [patch 9/9] mm: workingset: keep shadow entries in check

2013-08-11 Thread Andi Kleen
I really like the idea of using the spare slots in the radix tree for something useful. It's amazing we haven't used that before. I wonder if with some clever encoding even more information could be fit? e.g. I assume you don't really need all bits of the refault distance, just a good enough

[patch 9/9] mm: workingset: keep shadow entries in check

2013-08-06 Thread Johannes Weiner
Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are reclaimed. This is problematic for bigger files that are still in use after they have a

[patch 9/9] mm: workingset: keep shadow entries in check

2013-08-06 Thread Johannes Weiner
Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are reclaimed. This is problematic for bigger files that are still in use after they have a