Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-28 Thread Mel Gorman
On Mon, Jan 27, 2014 at 03:31:32PM -0800, David Rientjes wrote: > On Mon, 27 Jan 2014, Mel Gorman wrote: > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index c2ccec0..c1a2573 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -120,6 +120,14 @@ static struct mempolicy

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-28 Thread Mel Gorman
On Mon, Jan 27, 2014 at 03:31:32PM -0800, David Rientjes wrote: On Mon, 27 Jan 2014, Mel Gorman wrote: diff --git a/mm/mempolicy.c b/mm/mempolicy.c index c2ccec0..c1a2573 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -120,6 +120,14 @@ static struct mempolicy default_policy = {

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread David Rientjes
On Mon, 27 Jan 2014, Mel Gorman wrote: > > Should we also consider printing the MOF and MORON states so we get a > > better view of what the actual policy is? > > > > MOF and MORON are separate issues because MOF is exposed to the userspace > API but not the policies that make up MORON. For

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread David Rientjes
On Mon, 27 Jan 2014, Mel Gorman wrote: > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index c2ccec0..c1a2573 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -120,6 +120,14 @@ static struct mempolicy default_policy = { > > static struct mempolicy preferred_node_policy[MAX_NUMNODES];

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Mel Gorman
On Mon, Jan 27, 2014 at 11:50:11AM +0100, Peter Zijlstra wrote: > On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: > > As a result of commit 5606e3877ad8 ("mm: numa: Migrate on reference > > policy"), /proc//numa_maps prints the mempolicy for any as > > "prefer:N" for the local

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Mel Gorman
On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: > As a result of commit 5606e3877ad8 ("mm: numa: Migrate on reference > policy"), /proc//numa_maps prints the mempolicy for any as > "prefer:N" for the local node, N, of the process reading the file. > > This should only be

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Peter Zijlstra
On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: > As a result of commit 5606e3877ad8 ("mm: numa: Migrate on reference > policy"), /proc//numa_maps prints the mempolicy for any as > "prefer:N" for the local node, N, of the process reading the file. > > This should only be

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Peter Zijlstra
On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: As a result of commit 5606e3877ad8 (mm: numa: Migrate on reference policy), /proc/pid/numa_maps prints the mempolicy for any pid as prefer:N for the local node, N, of the process reading the file. This should only be printed

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Mel Gorman
On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: As a result of commit 5606e3877ad8 (mm: numa: Migrate on reference policy), /proc/pid/numa_maps prints the mempolicy for any pid as prefer:N for the local node, N, of the process reading the file. This should only be printed

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread Mel Gorman
On Mon, Jan 27, 2014 at 11:50:11AM +0100, Peter Zijlstra wrote: On Sat, Jan 25, 2014 at 07:12:35PM -0800, David Rientjes wrote: As a result of commit 5606e3877ad8 (mm: numa: Migrate on reference policy), /proc/pid/numa_maps prints the mempolicy for any pid as prefer:N for the local node,

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread David Rientjes
On Mon, 27 Jan 2014, Mel Gorman wrote: diff --git a/mm/mempolicy.c b/mm/mempolicy.c index c2ccec0..c1a2573 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -120,6 +120,14 @@ static struct mempolicy default_policy = { static struct mempolicy preferred_node_policy[MAX_NUMNODES];

Re: [patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-27 Thread David Rientjes
On Mon, 27 Jan 2014, Mel Gorman wrote: Should we also consider printing the MOF and MORON states so we get a better view of what the actual policy is? MOF and MORON are separate issues because MOF is exposed to the userspace API but not the policies that make up MORON. For MORON, I

[patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-25 Thread David Rientjes
As a result of commit 5606e3877ad8 ("mm: numa: Migrate on reference policy"), /proc//numa_maps prints the mempolicy for any as "prefer:N" for the local node, N, of the process reading the file. This should only be printed when the mempolicy of is MPOL_PREFERRED for node N. If the process is

[patch for-3.14] mm, mempolicy: fix mempolicy printing in numa_maps

2014-01-25 Thread David Rientjes
As a result of commit 5606e3877ad8 (mm: numa: Migrate on reference policy), /proc/pid/numa_maps prints the mempolicy for any pid as prefer:N for the local node, N, of the process reading the file. This should only be printed when the mempolicy of pid is MPOL_PREFERRED for node N. If the