Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Thu, Aug 16, 2012 at 12:15:49AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 15 Aug 2012 09:46:12 +0200 > >> You are probably right. I'm not sure how to handle this correctly >> though. Adding some hard limit number might not be correct. > >I would just use a hard limit of

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Jiri Pirko Date: Wed, 15 Aug 2012 09:46:12 +0200 > You are probably right. I'm not sure how to handle this correctly > though. Adding some hard limit number might not be correct. I would just use a hard limit of something like 8 for now, and if we need to expand this limit we can consider

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Ben Hutchings Date: Tue, 14 Aug 2012 23:33:44 +0100 > I think we will also need to limit the depth of the device stack so we > don't run out of stack space here. __netif_receive() implements a kind > of tail recursion whenever a packet is passed up, but > __netdev_has_upper_dev() can't

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Wed, Aug 15, 2012 at 12:33:44AM CEST, bhutchi...@solarflare.com wrote: >On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >> bonding, bridge, team

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Wed, Aug 15, 2012 at 12:33:44AM CEST, bhutchi...@solarflare.com wrote: On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev-master pointer which is used for bonding, bridge, team but it

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 14 Aug 2012 23:33:44 +0100 I think we will also need to limit the depth of the device stack so we don't run out of stack space here. __netif_receive() implements a kind of tail recursion whenever a packet is passed up, but

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Wed, 15 Aug 2012 09:46:12 +0200 You are probably right. I'm not sure how to handle this correctly though. Adding some hard limit number might not be correct. I would just use a hard limit of something like 8 for now, and if we need to expand this limit

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Thu, Aug 16, 2012 at 12:15:49AM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 15 Aug 2012 09:46:12 +0200 You are probably right. I'm not sure how to handle this correctly though. Adding some hard limit number might not be correct. I would just use a hard limit

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2012 23:33:44 +0100 Ben Hutchings wrote: > On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: > > This lists are supposed to serve for storing pointers to all upper devices. > > Eventually it will replace dev->master pointer which is used for > > bonding, bridge, team but it

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Ben Hutchings
On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: > This lists are supposed to serve for storing pointers to all upper devices. > Eventually it will replace dev->master pointer which is used for > bonding, bridge, team but it cannot be used for vlan, macvlan where > there might be multiple

[patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev->master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple upper present. In case the upper link is replacement for

[patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev-master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple upper present. In case the upper link is replacement for

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Ben Hutchings
On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev-master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple upper

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2012 23:33:44 +0100 Ben Hutchings bhutchi...@solarflare.com wrote: On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev-master pointer which is used for bonding,