Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Alex Shi
On 04/08/2013 11:25 AM, Preeti U Murthy wrote: > Hi Alex, > > I am sorry I overlooked the changes you have made to the power > scheduling policies.Now you have just two : performance and powersave. > > Hence you can ignore my below comments.But if you use group->capacity > instead of

Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Preeti U Murthy
Hi Alex, I am sorry I overlooked the changes you have made to the power scheduling policies.Now you have just two : performance and powersave. Hence you can ignore my below comments.But if you use group->capacity instead of group->weight for threshold,like you did for balance policy in your

Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Preeti U Murthy
Hi Alex, On 04/04/2013 07:31 AM, Alex Shi wrote: > Packing tasks among such domain can't save power, just performance > losing. So no power balance on them. As far as my understanding goes, powersave policy is the one that tries to pack tasks onto a SIBLING domain( domain where SD_SHARE_CPUPOWER

Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Preeti U Murthy
Hi Alex, On 04/04/2013 07:31 AM, Alex Shi wrote: Packing tasks among such domain can't save power, just performance losing. So no power balance on them. As far as my understanding goes, powersave policy is the one that tries to pack tasks onto a SIBLING domain( domain where SD_SHARE_CPUPOWER

Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Preeti U Murthy
Hi Alex, I am sorry I overlooked the changes you have made to the power scheduling policies.Now you have just two : performance and powersave. Hence you can ignore my below comments.But if you use group-capacity instead of group-weight for threshold,like you did for balance policy in your

Re: [patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-07 Thread Alex Shi
On 04/08/2013 11:25 AM, Preeti U Murthy wrote: Hi Alex, I am sorry I overlooked the changes you have made to the power scheduling policies.Now you have just two : performance and powersave. Hence you can ignore my below comments.But if you use group-capacity instead of group-weight for

[patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-03 Thread Alex Shi
Packing tasks among such domain can't save power, just performance losing. So no power balance on them. Signed-off-by: Alex Shi --- kernel/sched/fair.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 047a1b3..3a0284b

[patch v7 20/21] sched: don't do power balance on share cpu power domain

2013-04-03 Thread Alex Shi
Packing tasks among such domain can't save power, just performance losing. So no power balance on them. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index