> Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems
>
>
> > Possibly I should add validation for "num" parameter at the beginning of
> mlxcpld_i2c_xfer?
>
> There is 'max_num_msgs' in the quirk structure.
Yes, I see it.
S
> Possibly I should add validation for "num" parameter at the beginning of
> mlxcpld_i2c_xfer?
There is 'max_num_msgs' in the quirk structure.
Thanks,
Wolfram
signature.asc
Description: PGP signature
.us; Michael Shych
>
> Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems
>
> Hi,
>
> looks mostly good. I just found this comment which needs clarification:
>
> > + /*
> > +* All upper layers currently are never use transfer with more than
> &g
Hi,
looks mostly good. I just found this comment which needs clarification:
> + /*
> + * All upper layers currently are never use transfer with more than
> + * 2 messages.
Have you really checked ALL of the upper layers? And even if so, there
is the dev-interface to userspace which
From: Vadim Pasternak
Device driver for Mellanox I2C controller logic, implemented in Lattice
CPLD device.
Device supports:
- Master mode
- One physical bus
- Polling mode
The Kconfig currently controlling compilation of this code is:
drivers/i2c/busses/Kconfig:config I2C_MLXCPLD
Signed-off-
5 matches
Mail list logo