Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-20 Thread Lei Wen
Morten, On Thu, Jun 20, 2013 at 6:23 PM, Morten Rasmussen wrote: > On Sat, Jun 15, 2013 at 01:09:12PM +0100, Lei Wen wrote: >> On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi wrote: >> > On 06/14/2013 06:02 PM, Lei Wen wrote: >> >>> > enqueue_entity >> >>> >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-20 Thread Morten Rasmussen
On Sat, Jun 15, 2013 at 01:09:12PM +0100, Lei Wen wrote: > On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi wrote: > > On 06/14/2013 06:02 PM, Lei Wen wrote: > >>> > enqueue_entity > >>> > enqueue_entity_load_avg > >>> > > >>> > and make forking balancing imbalance since incorrect

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-20 Thread Morten Rasmussen
On Sat, Jun 15, 2013 at 01:09:12PM +0100, Lei Wen wrote: On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi alex@intel.com wrote: On 06/14/2013 06:02 PM, Lei Wen wrote: enqueue_entity enqueue_entity_load_avg and make forking balancing imbalance since incorrect

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-20 Thread Lei Wen
Morten, On Thu, Jun 20, 2013 at 6:23 PM, Morten Rasmussen morten.rasmus...@arm.com wrote: On Sat, Jun 15, 2013 at 01:09:12PM +0100, Lei Wen wrote: On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi alex@intel.com wrote: On 06/14/2013 06:02 PM, Lei Wen wrote: enqueue_entity

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Alex Shi
> > Example: > > From: PJT > > foo patch implements foo because bar; note the fubar detail. > > SoB: PJT > [alex@intel: changed ponies into horses to make it fit] > SoB: Alex > > The other case is where a 'simple' modification of the initial patch > simply won't do; you need to change the

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 05:57:50PM +0800, Alex Shi wrote: > On 06/17/2013 05:21 PM, Peter Zijlstra wrote: > >> > > >> > and make forking balancing imbalance since incorrect load_avg_contrib. > >> > > >> > Further more, Morten Rasmussen notice some tasks were not launched at > >> > once after

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 02:39:53AM -0700, Paul Turner wrote: > I actually did read it before, and still wasn't sure of the right tag to use. > > "13) When to use Acked-by: and Cc: > > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 08:26:55PM +0800, Lei Wen wrote: > Hi Peter, > > > So the 'problem' is that our running avg is a 'floating' average; ie. it > > decays with time. Now we have to guess about the future of our newly > > spawned task -- something that is nigh impossible seeing these CPU > >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Lei Wen
Hi Peter, On Mon, Jun 17, 2013 at 5:20 PM, Peter Zijlstra wrote: > On Fri, Jun 14, 2013 at 06:02:45PM +0800, Lei Wen wrote: >> Hi Alex, >> >> On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi wrote: >> > We need initialize the se.avg.{decay_count, load_avg_contrib} for a >> > new forked task. >> >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Alex Shi
On 06/17/2013 05:21 PM, Peter Zijlstra wrote: >> > >> > and make forking balancing imbalance since incorrect load_avg_contrib. >> > >> > Further more, Morten Rasmussen notice some tasks were not launched at >> > once after created. So Paul and Peter suggest giving a start value for >> > new task

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Paul Turner
I actually did read it before, and still wasn't sure of the right tag to use. "13) When to use Acked-by: and Cc: The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. If a person was not directly involved

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Fri, Jun 14, 2013 at 10:16:28PM +0800, Alex Shi wrote: > On 06/14/2013 07:09 PM, Paul Turner wrote: > > Minor comments; looks good otherwise. > > > > Signed-off-by: Paul Turner > > thanks a lot Paul. the patch with your input updated here: > > BTW, would you like to give some comments on

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Fri, Jun 14, 2013 at 06:02:45PM +0800, Lei Wen wrote: > Hi Alex, > > On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi wrote: > > We need initialize the se.avg.{decay_count, load_avg_contrib} for a > > new forked task. > > Otherwise random values of above variables cause mess when do new task > >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Fri, Jun 14, 2013 at 06:02:45PM +0800, Lei Wen wrote: Hi Alex, On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi alex@intel.com wrote: We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when do new task

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Fri, Jun 14, 2013 at 10:16:28PM +0800, Alex Shi wrote: On 06/14/2013 07:09 PM, Paul Turner wrote: Minor comments; looks good otherwise. Signed-off-by: Paul Turner p...@google.com thanks a lot Paul. the patch with your input updated here: BTW, would you like to give some comments

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Paul Turner
I actually did read it before, and still wasn't sure of the right tag to use. 13) When to use Acked-by: and Cc: The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. If a person was not directly involved

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Alex Shi
On 06/17/2013 05:21 PM, Peter Zijlstra wrote: and make forking balancing imbalance since incorrect load_avg_contrib. Further more, Morten Rasmussen notice some tasks were not launched at once after created. So Paul and Peter suggest giving a start value for new task runnable avg time

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Lei Wen
Hi Peter, On Mon, Jun 17, 2013 at 5:20 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, Jun 14, 2013 at 06:02:45PM +0800, Lei Wen wrote: Hi Alex, On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi alex@intel.com wrote: We need initialize the se.avg.{decay_count, load_avg_contrib} for a

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 08:26:55PM +0800, Lei Wen wrote: Hi Peter, So the 'problem' is that our running avg is a 'floating' average; ie. it decays with time. Now we have to guess about the future of our newly spawned task -- something that is nigh impossible seeing these CPU vendors

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 02:39:53AM -0700, Paul Turner wrote: I actually did read it before, and still wasn't sure of the right tag to use. 13) When to use Acked-by: and Cc: The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 05:57:50PM +0800, Alex Shi wrote: On 06/17/2013 05:21 PM, Peter Zijlstra wrote: and make forking balancing imbalance since incorrect load_avg_contrib. Further more, Morten Rasmussen notice some tasks were not launched at once after created. So Paul and

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-17 Thread Alex Shi
Example: From: PJT foo patch implements foo because bar; note the fubar detail. SoB: PJT [alex@intel: changed ponies into horses to make it fit] SoB: Alex The other case is where a 'simple' modification of the initial patch simply won't do; you need to change the core idea of the

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-16 Thread Alex Shi
On 06/15/2013 08:09 PM, Lei Wen wrote: > >>> > and make forking balancing imbalance since incorrect > >>> > load_avg_contrib. > >>> > > >>> > Further more, Morten Rasmussen notice some tasks were not launched > >>> > at > >>> > once after created. So Paul and Peter

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-16 Thread Alex Shi
On 06/15/2013 08:09 PM, Lei Wen wrote: and make forking balancing imbalance since incorrect load_avg_contrib. Further more, Morten Rasmussen notice some tasks were not launched at once after created. So Paul and Peter suggest giving a start value for new task runnable

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-15 Thread Lei Wen
On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi wrote: > On 06/14/2013 06:02 PM, Lei Wen wrote: >>> > enqueue_entity >>> > enqueue_entity_load_avg >>> > >>> > and make forking balancing imbalance since incorrect load_avg_contrib. >>> > >>> > Further more, Morten Rasmussen notice

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-15 Thread Lei Wen
On Fri, Jun 14, 2013 at 9:59 PM, Alex Shi alex@intel.com wrote: On 06/14/2013 06:02 PM, Lei Wen wrote: enqueue_entity enqueue_entity_load_avg and make forking balancing imbalance since incorrect load_avg_contrib. Further more, Morten Rasmussen notice some tasks

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Alex Shi
On 06/14/2013 07:09 PM, Paul Turner wrote: > Minor comments; looks good otherwise. > > Signed-off-by: Paul Turner thanks a lot Paul. the patch with your input updated here: BTW, would you like to give some comments on the last patch of this patchset? --- >From

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Alex Shi
On 06/14/2013 06:02 PM, Lei Wen wrote: >> > enqueue_entity >> > enqueue_entity_load_avg >> > >> > and make forking balancing imbalance since incorrect load_avg_contrib. >> > >> > Further more, Morten Rasmussen notice some tasks were not launched at >> > once after created. So

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Paul Turner
Minor comments; looks good otherwise. Signed-off-by: Paul Turner On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: > We need initialize the se.avg.{decay_count, load_avg_contrib} for a > new forked task. > Otherwise random values of above variables cause mess when do new task > enqueue: >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Lei Wen
Hi Alex, On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi wrote: > We need initialize the se.avg.{decay_count, load_avg_contrib} for a > new forked task. > Otherwise random values of above variables cause mess when do new task > enqueue: > enqueue_task_fair > enqueue_entity >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Lei Wen
Hi Alex, On Fri, Jun 7, 2013 at 3:20 PM, Alex Shi alex@intel.com wrote: We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when do new task enqueue: enqueue_task_fair enqueue_entity

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Paul Turner
Minor comments; looks good otherwise. Signed-off-by: Paul Turner p...@google.com On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi alex@intel.com wrote: We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Alex Shi
On 06/14/2013 06:02 PM, Lei Wen wrote: enqueue_entity enqueue_entity_load_avg and make forking balancing imbalance since incorrect load_avg_contrib. Further more, Morten Rasmussen notice some tasks were not launched at once after created. So Paul and Peter suggest

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-14 Thread Alex Shi
On 06/14/2013 07:09 PM, Paul Turner wrote: Minor comments; looks good otherwise. Signed-off-by: Paul Turner p...@google.com thanks a lot Paul. the patch with your input updated here: BTW, would you like to give some comments on the last patch of this patchset? --- From

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-09 Thread Gu Zheng
On 06/07/2013 03:20 PM, Alex Shi wrote: > We need initialize the se.avg.{decay_count, load_avg_contrib} for a > new forked task. > Otherwise random values of above variables cause mess when do new task > enqueue: > enqueue_task_fair > enqueue_entity >

Re: [patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-09 Thread Gu Zheng
On 06/07/2013 03:20 PM, Alex Shi wrote: We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when do new task enqueue: enqueue_task_fair enqueue_entity enqueue_entity_load_avg

[patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-07 Thread Alex Shi
We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when do new task enqueue: enqueue_task_fair enqueue_entity enqueue_entity_load_avg and make forking balancing imbalance since

[patch v8 3/9] sched: set initial value of runnable avg for new forked task

2013-06-07 Thread Alex Shi
We need initialize the se.avg.{decay_count, load_avg_contrib} for a new forked task. Otherwise random values of above variables cause mess when do new task enqueue: enqueue_task_fair enqueue_entity enqueue_entity_load_avg and make forking balancing imbalance since