Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 22:07:58, Sergey Senozhatsky wrote: > On (20/07/09 14:25), Petr Mladek wrote: > > On Thu 2020-07-09 13:23:07, John Ogness wrote: > > > On 2020-07-09, Petr Mladek wrote: > > > > I though more about it. IMHO, it will be better to modify > > > > prb_first_seq() to do the same cycle

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Sergey Senozhatsky
On (20/07/09 14:25), Petr Mladek wrote: > On Thu 2020-07-09 13:23:07, John Ogness wrote: > > On 2020-07-09, Petr Mladek wrote: > > > I though more about it. IMHO, it will be better to modify > > > prb_first_seq() to do the same cycle as prb_next_seq() > > > and return seq number of the first

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 13:23:07, John Ogness wrote: > On 2020-07-09, Petr Mladek wrote: > > I though more about it. IMHO, it will be better to modify > > prb_first_seq() to do the same cycle as prb_next_seq() > > and return seq number of the first valid entry. > > Exactly! > > Here is a patch that

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread John Ogness
On 2020-07-09, Petr Mladek wrote: > I though more about it. IMHO, it will be better to modify > prb_first_seq() to do the same cycle as prb_next_seq() > and return seq number of the first valid entry. Exactly! Here is a patch that does just that. I added a prb_first_valid_seq() function and

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 12:59:06, Petr Mladek wrote: > On Thu 2020-07-09 12:20:35, John Ogness wrote: > > On 2020-07-09, Sergey Senozhatsky wrote: > > > On (20/07/09 15:14), kernel test robot wrote: > > > [..] > > > > > > Took me a while to find the FAIL-ed test: > > > > > >> kmsg01.c:393: INFO: TEST:

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 12:20:35, John Ogness wrote: > On 2020-07-09, Sergey Senozhatsky wrote: > > On (20/07/09 15:14), kernel test robot wrote: > > [..] > > > > Took me a while to find the FAIL-ed test: > > > >> kmsg01.c:393: INFO: TEST: read returns EPIPE when messages get overwritten > >>

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread John Ogness
On 2020-07-09, Sergey Senozhatsky wrote: > On (20/07/09 15:14), kernel test robot wrote: > [..] > > Took me a while to find the FAIL-ed test: > >> kmsg01.c:393: INFO: TEST: read returns EPIPE when messages get overwritten >> kmsg01.c:398: INFO: first seqno: 0 >> kmsg01.c:411: INFO: first seqno

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Sergey Senozhatsky
On (20/07/09 15:14), kernel test robot wrote: [..] Took me a while to find the FAIL-ed test: > kmsg01.c:393: INFO: TEST: read returns EPIPE when messages get overwritten > kmsg01.c:398: INFO: first seqno: 0 > kmsg01.c:411: INFO: first seqno now: 881 > kmsg01.c:425: FAIL: read returned: 77: