Re: [regression] tty console panic for 4.13-rcx

2017-08-07 Thread Shawn Lin


On 2017/8/7 12:00, Shawn Lin wrote:

Hi,

I saw the log at the bottom and bisect the issue to the commits of

065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
979990c628481461 ("tty: improve tty_insert_flip_char() fast path")

I nearly could 100% reproduce this. Any thought?


Ouch.. I thought 4.13.0-rc3-next-20170802-2-gd66440a-dirty
is new enough and I didn't fetch the linux-next again to avoid
rebase but seems it's fixed just on that day.. 20170802

8a5a90a2a477b ("tty: fix __tty_insert_flip_char regression")

This patch works well, sorry for the noise...




  [  154.823106] Unable to handle kernel NULL pointer dereference at 
virtual address 000d

[  154.823885] user pgtable: 4k pages, 48-bit VAs, pgd = 800066e79000
[  154.824464] [000d] *pgd=6768a003, 
*pud=6a7da003, *pmd=669c3003, *pte=

[  154.825460] Internal error: Oops: 9607 [#1] PREEMPT SMP
[  154.825957] Modules linked in:
[  154.826258] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 
4.13.0-rc3-next-20170802-2-gd66440a-dirty #112

[  154.827091] Hardware name: Firefly-RK3399 Board (DT)
[  154.827539] task: 28f42b00 task.stack: 28f3
[  154.828083] PC is at llist_del_first+0x8/0x74
[  154.828481] LR is at __tty_buffer_request_room+0x114/0x148
[  154.828972] pc : [] lr : [] 
pstate: 61c5

[  154.829625] sp : 80007ef10d00
[  154.829925] x29: 80007ef10d00 x28: 28f42b00
[  154.830409] x27: 28cc7458 x26: 28cc7430
[  154.830892] x25: 0026 x24: 
[  154.831373] x23:  x22: 0001
[  154.831854] x21: 80006b37b600 x20: 0100
[  154.832337] x19: 80006a8a5840 x18: 
[  154.832819] x17:  x16: 2821b398
[  154.833300] x15:  x14: 3d097d00
[  154.833781] x13: 00017700 x12: 009a
[  154.834263] x11: 7fff x10: 0002
[  154.834744] x9 : 0003 x8 : 
[  154.835225] x7 : 003d0900 x6 : 
[  154.835706] x5 : 0100 x4 : 0200
[  154.836187] x3 : 0001 x2 : 000d
[  154.836668] x1 : 0200 x0 : 80006a8a58b0
[  154.837153] Process swapper/0 (pid: 0, stack limit = 0x28f3)
[  154.837750] Stack: (0x80007ef10d00 to 0x28f34000)
[  154.838261] Call trace:
[  154.838493] Exception stack(0x80007ef10b30 to 0x80007ef10c60)
[  154.839068] 0b20:   80006a8a5840 
0001
[  154.839766] 0b40: 80007ef10d00 283b813c 800069219180 
80007ef1c968
[  154.840464] 0b60: 80007ef10b70 280f31d0 80007ef10bf0 
280e7cf0
[  154.841161] 0b80: 80007ef1c900 80007ef1c900 0004 
01c0
[  154.841859] 0ba0: 80007ef1c900 28f39ba8  
0001
[  154.842557] 0bc0: 80007ef10be0 280e7e5c 80006a8a58b0 
0200
[  154.843252] 0be0: 000d 0001 0200 
0100
[  154.843949] 0c00:  003d0900  
0003
[  154.844645] 0c20: 0002 7fff 009a 
00017700
[  154.845342] 0c40: 3d097d00  2821b398 


[  154.846040] [] llist_del_first+0x8/0x74
[  154.846528] [] __tty_insert_flip_char+0x2c/0x78
[  154.847076] [] uart_insert_char+0x54/0x13c
[  154.847589] [] serial8250_rx_chars+0x98/0x1e8
[  154.848124] [] serial8250_handle_irq.part.23+0x70/0xec
[  154.848725] [] serial8250_handle_irq+0x14/0x24
[  154.849264] [] dw8250_handle_irq+0x40/0xfc
[  154.849774] [] serial8250_interrupt+0x6c/0xec
[  154.850309] [] __handle_irq_event_percpu+0xa0/0x128
[  154.850887] [] handle_irq_event_percpu+0x1c/0x54
[  154.851442] [] handle_irq_event+0x44/0x74
[  154.851947] [] handle_fasteoi_irq+0x9c/0x154
[  154.852470] [] generic_handle_irq+0x24/0x38
[  154.852986] [] __handle_domain_irq+0x60/0xac
[  154.853510] [] gic_handle_irq+0xd4/0x17c
[  154.854001] Exception stack(0x28f33da0 to 0x28f33ed0)
[  154.854576] 3da0:   0001 

[  154.855273] 3dc0:  600075ff6000 0001 

[  154.855970] 3de0: 28f43560 28f33e50 0a00 

[  154.85] 3e00: 014f ffd42070 f7934d7b 

[  154.857365] 3e20: 2821b398   
28f17000
[  154.858064] 3e40: 28f39000 28f39000 28f25820 
28f39e98
[  154.858761] 3e60:   28f42b00 

[  154.859458] 3e80: 02e00018 28f33ed0 280852ec 
28f33ed0
[  154.860156] 3ea0: 

Re: [regression] tty console panic for 4.13-rcx

2017-08-07 Thread Shawn Lin


On 2017/8/7 12:00, Shawn Lin wrote:

Hi,

I saw the log at the bottom and bisect the issue to the commits of

065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
979990c628481461 ("tty: improve tty_insert_flip_char() fast path")

I nearly could 100% reproduce this. Any thought?


Ouch.. I thought 4.13.0-rc3-next-20170802-2-gd66440a-dirty
is new enough and I didn't fetch the linux-next again to avoid
rebase but seems it's fixed just on that day.. 20170802

8a5a90a2a477b ("tty: fix __tty_insert_flip_char regression")

This patch works well, sorry for the noise...




  [  154.823106] Unable to handle kernel NULL pointer dereference at 
virtual address 000d

[  154.823885] user pgtable: 4k pages, 48-bit VAs, pgd = 800066e79000
[  154.824464] [000d] *pgd=6768a003, 
*pud=6a7da003, *pmd=669c3003, *pte=

[  154.825460] Internal error: Oops: 9607 [#1] PREEMPT SMP
[  154.825957] Modules linked in:
[  154.826258] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 
4.13.0-rc3-next-20170802-2-gd66440a-dirty #112

[  154.827091] Hardware name: Firefly-RK3399 Board (DT)
[  154.827539] task: 28f42b00 task.stack: 28f3
[  154.828083] PC is at llist_del_first+0x8/0x74
[  154.828481] LR is at __tty_buffer_request_room+0x114/0x148
[  154.828972] pc : [] lr : [] 
pstate: 61c5

[  154.829625] sp : 80007ef10d00
[  154.829925] x29: 80007ef10d00 x28: 28f42b00
[  154.830409] x27: 28cc7458 x26: 28cc7430
[  154.830892] x25: 0026 x24: 
[  154.831373] x23:  x22: 0001
[  154.831854] x21: 80006b37b600 x20: 0100
[  154.832337] x19: 80006a8a5840 x18: 
[  154.832819] x17:  x16: 2821b398
[  154.833300] x15:  x14: 3d097d00
[  154.833781] x13: 00017700 x12: 009a
[  154.834263] x11: 7fff x10: 0002
[  154.834744] x9 : 0003 x8 : 
[  154.835225] x7 : 003d0900 x6 : 
[  154.835706] x5 : 0100 x4 : 0200
[  154.836187] x3 : 0001 x2 : 000d
[  154.836668] x1 : 0200 x0 : 80006a8a58b0
[  154.837153] Process swapper/0 (pid: 0, stack limit = 0x28f3)
[  154.837750] Stack: (0x80007ef10d00 to 0x28f34000)
[  154.838261] Call trace:
[  154.838493] Exception stack(0x80007ef10b30 to 0x80007ef10c60)
[  154.839068] 0b20:   80006a8a5840 
0001
[  154.839766] 0b40: 80007ef10d00 283b813c 800069219180 
80007ef1c968
[  154.840464] 0b60: 80007ef10b70 280f31d0 80007ef10bf0 
280e7cf0
[  154.841161] 0b80: 80007ef1c900 80007ef1c900 0004 
01c0
[  154.841859] 0ba0: 80007ef1c900 28f39ba8  
0001
[  154.842557] 0bc0: 80007ef10be0 280e7e5c 80006a8a58b0 
0200
[  154.843252] 0be0: 000d 0001 0200 
0100
[  154.843949] 0c00:  003d0900  
0003
[  154.844645] 0c20: 0002 7fff 009a 
00017700
[  154.845342] 0c40: 3d097d00  2821b398 


[  154.846040] [] llist_del_first+0x8/0x74
[  154.846528] [] __tty_insert_flip_char+0x2c/0x78
[  154.847076] [] uart_insert_char+0x54/0x13c
[  154.847589] [] serial8250_rx_chars+0x98/0x1e8
[  154.848124] [] serial8250_handle_irq.part.23+0x70/0xec
[  154.848725] [] serial8250_handle_irq+0x14/0x24
[  154.849264] [] dw8250_handle_irq+0x40/0xfc
[  154.849774] [] serial8250_interrupt+0x6c/0xec
[  154.850309] [] __handle_irq_event_percpu+0xa0/0x128
[  154.850887] [] handle_irq_event_percpu+0x1c/0x54
[  154.851442] [] handle_irq_event+0x44/0x74
[  154.851947] [] handle_fasteoi_irq+0x9c/0x154
[  154.852470] [] generic_handle_irq+0x24/0x38
[  154.852986] [] __handle_domain_irq+0x60/0xac
[  154.853510] [] gic_handle_irq+0xd4/0x17c
[  154.854001] Exception stack(0x28f33da0 to 0x28f33ed0)
[  154.854576] 3da0:   0001 

[  154.855273] 3dc0:  600075ff6000 0001 

[  154.855970] 3de0: 28f43560 28f33e50 0a00 

[  154.85] 3e00: 014f ffd42070 f7934d7b 

[  154.857365] 3e20: 2821b398   
28f17000
[  154.858064] 3e40: 28f39000 28f39000 28f25820 
28f39e98
[  154.858761] 3e60:   28f42b00 

[  154.859458] 3e80: 02e00018 28f33ed0 280852ec 
28f33ed0
[  154.860156] 3ea0: 

Re: [regression] tty console panic for 4.13-rcx

2017-08-07 Thread Jiri Slaby
On 08/07/2017, 06:00 AM, Shawn Lin wrote:
> Hi,
> 
> I saw the log at the bottom and bisect the issue to the commits of
> 
> 065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
> 979990c628481461 ("tty: improve tty_insert_flip_char() fast path")
> 
> I nearly could 100% reproduce this. Any thought?

Hi,

could you test with:
https://lkml.org/lkml/2017/8/2/326
?

thanks,
-- 
js
suse labs


Re: [regression] tty console panic for 4.13-rcx

2017-08-07 Thread Jiri Slaby
On 08/07/2017, 06:00 AM, Shawn Lin wrote:
> Hi,
> 
> I saw the log at the bottom and bisect the issue to the commits of
> 
> 065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
> 979990c628481461 ("tty: improve tty_insert_flip_char() fast path")
> 
> I nearly could 100% reproduce this. Any thought?

Hi,

could you test with:
https://lkml.org/lkml/2017/8/2/326
?

thanks,
-- 
js
suse labs


[regression] tty console panic for 4.13-rcx

2017-08-06 Thread Shawn Lin

Hi,

I saw the log at the bottom and bisect the issue to the commits of

065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
979990c628481461 ("tty: improve tty_insert_flip_char() fast path")

I nearly could 100% reproduce this. Any thought?


 [  154.823106] Unable to handle kernel NULL pointer dereference at 
virtual address 000d

[  154.823885] user pgtable: 4k pages, 48-bit VAs, pgd = 800066e79000
[  154.824464] [000d] *pgd=6768a003, 
*pud=6a7da003, *pmd=669c3003, *pte=

[  154.825460] Internal error: Oops: 9607 [#1] PREEMPT SMP
[  154.825957] Modules linked in:
[  154.826258] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 
4.13.0-rc3-next-20170802-2-gd66440a-dirty #112

[  154.827091] Hardware name: Firefly-RK3399 Board (DT)
[  154.827539] task: 28f42b00 task.stack: 28f3
[  154.828083] PC is at llist_del_first+0x8/0x74
[  154.828481] LR is at __tty_buffer_request_room+0x114/0x148
[  154.828972] pc : [] lr : [] 
pstate: 61c5

[  154.829625] sp : 80007ef10d00
[  154.829925] x29: 80007ef10d00 x28: 28f42b00
[  154.830409] x27: 28cc7458 x26: 28cc7430
[  154.830892] x25: 0026 x24: 
[  154.831373] x23:  x22: 0001
[  154.831854] x21: 80006b37b600 x20: 0100
[  154.832337] x19: 80006a8a5840 x18: 
[  154.832819] x17:  x16: 2821b398
[  154.833300] x15:  x14: 3d097d00
[  154.833781] x13: 00017700 x12: 009a
[  154.834263] x11: 7fff x10: 0002
[  154.834744] x9 : 0003 x8 : 
[  154.835225] x7 : 003d0900 x6 : 
[  154.835706] x5 : 0100 x4 : 0200
[  154.836187] x3 : 0001 x2 : 000d
[  154.836668] x1 : 0200 x0 : 80006a8a58b0
[  154.837153] Process swapper/0 (pid: 0, stack limit = 0x28f3)
[  154.837750] Stack: (0x80007ef10d00 to 0x28f34000)
[  154.838261] Call trace:
[  154.838493] Exception stack(0x80007ef10b30 to 0x80007ef10c60)
[  154.839068] 0b20:   80006a8a5840 
0001
[  154.839766] 0b40: 80007ef10d00 283b813c 800069219180 
80007ef1c968
[  154.840464] 0b60: 80007ef10b70 280f31d0 80007ef10bf0 
280e7cf0
[  154.841161] 0b80: 80007ef1c900 80007ef1c900 0004 
01c0
[  154.841859] 0ba0: 80007ef1c900 28f39ba8  
0001
[  154.842557] 0bc0: 80007ef10be0 280e7e5c 80006a8a58b0 
0200
[  154.843252] 0be0: 000d 0001 0200 
0100
[  154.843949] 0c00:  003d0900  
0003
[  154.844645] 0c20: 0002 7fff 009a 
00017700
[  154.845342] 0c40: 3d097d00  2821b398 


[  154.846040] [] llist_del_first+0x8/0x74
[  154.846528] [] __tty_insert_flip_char+0x2c/0x78
[  154.847076] [] uart_insert_char+0x54/0x13c
[  154.847589] [] serial8250_rx_chars+0x98/0x1e8
[  154.848124] [] serial8250_handle_irq.part.23+0x70/0xec
[  154.848725] [] serial8250_handle_irq+0x14/0x24
[  154.849264] [] dw8250_handle_irq+0x40/0xfc
[  154.849774] [] serial8250_interrupt+0x6c/0xec
[  154.850309] [] __handle_irq_event_percpu+0xa0/0x128
[  154.850887] [] handle_irq_event_percpu+0x1c/0x54
[  154.851442] [] handle_irq_event+0x44/0x74
[  154.851947] [] handle_fasteoi_irq+0x9c/0x154
[  154.852470] [] generic_handle_irq+0x24/0x38
[  154.852986] [] __handle_domain_irq+0x60/0xac
[  154.853510] [] gic_handle_irq+0xd4/0x17c
[  154.854001] Exception stack(0x28f33da0 to 0x28f33ed0)
[  154.854576] 3da0:   0001 

[  154.855273] 3dc0:  600075ff6000 0001 

[  154.855970] 3de0: 28f43560 28f33e50 0a00 

[  154.85] 3e00: 014f ffd42070 f7934d7b 

[  154.857365] 3e20: 2821b398   
28f17000
[  154.858064] 3e40: 28f39000 28f39000 28f25820 
28f39e98
[  154.858761] 3e60:   28f42b00 

[  154.859458] 3e80: 02e00018 28f33ed0 280852ec 
28f33ed0
[  154.860156] 3ea0: 280852f0 6145 7df19878 
7ffa7010

[  154.860851] 3ec0:  2813744c
[  154.861293] [] el1_irq+0xb4/0x128
[  154.861737] [] arch_cpu_idle+0x10/0x18
[  154.86] [] default_idle_call+0x18/0x2c
[  154.862735] [] do_idle+0x170/0x1fc
[  154.863187] [] cpu_startup_entry+0x1c/0x24
[  

[regression] tty console panic for 4.13-rcx

2017-08-06 Thread Shawn Lin

Hi,

I saw the log at the bottom and bisect the issue to the commits of

065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path")
979990c628481461 ("tty: improve tty_insert_flip_char() fast path")

I nearly could 100% reproduce this. Any thought?


 [  154.823106] Unable to handle kernel NULL pointer dereference at 
virtual address 000d

[  154.823885] user pgtable: 4k pages, 48-bit VAs, pgd = 800066e79000
[  154.824464] [000d] *pgd=6768a003, 
*pud=6a7da003, *pmd=669c3003, *pte=

[  154.825460] Internal error: Oops: 9607 [#1] PREEMPT SMP
[  154.825957] Modules linked in:
[  154.826258] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 
4.13.0-rc3-next-20170802-2-gd66440a-dirty #112

[  154.827091] Hardware name: Firefly-RK3399 Board (DT)
[  154.827539] task: 28f42b00 task.stack: 28f3
[  154.828083] PC is at llist_del_first+0x8/0x74
[  154.828481] LR is at __tty_buffer_request_room+0x114/0x148
[  154.828972] pc : [] lr : [] 
pstate: 61c5

[  154.829625] sp : 80007ef10d00
[  154.829925] x29: 80007ef10d00 x28: 28f42b00
[  154.830409] x27: 28cc7458 x26: 28cc7430
[  154.830892] x25: 0026 x24: 
[  154.831373] x23:  x22: 0001
[  154.831854] x21: 80006b37b600 x20: 0100
[  154.832337] x19: 80006a8a5840 x18: 
[  154.832819] x17:  x16: 2821b398
[  154.833300] x15:  x14: 3d097d00
[  154.833781] x13: 00017700 x12: 009a
[  154.834263] x11: 7fff x10: 0002
[  154.834744] x9 : 0003 x8 : 
[  154.835225] x7 : 003d0900 x6 : 
[  154.835706] x5 : 0100 x4 : 0200
[  154.836187] x3 : 0001 x2 : 000d
[  154.836668] x1 : 0200 x0 : 80006a8a58b0
[  154.837153] Process swapper/0 (pid: 0, stack limit = 0x28f3)
[  154.837750] Stack: (0x80007ef10d00 to 0x28f34000)
[  154.838261] Call trace:
[  154.838493] Exception stack(0x80007ef10b30 to 0x80007ef10c60)
[  154.839068] 0b20:   80006a8a5840 
0001
[  154.839766] 0b40: 80007ef10d00 283b813c 800069219180 
80007ef1c968
[  154.840464] 0b60: 80007ef10b70 280f31d0 80007ef10bf0 
280e7cf0
[  154.841161] 0b80: 80007ef1c900 80007ef1c900 0004 
01c0
[  154.841859] 0ba0: 80007ef1c900 28f39ba8  
0001
[  154.842557] 0bc0: 80007ef10be0 280e7e5c 80006a8a58b0 
0200
[  154.843252] 0be0: 000d 0001 0200 
0100
[  154.843949] 0c00:  003d0900  
0003
[  154.844645] 0c20: 0002 7fff 009a 
00017700
[  154.845342] 0c40: 3d097d00  2821b398 


[  154.846040] [] llist_del_first+0x8/0x74
[  154.846528] [] __tty_insert_flip_char+0x2c/0x78
[  154.847076] [] uart_insert_char+0x54/0x13c
[  154.847589] [] serial8250_rx_chars+0x98/0x1e8
[  154.848124] [] serial8250_handle_irq.part.23+0x70/0xec
[  154.848725] [] serial8250_handle_irq+0x14/0x24
[  154.849264] [] dw8250_handle_irq+0x40/0xfc
[  154.849774] [] serial8250_interrupt+0x6c/0xec
[  154.850309] [] __handle_irq_event_percpu+0xa0/0x128
[  154.850887] [] handle_irq_event_percpu+0x1c/0x54
[  154.851442] [] handle_irq_event+0x44/0x74
[  154.851947] [] handle_fasteoi_irq+0x9c/0x154
[  154.852470] [] generic_handle_irq+0x24/0x38
[  154.852986] [] __handle_domain_irq+0x60/0xac
[  154.853510] [] gic_handle_irq+0xd4/0x17c
[  154.854001] Exception stack(0x28f33da0 to 0x28f33ed0)
[  154.854576] 3da0:   0001 

[  154.855273] 3dc0:  600075ff6000 0001 

[  154.855970] 3de0: 28f43560 28f33e50 0a00 

[  154.85] 3e00: 014f ffd42070 f7934d7b 

[  154.857365] 3e20: 2821b398   
28f17000
[  154.858064] 3e40: 28f39000 28f39000 28f25820 
28f39e98
[  154.858761] 3e60:   28f42b00 

[  154.859458] 3e80: 02e00018 28f33ed0 280852ec 
28f33ed0
[  154.860156] 3ea0: 280852f0 6145 7df19878 
7ffa7010

[  154.860851] 3ec0:  2813744c
[  154.861293] [] el1_irq+0xb4/0x128
[  154.861737] [] arch_cpu_idle+0x10/0x18
[  154.86] [] default_idle_call+0x18/0x2c
[  154.862735] [] do_idle+0x170/0x1fc
[  154.863187] [] cpu_startup_entry+0x1c/0x24
[