Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Fengguang Wu
On Mon, Dec 04, 2006 at 03:55:52PM +0100, Nick Piggin wrote: > Hi Mel, > > I think you're right about the leakage, thanks for catching it. Yeah, it caused oom storm here. The pagevec simplification looks nice. I've ported it to -mm, hope it is useful. I'm prepared to test your revised patch :)

Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Nick Piggin
On Mon, Dec 04, 2006 at 02:40:05PM +, Mel Gorman wrote: > On (02/12/06 13:15), Nick Piggin didst pronounce: > > Hi, > > > > While working in this area, I noticed a few things we do that may not > > have a positive payoff under the most common conditions. Untested yet, > > and probably needs a

Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Mel Gorman
On (02/12/06 13:15), Nick Piggin didst pronounce: > Hi, > > While working in this area, I noticed a few things we do that may not > have a positive payoff under the most common conditions. Untested yet, > and probably needs a bit of instrumentation, but it saves about half a > K of code, lots of

Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Mel Gorman
On (02/12/06 13:15), Nick Piggin didst pronounce: Hi, While working in this area, I noticed a few things we do that may not have a positive payoff under the most common conditions. Untested yet, and probably needs a bit of instrumentation, but it saves about half a K of code, lots of

Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Nick Piggin
On Mon, Dec 04, 2006 at 02:40:05PM +, Mel Gorman wrote: On (02/12/06 13:15), Nick Piggin didst pronounce: Hi, While working in this area, I noticed a few things we do that may not have a positive payoff under the most common conditions. Untested yet, and probably needs a bit of

Re: [rfc] possible page manipulation simplifications?

2006-12-04 Thread Fengguang Wu
On Mon, Dec 04, 2006 at 03:55:52PM +0100, Nick Piggin wrote: Hi Mel, I think you're right about the leakage, thanks for catching it. Yeah, it caused oom storm here. The pagevec simplification looks nice. I've ported it to -mm, hope it is useful. I'm prepared to test your revised patch :)

[rfc] possible page manipulation simplifications?

2006-12-02 Thread Nick Piggin
Hi, While working in this area, I noticed a few things we do that may not have a positive payoff under the most common conditions. Untested yet, and probably needs a bit of instrumentation, but it saves about half a K of code, lots of branches, and makes things look nicer. Any thoughts? Quite a

[rfc] possible page manipulation simplifications?

2006-12-02 Thread Nick Piggin
Hi, While working in this area, I noticed a few things we do that may not have a positive payoff under the most common conditions. Untested yet, and probably needs a bit of instrumentation, but it saves about half a K of code, lots of branches, and makes things look nicer. Any thoughts? Quite a