Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
Aurelien spotted a problem with the patch - will resend to you On Mon, Jun 18, 2018 at 12:34 PM, Gustavo A. R. Silva wrote: > Hey Steve, > > On 06/18/2018 12:18 PM, Steve French wrote: >> >> Gustavo, >> Thx for pointing this out. Let me know if this patch addresses what >> you found. Code is

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
Aurelien spotted a problem with the patch - will resend to you On Mon, Jun 18, 2018 at 12:34 PM, Gustavo A. R. Silva wrote: > Hey Steve, > > On 06/18/2018 12:18 PM, Steve French wrote: >> >> Gustavo, >> Thx for pointing this out. Let me know if this patch addresses what >> you found. Code is

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Gustavo A. R. Silva
Hey Steve, On 06/18/2018 12:18 PM, Steve French wrote: Gustavo, Thx for pointing this out. Let me know if this patch addresses what you found. Code is experimental mount option but extremely important to get right due to move away from SMB1/CIFS which had posix extensions. Yep. It seems

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Gustavo A. R. Silva
Hey Steve, On 06/18/2018 12:18 PM, Steve French wrote: Gustavo, Thx for pointing this out. Let me know if this patch addresses what you found. Code is experimental mount option but extremely important to get right due to move away from SMB1/CIFS which had posix extensions. Yep. It seems

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
Gustavo, Thx for pointing this out. Let me know if this patch addresses what you found. Code is experimental mount option but extremely important to get right due to move away from SMB1/CIFS which had posix extensions. On Mon, Jun 18, 2018 at 11:55 AM, Steve French wrote: > On Mon, Jun 18,

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
Gustavo, Thx for pointing this out. Let me know if this patch addresses what you found. Code is experimental mount option but extremely important to get right due to move away from SMB1/CIFS which had posix extensions. On Mon, Jun 18, 2018 at 11:55 AM, Steve French wrote: > On Mon, Jun 18,

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
On Mon, Jun 18, 2018 at 8:07 AM, Gustavo A. R. Silva wrote: > Hi Steve, > > While doing some static analysis I came across the following piece of code at > fs/cifs/smb2pdu.c:2017: > > 2017if (n_iov > 2) { > 2018struct create_context *ccontext = > 2019

Re: [smb3] unreachable code and memory leaks

2018-06-18 Thread Steve French
On Mon, Jun 18, 2018 at 8:07 AM, Gustavo A. R. Silva wrote: > Hi Steve, > > While doing some static analysis I came across the following piece of code at > fs/cifs/smb2pdu.c:2017: > > 2017if (n_iov > 2) { > 2018struct create_context *ccontext = > 2019

[smb3] unreachable code and memory leaks

2018-06-18 Thread Gustavo A. R. Silva
Hi Steve, While doing some static analysis I came across the following piece of code at fs/cifs/smb2pdu.c:2017: 2017if (n_iov > 2) { 2018struct create_context *ccontext = 2019(struct create_context *)iov[n_iov-1].iov_base; 2020

[smb3] unreachable code and memory leaks

2018-06-18 Thread Gustavo A. R. Silva
Hi Steve, While doing some static analysis I came across the following piece of code at fs/cifs/smb2pdu.c:2017: 2017if (n_iov > 2) { 2018struct create_context *ccontext = 2019(struct create_context *)iov[n_iov-1].iov_base; 2020