The following commit has been merged into the irq/core branch of tip:

Commit-ID:     405698ca359a23b1ef1a502ef2bdc4597dc6da36
Gitweb:        
https://git.kernel.org/tip/405698ca359a23b1ef1a502ef2bdc4597dc6da36
Author:        Sebastian Andrzej Siewior <bige...@linutronix.de>
AuthorDate:    Tue, 09 Mar 2021 09:42:14 +01:00
Committer:     Thomas Gleixner <t...@linutronix.de>
CommitterDate: Wed, 17 Mar 2021 16:34:02 +01:00

atm: eni: Use tasklet_disable_in_atomic() in the send() callback

The atmdev_ops::send callback which calls tasklet_disable() is invoked with
bottom halfs disabled from net_device_ops::ndo_start_xmit(). All other
invocations of tasklet_disable() in this driver happen in preemptible
context.

Change the send() call to use tasklet_disable_in_atomic() which allows
tasklet_disable() to be made sleepable once the remaining atomic context
usage sites are cleaned up.

Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Link: https://lore.kernel.org/r/20210309084242.415583...@linutronix.de

---
 drivers/atm/eni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 316a994..e96a4e8 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -2054,7 +2054,7 @@ static int eni_send(struct atm_vcc *vcc,struct sk_buff 
*skb)
        }
        submitted++;
        ATM_SKB(skb)->vcc = vcc;
-       tasklet_disable(&ENI_DEV(vcc->dev)->task);
+       tasklet_disable_in_atomic(&ENI_DEV(vcc->dev)->task);
        res = do_tx(skb);
        tasklet_enable(&ENI_DEV(vcc->dev)->task);
        if (res == enq_ok) return 0;

Reply via email to