Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-25 Thread Martin Pärtel
> > Then my analysis is correct that you simply missed filtering out the > si codes that are not signal specific and do not use the fault layout > in struct siginfo. > ... > I would say that you really need a > white-list of si_codes that whose use of struct siginfo that you know. > Otherwise you

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-25 Thread Martin Pärtel
> > Then my analysis is correct that you simply missed filtering out the > si codes that are not signal specific and do not use the fault layout > in struct siginfo. > ... > I would say that you really need a > white-list of si_codes that whose use of struct siginfo that you know. > Otherwise you

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Eric W. Biederman
Martin Pärtel writes: > And once more in plain text.. > > On 25 April 2018 at 01:00, Martin Pärtel wrote: >> >> Hi all, >> >> This was ages ago, but from what I remember... >> >>> >>> Having a second look I really don't understand what

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Eric W. Biederman
Martin Pärtel writes: > And once more in plain text.. > > On 25 April 2018 at 01:00, Martin Pärtel wrote: >> >> Hi all, >> >> This was ages ago, but from what I remember... >> >>> >>> Having a second look I really don't understand what relay_signal is >>> trying to do. >>> >>> The function

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Martin Pärtel
And once more in plain text.. On 25 April 2018 at 01:00, Martin Pärtel wrote: > > Hi all, > > This was ages ago, but from what I remember... > >> >> Having a second look I really don't understand what relay_signal is >> trying to do. >> >> The function relay_signal does

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Martin Pärtel
And once more in plain text.. On 25 April 2018 at 01:00, Martin Pärtel wrote: > > Hi all, > > This was ages ago, but from what I remember... > >> >> Having a second look I really don't understand what relay_signal is >> trying to do. >> >> The function relay_signal does not pass siginfo through

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Eric W. Biederman
Sigh I should have Cc'd Martin Partel as well as this bit is his original code. Anton Ivanov writes: > Hi Richard, > > There was a post to uml-devel during the days when the sourceforge mailing > list > was working in random drop mode which claimed that "this

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Eric W. Biederman
Sigh I should have Cc'd Martin Partel as well as this bit is his original code. Anton Ivanov writes: > Hi Richard, > > There was a post to uml-devel during the days when the sourceforge mailing > list > was working in random drop mode which claimed that "this fixes the arm build". > > I have

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Anton Ivanov
Hi Richard, There was a post to uml-devel during the days when the sourceforge mailing list was working in random drop mode which claimed that "this fixes the arm build". I have not kept it locally and I do not see it the archive (I do not see a few other posts there either - including some

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Anton Ivanov
Hi Richard, There was a post to uml-devel during the days when the sourceforge mailing list was working in random drop mode which claimed that "this fixes the arm build". I have not kept it locally and I do not see it the archive (I do not see a few other posts there either - including some

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Richard Weinberger
On Fri, Apr 20, 2018 at 6:06 PM, Anton Ivanov wrote: > > On 04/20/18 15:38, Eric W. Biederman wrote: >> >> Today user mode linux only works on x86 and x86_64 and this allows >> simplifications of relay_signal. > > > I believe someone recently fixed the ARM port. I

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Richard Weinberger
On Fri, Apr 20, 2018 at 6:06 PM, Anton Ivanov wrote: > > On 04/20/18 15:38, Eric W. Biederman wrote: >> >> Today user mode linux only works on x86 and x86_64 and this allows >> simplifications of relay_signal. > > > I believe someone recently fixed the ARM port. I have not had the time to > try

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-20 Thread Anton Ivanov
On 04/20/18 15:38, Eric W. Biederman wrote: Today user mode linux only works on x86 and x86_64 and this allows simplifications of relay_signal. I believe someone recently fixed the ARM port. I have not had the time to try the fixes though. I have added the new list we are migrating to the

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-20 Thread Anton Ivanov
On 04/20/18 15:38, Eric W. Biederman wrote: Today user mode linux only works on x86 and x86_64 and this allows simplifications of relay_signal. I believe someone recently fixed the ARM port. I have not had the time to try the fixes though. I have added the new list we are migrating to the