Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Am Dienstag, 27. September 2016, 16:44:16 CEST schrieb Kalle Valo: Hi Kalle, > Stephan Mueller wrote: > > The ATH9K driver implements an RNG which is completely bypassing the > > standard Linux HW generator logic. > > > > The RNG may or may not deliver entropy. Considering

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Am Dienstag, 27. September 2016, 16:44:16 CEST schrieb Kalle Valo: Hi Kalle, > Stephan Mueller wrote: > > The ATH9K driver implements an RNG which is completely bypassing the > > standard Linux HW generator logic. > > > > The RNG may or may not deliver entropy. Considering the conservative > >

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources,

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources, this > patch changes

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

"Pan, Miaoqing" writes: > The entropy was evaluated by crypto expert, the analysis report show > the ADC with at least 10bits and up to 22 bits of min-entropy for a 32 > bits value, we conservatively assume the min-entropy is 10 bits out of > 32 bits, so that's why set

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

"Pan, Miaoqing" writes: > The entropy was evaluated by crypto expert, the analysis report show > the ADC with at least 10bits and up to 22 bits of min-entropy for a 32 > bits value, we conservatively assume the min-entropy is 10 bits out of > 32 bits, so that's why set entropy quality to

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quality of 0, > > rngd assumes

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quality of 0, > > rngd assumes

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > disasterous because despite most drivers having a default quality of 0, > rngd assumes 1 bit of entropy for every bit read? Sorry, what I was trying to say (but

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > disasterous because despite most drivers having a default quality of 0, > rngd assumes 1 bit of entropy for every bit read? Sorry, what I was trying to say (but

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > Agree with Jason's point, also understand Stephan's concern. The > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > 1000', the average speed is .294Kibits/s. I will sent the patch > to disable ath9k RNG by

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > Agree with Jason's point, also understand Stephan's concern. The > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > 1000', the average speed is .294Kibits/s. I will sent the patch > to disable ath9k RNG by

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

na.org.au; linux-kernel@vger.kernel.org; linux-cry...@vger.kernel.org; ath9k-devel <ath9k-de...@qca.qualcomm.com>; linux-wirel...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo <kv...@codeaurora.org> Subject: Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Hi

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo Subject: Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > Th

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > > Well, I don't buy

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > > Well, I don't buy

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

rg; > linux-cry...@vger.kernel.org; ath9k-devel <ath9k-de...@qca.qualcomm.com>; > linux-wirel...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo > <kv...@codeaurora.org>; Jason Cooper <ja...@lakedaemon.net> Subject: [PATCH > v2] RANDOM: ATH9K RNG delivers zer

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

ux-cry...@vger.kernel.org; ath9k-devel ; > linux-wirel...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo > ; Jason Cooper Subject: [PATCH > v2] RANDOM: ATH9K RNG delivers zero bits of entropy > > The ATH9K driver implements an RNG which is completely bypassing the > standa

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

>; Jason Cooper <ja...@lakedaemon.net> Subject: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy The ATH9K driver implements an RNG which is completely bypassing the standard Linux HW generator logic. The RNG may or may not deliver entropy. Considering the conservative appro

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

, August 07, 2016 5:36 PM To: Ted Tso Cc: herb...@gondor.apana.org.au; linux-kernel@vger.kernel.org; linux-cry...@vger.kernel.org; ath9k-devel ; linux-wirel...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo ; Jason Cooper Subject: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits

[PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

The ATH9K driver implements an RNG which is completely bypassing the standard Linux HW generator logic. The RNG may or may not deliver entropy. Considering the conservative approach in treating entropy with respect to non-auditable sources, this patch changes the delivered entropy value to zero.

[PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

The ATH9K driver implements an RNG which is completely bypassing the standard Linux HW generator logic. The RNG may or may not deliver entropy. Considering the conservative approach in treating entropy with respect to non-auditable sources, this patch changes the delivered entropy value to zero.