Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-08 Thread Fengguang Wu
Hi Joe, On Sun, Jul 07, 2013 at 09:54:27PM -0700, Joe Perches wrote: > On Mon, 2013-07-08 at 12:45 +0800, Fengguang Wu wrote: > > On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: > > > On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: > > > > In long run I'd like to disable > > >

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-08 Thread Fengguang Wu
Hi Joe, On Sun, Jul 07, 2013 at 09:54:27PM -0700, Joe Perches wrote: On Mon, 2013-07-08 at 12:45 +0800, Fengguang Wu wrote: On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: In long run I'd like to disable the check

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
On Mon, Jul 08, 2013 at 12:47:47PM +0800, Fengguang Wu wrote: > > > > TRAILING_STATEMENTS > > > > > > False positives? Got an example? > > > > tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next > > head: d2989b534ef6834ebf2425aecc040b894b567c91 > > commit:

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Joe Perches
On Mon, 2013-07-08 at 12:45 +0800, Fengguang Wu wrote: > On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: > > On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: > > > In long run I'd like to disable > > > the check types that tend to have false positives. As for now, these > > >

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
> > > TRAILING_STATEMENTS > > > > False positives? Got an example? > > tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next > head: d2989b534ef6834ebf2425aecc040b894b567c91 > commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy > engine context

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: > On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: > > In long run I'd like to disable > > the check types that tend to have false positives. As for now, these > > checks are disabled in my checkpatch robot: > > Are you using a

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Joe Perches
On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: > In long run I'd like to disable > the check types that tend to have false positives. As for now, these > checks are disabled in my checkpatch robot: Are you using a .checkpatch.conf file? > PATCH_PREFIX > LONG_LINE > CAMELCASE That's a

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
Hi Eric, On Sun, Jul 07, 2013 at 10:14:09PM -0500, Eric Van Hensbergen wrote: > I've fixed this in my for-next branch, Linus rejected my pull on other > grounds so this should let us fix up these style issues before the merge. > Thanks for catching this, I need to go back to running >

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
Hi Eric, On Sun, Jul 07, 2013 at 10:14:09PM -0500, Eric Van Hensbergen wrote: I've fixed this in my for-next branch, Linus rejected my pull on other grounds so this should let us fix up these style issues before the merge. Thanks for catching this, I need to go back to running

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Joe Perches
On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: In long run I'd like to disable the check types that tend to have false positives. As for now, these checks are disabled in my checkpatch robot: Are you using a .checkpatch.conf file? PATCH_PREFIX LONG_LINE CAMELCASE That's a

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: In long run I'd like to disable the check types that tend to have false positives. As for now, these checks are disabled in my checkpatch robot: Are you using a

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
TRAILING_STATEMENTS False positives? Got an example? tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next head: d2989b534ef6834ebf2425aecc040b894b567c91 commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc,

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Joe Perches
On Mon, 2013-07-08 at 12:45 +0800, Fengguang Wu wrote: On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote: On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote: In long run I'd like to disable the check types that tend to have false positives. As for now, these checks are

Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

2013-07-07 Thread Fengguang Wu
On Mon, Jul 08, 2013 at 12:47:47PM +0800, Fengguang Wu wrote: TRAILING_STATEMENTS False positives? Got an example? tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next head: d2989b534ef6834ebf2425aecc040b894b567c91 commit: