Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Alan Stern
On Mon, 1 Jan 2018, Paul Menzel wrote: > > So they are OHCI controllers. You could add some debugging statements > > to quirk_usb_handoff_ohci() to try and locate the part that's taking so > > long. > > As you suggested debugging statements, I guess the Linux kernel doesn’t > offer other ways

Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Alan Stern
On Mon, 1 Jan 2018, Paul Menzel wrote: > > So they are OHCI controllers. You could add some debugging statements > > to quirk_usb_handoff_ohci() to try and locate the part that's taking so > > long. > > As you suggested debugging statements, I guess the Linux kernel doesn’t > offer other ways

Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Paul Menzel
Dear Alan, First, please note, that your mailer (MUA) doesn’t set the references header, which breaks threading for people not having their own answers in the inbox. Am 31.12.2017 um 22:16 schrieb Alan Stern: On Sun, 31 Dec 2017, Paul Menzel wrote: Am 29.12.2017 um 17:14 schrieb Alan

Re: `pci_apply_final_quirks()` taking half a second

2018-01-01 Thread Paul Menzel
Dear Alan, First, please note, that your mailer (MUA) doesn’t set the references header, which breaks threading for people not having their own answers in the inbox. Am 31.12.2017 um 22:16 schrieb Alan Stern: On Sun, 31 Dec 2017, Paul Menzel wrote: Am 29.12.2017 um 17:14 schrieb Alan

Re: `pci_apply_final_quirks()` taking half a second

2017-12-31 Thread Alan Stern
On Sun, 31 Dec 2017, Paul Menzel wrote: > Am 29.12.2017 um 17:14 schrieb Alan Stern: > > On Thu, 28 Dec 2017, Bjorn Helgaas wrote: > > > >> On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > >>> Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > On Fri, Apr 07, 2017 at 11:07:15PM

Re: `pci_apply_final_quirks()` taking half a second

2017-12-31 Thread Alan Stern
On Sun, 31 Dec 2017, Paul Menzel wrote: > Am 29.12.2017 um 17:14 schrieb Alan Stern: > > On Thu, 28 Dec 2017, Bjorn Helgaas wrote: > > > >> On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > >>> Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > On Fri, Apr 07, 2017 at 11:07:15PM

Re: `pci_apply_final_quirks()` taking half a second

2017-12-30 Thread Paul Menzel
Am 29.12.2017 um 17:14 schrieb Alan Stern: On Thu, 28 Dec 2017, Bjorn Helgaas wrote: On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: Measuring where time is spent

Re: `pci_apply_final_quirks()` taking half a second

2017-12-30 Thread Paul Menzel
Am 29.12.2017 um 17:14 schrieb Alan Stern: On Thu, 28 Dec 2017, Bjorn Helgaas wrote: On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: Measuring where time is spent

Re: `pci_apply_final_quirks()` taking half a second

2017-12-29 Thread Alan Stern
On Thu, 28 Dec 2017, Bjorn Helgaas wrote: > On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > > > > >>Measuring where time is spent during boot with

Re: `pci_apply_final_quirks()` taking half a second

2017-12-29 Thread Alan Stern
On Thu, 28 Dec 2017, Bjorn Helgaas wrote: > On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > > > > >>Measuring where time is spent during boot with

Re: `pci_apply_final_quirks()` taking half a second

2017-12-28 Thread Bjorn Helgaas
On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > > >>Measuring where time is spent during boot with `systemd-bootchart` > >>on an Asus A780FullHD, it turns out that half a

Re: `pci_apply_final_quirks()` taking half a second

2017-12-28 Thread Bjorn Helgaas
On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > > >>Measuring where time is spent during boot with `systemd-bootchart` > >>on an Asus A780FullHD, it turns out that half a

Re: `pci_apply_final_quirks()` taking half a second

2017-12-26 Thread Paul Menzel
Dear Bjorn, Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: Measuring where time is spent during boot with `systemd-bootchart` on an Asus A780FullHD, it turns out that half a second is spent in `pci_apply_final_quirks()`. I agree,

Re: `pci_apply_final_quirks()` taking half a second

2017-12-26 Thread Paul Menzel
Dear Bjorn, Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: Measuring where time is spent during boot with `systemd-bootchart` on an Asus A780FullHD, it turns out that half a second is spent in `pci_apply_final_quirks()`. I agree,

Re: `pci_apply_final_quirks()` taking half a second

2017-05-03 Thread Andy Shevchenko
On Sat, Apr 8, 2017 at 10:06 PM, Bjorn Helgaas wrote: > On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote: >> ... >> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each >> device in pci_apply_final_quirks(). How long does that take? > > I

Re: `pci_apply_final_quirks()` taking half a second

2017-05-03 Thread Andy Shevchenko
On Sat, Apr 8, 2017 at 10:06 PM, Bjorn Helgaas wrote: > On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote: >> ... >> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each >> device in pci_apply_final_quirks(). How long does that take? > > I don't know, but it's

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas
On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote: > ... > I note it's also reading PCI_CACHE_LINE_SIZE From config space for each > device in pci_apply_final_quirks(). How long does that take? I don't know, but it's pointless on modern PCIe systems where the Cache Line Size has no

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas
On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote: > ... > I note it's also reading PCI_CACHE_LINE_SIZE From config space for each > device in pci_apply_final_quirks(). How long does that take? I don't know, but it's pointless on modern PCIe systems where the Cache Line Size has no

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread David Woodhouse
On Sat, 2017-04-08 at 10:41 -0500, Bjorn Helgaas wrote: > > > Measuring where time is spent during boot with `systemd-bootchart` > > on an Asus A780FullHD, it turns out that half a second is spent in > > `pci_apply_final_quirks()`. > > I agree, that seems like a crazy amount of time. > > Can

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread David Woodhouse
On Sat, 2017-04-08 at 10:41 -0500, Bjorn Helgaas wrote: > > > Measuring where time is spent during boot with `systemd-bootchart` > > on an Asus A780FullHD, it turns out that half a second is spent in > > `pci_apply_final_quirks()`. > > I agree, that seems like a crazy amount of time. > > Can

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas
On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > Dear Linux folks, > > > Measuring where time is spent during boot with `systemd-bootchart` > on an Asus A780FullHD, it turns out that half a second is spent in > `pci_apply_final_quirks()`. I agree, that seems like a crazy amount of

Re: `pci_apply_final_quirks()` taking half a second

2017-04-08 Thread Bjorn Helgaas
On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > Dear Linux folks, > > > Measuring where time is spent during boot with `systemd-bootchart` > on an Asus A780FullHD, it turns out that half a second is spent in > `pci_apply_final_quirks()`. I agree, that seems like a crazy amount of

`pci_apply_final_quirks()` taking half a second

2017-04-07 Thread Paul Menzel
Dear Linux folks, Measuring where time is spent during boot with `systemd-bootchart` on an Asus A780FullHD, it turns out that half a second is spent in `pci_apply_final_quirks()`. Here are the times copied from the SVG: init_ladder 0.012s init_menu 0.012s pm_sysrq_init 0.012s

`pci_apply_final_quirks()` taking half a second

2017-04-07 Thread Paul Menzel
Dear Linux folks, Measuring where time is spent during boot with `systemd-bootchart` on an Asus A780FullHD, it turns out that half a second is spent in `pci_apply_final_quirks()`. Here are the times copied from the SVG: init_ladder 0.012s init_menu 0.012s pm_sysrq_init 0.012s