Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen

On Thu, Jan 11, 2001 at 01:06:32PM +0100, Rasmus Andersen wrote:
> On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote:
> > Yes we know about this one. This is a bug that was killed, and then came
> > back to life. We're still trying to figure out how... :)
> > 
> I feel that I must step up and claim responsibility here: The patch is
> mine and I apparently messed it up. I will get back with a better one
> this evening.

Hi again.

The attached patch is against ac6 and hopefully fixes the problems
reported (I personally inspected it to make sure that the rcpci45_pci_table
stuff was correct). An updated patch against 240p2 can be found at
www.jaquet.dk/kernel/patches/rcpci.patch.gz



On closer look this patch (against ac6) might be a bit to large to 
post to linux-kernel. I will make it available at 
www.jaquet.dk/kernel/patches/rcpci.patch.ac6.gz instead.

-- 
Regards,
Rasmus([EMAIL PROTECTED])

If we do not succeed, then we run the risk of failure.
-- Vice President Dan Quayle, to the Phoenix Republican
   Forum, March 1990
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen

On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote:
> Yes we know about this one. This is a bug that was killed, and then came
> back to life. We're still trying to figure out how... :)
> 
I feel that I must step up and claim responsibility here: The patch is
mine and I apparently messed it up. I will get back with a better one
this evening.

Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Hans Grobler

On Thu, 11 Jan 2001, Karsten Hopp (Red Hat) wrote:
> --- ./drivers/net/rcpci45.c.origThu Jan 11 12:49:19 2001
> +++ ./drivers/net/rcpci45.c Thu Jan 11 12:47:04 2001
> @@ -120,7 +120,7 @@
> { RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
> PCI_ANY_ID, },
> { }
>  };
> -MODULE_DEVICE_TABLE(pci, rcpci_pci_table);
> +MODULE_DEVICE_TABLE(pci, rcpci45_pci_table);
>
>  static void __exit rcpci45_remove_one(struct pci_dev *pdev)
>  {

Yes we know about this one. This is a bug that was killed, and then came
back to life. We're still trying to figure out how... :)

-- Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Karsten Hopp (Red Hat)

--- ./drivers/net/rcpci45.c.origThu Jan 11 12:49:19 2001
+++ ./drivers/net/rcpci45.c Thu Jan 11 12:47:04 2001
@@ -120,7 +120,7 @@
{ RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
PCI_ANY_ID, },
{ }
 };
-MODULE_DEVICE_TABLE(pci, rcpci_pci_table);
+MODULE_DEVICE_TABLE(pci, rcpci45_pci_table);
 
 static void __exit rcpci45_remove_one(struct pci_dev *pdev)
 {



--
 Karsten Hopp| [EMAIL PROTECTED]
 SAP-AG LinuxLab | http://www.sap.com/linux/
 Neurottstrasse 16
 69190 Walldorf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Karsten Hopp (Red Hat)

--- ./drivers/net/rcpci45.c.origThu Jan 11 12:49:19 2001
+++ ./drivers/net/rcpci45.c Thu Jan 11 12:47:04 2001
@@ -120,7 +120,7 @@
{ RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
PCI_ANY_ID, },
{ }
 };
-MODULE_DEVICE_TABLE(pci, rcpci_pci_table);
+MODULE_DEVICE_TABLE(pci, rcpci45_pci_table);
 
 static void __exit rcpci45_remove_one(struct pci_dev *pdev)
 {



--
 Karsten Hopp| [EMAIL PROTECTED]
 SAP-AG LinuxLab | http://www.sap.com/linux/
 Neurottstrasse 16
 69190 Walldorf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Hans Grobler

On Thu, 11 Jan 2001, Karsten Hopp (Red Hat) wrote:
 --- ./drivers/net/rcpci45.c.origThu Jan 11 12:49:19 2001
 +++ ./drivers/net/rcpci45.c Thu Jan 11 12:47:04 2001
 @@ -120,7 +120,7 @@
 { RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
 PCI_ANY_ID, },
 { }
  };
 -MODULE_DEVICE_TABLE(pci, rcpci_pci_table);
 +MODULE_DEVICE_TABLE(pci, rcpci45_pci_table);

  static void __exit rcpci45_remove_one(struct pci_dev *pdev)
  {

Yes we know about this one. This is a bug that was killed, and then came
back to life. We're still trying to figure out how... :)

-- Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen

On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote:
 Yes we know about this one. This is a bug that was killed, and then came
 back to life. We're still trying to figure out how... :)
 
I feel that I must step up and claim responsibility here: The patch is
mine and I apparently messed it up. I will get back with a better one
this evening.

Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen

On Thu, Jan 11, 2001 at 01:06:32PM +0100, Rasmus Andersen wrote:
 On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote:
  Yes we know about this one. This is a bug that was killed, and then came
  back to life. We're still trying to figure out how... :)
  
 I feel that I must step up and claim responsibility here: The patch is
 mine and I apparently messed it up. I will get back with a better one
 this evening.

Hi again.

The attached patch is against ac6 and hopefully fixes the problems
reported (I personally inspected it to make sure that the rcpci45_pci_table
stuff was correct). An updated patch against 240p2 can be found at
www.jaquet.dk/kernel/patches/rcpci.patch.gz

pause

On closer look this patch (against ac6) might be a bit to large to 
post to linux-kernel. I will make it available at 
www.jaquet.dk/kernel/patches/rcpci.patch.ac6.gz instead.

-- 
Regards,
Rasmus([EMAIL PROTECTED])

If we do not succeed, then we run the risk of failure.
-- Vice President Dan Quayle, to the Phoenix Republican
   Forum, March 1990
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/