Re: 2.6.19-mm1: gotemp: memset(..., 0) error

2006-12-14 Thread Greg KH
On Wed, Dec 13, 2006 at 02:05:59PM +0100, Adrian Bunk wrote: > <-- snip --> > > ... > NOT FOR MAINLINE! > > This is for the driver tutorial I give. It will not be included in the > mainline kernel tree ever. Use the ldusb driver that is already there > instead for this device. > > This is

Re: 2.6.19-mm1: gotemp: memset(..., 0) error

2006-12-14 Thread Greg KH
On Wed, Dec 13, 2006 at 02:05:59PM +0100, Adrian Bunk wrote: -- snip -- ... NOT FOR MAINLINE! This is for the driver tutorial I give. It will not be included in the mainline kernel tree ever. Use the ldusb driver that is already there instead for this device. This is only a

Re: 2.6.19-mm1: missing MTD_UBI* help texts

2006-12-13 Thread Artem Bityutskiy
On Mon, 2006-12-11 at 17:42 +0100, Adrian Bunk wrote: > The MTD_UBI and the MTD_UBI_DEBUG_PARANOID_* options lack help texts. thanks, fixed in our GIT tree. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

2.6.19-mm1: gotemp: memset(..., 0) error

2006-12-13 Thread Adrian Bunk
<-- snip --> ... NOT FOR MAINLINE! This is for the driver tutorial I give. It will not be included in the mainline kernel tree ever. Use the ldusb driver that is already there instead for this device. This is only a teaching tool. ... + pkt = kmalloc(sizeof(*pkt), GFP_ATOMIC); +

Re: 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-13 Thread Artem Bityutskiy
On Mon, 2006-12-11 at 21:46 +0100, Adrian Bunk wrote: > It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the > variable "caller" is never assigned any value different from 0. > thanks, fixed in our GIT tree. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem)

2006-12-13 Thread Rafael J. Wysocki
On Wednesday, 13 December 2006 01:53, Neil Brown wrote: > On Tuesday December 12, [EMAIL PROTECTED] wrote: > > > > > > So when md writes to write out the superblock, to gets EIO... Odd that > > > you aren't getting errors for normal writes. > > > > > > What devices are the md/raid1 built on? > >

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem)

2006-12-13 Thread Rafael J. Wysocki
On Wednesday, 13 December 2006 01:53, Neil Brown wrote: On Tuesday December 12, [EMAIL PROTECTED] wrote: So when md writes to write out the superblock, to gets EIO... Odd that you aren't getting errors for normal writes. What devices are the md/raid1 built on? Sata drives,

Re: 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-13 Thread Artem Bityutskiy
On Mon, 2006-12-11 at 21:46 +0100, Adrian Bunk wrote: It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the variable caller is never assigned any value different from 0. thanks, fixed in our GIT tree. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from

2.6.19-mm1: gotemp: memset(..., 0) error

2006-12-13 Thread Adrian Bunk
-- snip -- ... NOT FOR MAINLINE! This is for the driver tutorial I give. It will not be included in the mainline kernel tree ever. Use the ldusb driver that is already there instead for this device. This is only a teaching tool. ... + pkt = kmalloc(sizeof(*pkt), GFP_ATOMIC); +

Re: 2.6.19-mm1: missing MTD_UBI* help texts

2006-12-13 Thread Artem Bityutskiy
On Mon, 2006-12-11 at 17:42 +0100, Adrian Bunk wrote: The MTD_UBI and the MTD_UBI_DEBUG_PARANOID_* options lack help texts. thanks, fixed in our GIT tree. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: 2.6.19-mm1

2006-12-12 Thread Andrew Morton
On Wed, 13 Dec 2006 09:17:42 +0800 Conke Hu <[EMAIL PROTECTED]> wrote: > Thank you for applying ATI SB600 SATA patch! > But it seems the patch file name should be > "ati"-sb600-sata-quirk.patch, not "via"-sb600-sata-quirk.patch, type > error? :) That's the sort of thing which happens

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem)

2006-12-12 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: > > > > So when md writes to write out the superblock, to gets EIO... Odd that > > you aren't getting errors for normal writes. > > > > What devices are the md/raid1 built on? > > Sata drives, on sata_uli. > > > > > > > I'll try to reproduce it

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-12 Thread Rafael J. Wysocki
> On Monday, 11 December 2006 09:58, Andrew Morton wrote: > > > > > > > > > > Temporarily at > > > > > > > > > > http://userweb.kernel.org/~akpm/2.6.19-mm1/ > > > > > > > > > > Will appear later at &

Re: 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-12 Thread Josh Boyer
On 12/11/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: >... > Changes since 2.6.19-rc6-mm2: >... > git-ubi.patch >... > git trees. >... It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the variable "caller" is never

Re: 2.6.19-mm1

2006-12-12 Thread Andrew Morton
On Tue, 12 Dec 2006 15:43:54 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > On Mon, 11 Dec 2006 22:06:17 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > When I use ftp on 2.6.19-mm1, transfered file is always broken. > > > like this: > > >

Re: 2.6.19-mm1

2006-12-12 Thread Andrew Morton
On Tue, 12 Dec 2006 15:43:54 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Mon, 11 Dec 2006 22:06:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: When I use ftp on 2.6.19-mm1, transfered file is always broken. like this: == [EMAIL PROTECTED] ~]$ file ./linux-2.6.19.tar.bz2

Re: 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-12 Thread Josh Boyer
On 12/11/06, Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: ... Changes since 2.6.19-rc6-mm2: ... git-ubi.patch ... git trees. ... It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the variable caller is never assigned any

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-12 Thread Rafael J. Wysocki
: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ It caused all of the md RAID1s on my test box to drop one of their partitions

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem)

2006-12-12 Thread Neil Brown
On Tuesday December 12, [EMAIL PROTECTED] wrote: So when md writes to write out the superblock, to gets EIO... Odd that you aren't getting errors for normal writes. What devices are the md/raid1 built on? Sata drives, on sata_uli. I'll try to reproduce it tomorrow and

Re: 2.6.19-mm1

2006-12-12 Thread Andrew Morton
On Wed, 13 Dec 2006 09:17:42 +0800 Conke Hu [EMAIL PROTECTED] wrote: Thank you for applying ATI SB600 SATA patch! But it seems the patch file name should be ati-sb600-sata-quirk.patch, not via-sb600-sata-quirk.patch, type error? :) That's the sort of thing which happens when people

Re: 2.6.19-mm1

2006-12-11 Thread KAMEZAWA Hiroyuki
On Mon, 11 Dec 2006 22:06:17 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > When I use ftp on 2.6.19-mm1, transfered file is always broken. > > like this: > > == > > [EMAIL PROTECTED] ~]$ file ./linux-2.6.19.tar.bz2 (got on 2.6.19-mm1) > > ./linux-2.6.19.tar

Re: 2.6.19-mm1

2006-12-11 Thread Andrew Morton
On Tue, 12 Dec 2006 14:53:41 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > > On Mon, 11 Dec 2006 00:58:07 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > Temporarily at > > > > http://userweb.kernel.

Re: 2.6.19-mm1

2006-12-11 Thread KAMEZAWA Hiroyuki
On Mon, 11 Dec 2006 00:58:07 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.19-mm1/ > > Will appear later at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Neil Brown
> > > Temporarily at > > > > > > > > http://userweb.kernel.org/~akpm/2.6.19-mm1/ > > > > > > > > Will appear later at > > > > > > > > > > > > ftp://ftp.kernel.org/pub/linux/ker

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Rafael J. Wysocki
On Monday, 11 December 2006 23:52, Neil Brown wrote: > On Monday December 11, [EMAIL PROTECTED] wrote: > > Hi, > > > > On Monday, 11 December 2006 09:58, Andrew Morton wrote: > > > > > > Temporarily at > > > > > > http://userweb.ke

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Neil Brown
On Monday December 11, [EMAIL PROTECTED] wrote: > Hi, > > On Monday, 11 December 2006 09:58, Andrew Morton wrote: > > > > Temporarily at > > > > http://userweb.kernel.org/~akpm/2.6.19-mm1/ > > > > Will appear later at > > > >

Re: 2.6.19-mm1

2006-12-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 December 2006 09:58, Andrew Morton wrote: > > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.19-mm1/ > > Will appear later at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ It caused

2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: >... > Changes since 2.6.19-rc6-mm2: >... > git-ubi.patch >... > git trees. >... It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the variable "caller" is never assigned any value different from 0. cu Adrian --

2.6.19-mm1: missing MTD_UBI* help texts

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: >... > Changes since 2.6.19-rc6-mm2: >... > git-ubi.patch >... > git trees. >... The MTD_UBI and the MTD_UBI_DEBUG_PARANOID_* options lack help texts. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
On Tue, 12 Dec 2006, Nick Piggin wrote: > > >Do you have CONFIG_DEBUG_VM turned on? I think we miss clearning > > >BH_New in some places, thus causing an error path to zero the block > > >incorrectly if we hit an error that CONFIG_DEBUG_VM makes much more > > >likely. > > Yes, I have. Will

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
with 2.6.19-mm1 corrupted quite a lot of files on my fs. Sorry. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

2.6.19-mm1: i386: unused idle notifiers added

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: >... > Changes since 2.6.19-rc6-mm2: >... > +x86_64-mm-i386-add-idle-notifier.patch > > x86 tree update >... This patch adds code and EXPORT_SYMBOL's that bloat the kernel for everyone but are currently completely unused in the

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
d on? I think we miss clearning BH_New > in some places, thus causing an error path to zero the block incorrectly > if we hit an error that CONFIG_DEBUG_VM makes much more likely. Yes, I have. Will retry without it and let you know if the problem goes away. Seems quite dangerous, a few minute

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
Jiri Kosina wrote: On Mon, 11 Dec 2006, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Am I the only one seeing something strange on ext3 with this kernel? For example /etc/resolv.conf gets corrupted during the dhclient run. It looks like

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
On Mon, 11 Dec 2006, Andrew Morton wrote: > Temporarily at > http://userweb.kernel.org/~akpm/2.6.19-mm1/ Am I the only one seeing something strange on ext3 with this kernel? For example /etc/resolv.conf gets corrupted during the dhclient run. It looks like this, after dhclient fi

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ - There's some new runtime debugging in kmap_atomic(). It catches one buglet

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ - There's some new runtime debugging in kmap_atomic(). It catches one buglet

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
On Mon, 11 Dec 2006, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Am I the only one seeing something strange on ext3 with this kernel? For example /etc/resolv.conf gets corrupted during the dhclient run. It looks like this, after dhclient finishes

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
Jiri Kosina wrote: On Mon, 11 Dec 2006, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Am I the only one seeing something strange on ext3 with this kernel? For example /etc/resolv.conf gets corrupted during the dhclient run. It looks like

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
BH_New in some places, thus causing an error path to zero the block incorrectly if we hit an error that CONFIG_DEBUG_VM makes much more likely. Yes, I have. Will retry without it and let you know if the problem goes away. Seems quite dangerous, a few minutes with 2.6.19-mm1 corrupted quite

2.6.19-mm1: i386: unused idle notifiers added

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: ... Changes since 2.6.19-rc6-mm2: ... +x86_64-mm-i386-add-idle-notifier.patch x86 tree update ... This patch adds code and EXPORT_SYMBOL's that bloat the kernel for everyone but are currently completely unused in the kernel

Re: 2.6.19-mm1

2006-12-11 Thread Nick Piggin
with 2.6.19-mm1 corrupted quite a lot of files on my fs. Sorry. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.19-mm1

2006-12-11 Thread Jiri Kosina
On Tue, 12 Dec 2006, Nick Piggin wrote: Do you have CONFIG_DEBUG_VM turned on? I think we miss clearning BH_New in some places, thus causing an error path to zero the block incorrectly if we hit an error that CONFIG_DEBUG_VM makes much more likely. Yes, I have. Will retry without it

2.6.19-mm1: missing MTD_UBI* help texts

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: ... Changes since 2.6.19-rc6-mm2: ... git-ubi.patch ... git trees. ... The MTD_UBI and the MTD_UBI_DEBUG_PARANOID_* options lack help texts. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out

2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable

2006-12-11 Thread Adrian Bunk
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote: ... Changes since 2.6.19-rc6-mm2: ... git-ubi.patch ... git trees. ... It doesn't seem to be intended that in ubi_dbg_vprint_nolock() the variable caller is never assigned any value different from 0. cu Adrian -- Is

Re: 2.6.19-mm1

2006-12-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 December 2006 09:58, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ It caused all of the md RAID1s on my test box

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Neil Brown
On Monday December 11, [EMAIL PROTECTED] wrote: Hi, On Monday, 11 December 2006 09:58, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Rafael J. Wysocki
On Monday, 11 December 2006 23:52, Neil Brown wrote: On Monday December 11, [EMAIL PROTECTED] wrote: Hi, On Monday, 11 December 2006 09:58, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp

Re: 2.6.19-mm1 (md/raid1 randomly drops partitions)

2006-12-11 Thread Neil Brown
/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ It caused all of the md RAID1s on my test box to drop one of their partitions, apparently at random. That's clever Do you have

Re: 2.6.19-mm1

2006-12-11 Thread KAMEZAWA Hiroyuki
On Mon, 11 Dec 2006 00:58:07 -0800 Andrew Morton [EMAIL PROTECTED] wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/ When I use ftp on 2.6.19-mm1

Re: 2.6.19-mm1

2006-12-11 Thread Andrew Morton
On Tue, 12 Dec 2006 14:53:41 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Mon, 11 Dec 2006 00:58:07 -0800 Andrew Morton [EMAIL PROTECTED] wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.19-mm1/ Will appear later at ftp://ftp.kernel.org/pub

Re: 2.6.19-mm1

2006-12-11 Thread KAMEZAWA Hiroyuki
On Mon, 11 Dec 2006 22:06:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: When I use ftp on 2.6.19-mm1, transfered file is always broken. like this: == [EMAIL PROTECTED] ~]$ file ./linux-2.6.19.tar.bz2 (got on 2.6.19-mm1) ./linux-2.6.19.tar.bz2: data (I confirmed original file