Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-30 Thread Andi Kleen
Muli Ben-Yehuda <[EMAIL PROTECTED]> writes: > > The convention is to print a KERN_DEBUG message if hardware is not > found when probing it, otherwise the boot messages become cluttered > with lots of "$FOO not found". No the convention is to print no message at all when nothing is found Some

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-30 Thread Andi Kleen
Muli Ben-Yehuda [EMAIL PROTECTED] writes: The convention is to print a KERN_DEBUG message if hardware is not found when probing it, otherwise the boot messages become cluttered with lots of $FOO not found. No the convention is to print no message at all when nothing is found Some drivers

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Rafael J. Wysocki
On Friday, 29 June 2007 17:28, Keshavamurthy, Anil S wrote: > On Thu, Jun 28, 2007 at 06:14:27PM -0700, Li, Shaohua wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22- > > >rc6/2.6.22-rc6-mm1/ > > >> > > >>> +intel-iommu-dmar-detection-and-parsing-logic.patch

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Muli Ben-Yehuda
On Fri, Jun 29, 2007 at 12:23:53PM -0700, Keshavamurthy, Anil S wrote: > Since this is IOMMU is built into the kernel and it is good idea to > report that the device is not present. Yes - as a debug message. > The above is printed only once and is consistent with other IOMMU > implementation.

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Keshavamurthy, Anil S
On Fri, Jun 29, 2007 at 12:23:43PM -0400, Muli Ben-Yehuda wrote: > On Fri, Jun 29, 2007 at 08:28:58AM -0700, Keshavamurthy, Anil S wrote: > > > +++ linux-2.6.22-rc4-mm2/drivers/pci/dmar.c 2007-06-29 07:46:25.0 > > -0700 > > @@ -260,6 +260,8 @@ > > int ret = 0; > > > > dmar =

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Muli Ben-Yehuda
On Fri, Jun 29, 2007 at 08:28:58AM -0700, Keshavamurthy, Anil S wrote: > Here is the revised patch of the above. > Andrew, please add this fix to > +intel-iommu-dmar-detection-and-parsing-logic.patch > > > Check for dmar_tbl pointer as this can be

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Keshavamurthy, Anil S
On Thu, Jun 28, 2007 at 06:14:27PM -0700, Li, Shaohua wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22- > >rc6/2.6.22-rc6-mm1/ > >> > >>> +intel-iommu-dmar-detection-and-parsing-logic.patch [..] > > > >I took a picture of it, looks like the backtrace is: > > >

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Keshavamurthy, Anil S
On Thu, Jun 28, 2007 at 06:14:27PM -0700, Li, Shaohua wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22- rc6/2.6.22-rc6-mm1/ +intel-iommu-dmar-detection-and-parsing-logic.patch [..] I took a picture of it, looks like the backtrace is: NULL pointer

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Muli Ben-Yehuda
On Fri, Jun 29, 2007 at 08:28:58AM -0700, Keshavamurthy, Anil S wrote: Here is the revised patch of the above. Andrew, please add this fix to +intel-iommu-dmar-detection-and-parsing-logic.patch Check for dmar_tbl pointer as this can be NULL

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Keshavamurthy, Anil S
On Fri, Jun 29, 2007 at 12:23:43PM -0400, Muli Ben-Yehuda wrote: On Fri, Jun 29, 2007 at 08:28:58AM -0700, Keshavamurthy, Anil S wrote: +++ linux-2.6.22-rc4-mm2/drivers/pci/dmar.c 2007-06-29 07:46:25.0 -0700 @@ -260,6 +260,8 @@ int ret = 0; dmar = (struct

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Muli Ben-Yehuda
On Fri, Jun 29, 2007 at 12:23:53PM -0700, Keshavamurthy, Anil S wrote: Since this is IOMMU is built into the kernel and it is good idea to report that the device is not present. Yes - as a debug message. The above is printed only once and is consistent with other IOMMU implementation.

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-29 Thread Rafael J. Wysocki
On Friday, 29 June 2007 17:28, Keshavamurthy, Anil S wrote: On Thu, Jun 28, 2007 at 06:14:27PM -0700, Li, Shaohua wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22- rc6/2.6.22-rc6-mm1/ +intel-iommu-dmar-detection-and-parsing-logic.patch [..] I took

RE: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Li, Shaohua
>-Original Message- >From: Robert Hancock [mailto:[EMAIL PROTECTED] >Sent: Friday, June 29, 2007 8:59 AM >To: Zan Lynx >Cc: Andrew Morton; linux-kernel@vger.kernel.org; Raj, Ashok; Li, Shaohua; >Keshavamurthy, Anil S >Subject: Re: 2.6.22-rc6-mm1 Intel DMAR crash on A

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Robert Hancock
Zan Lynx wrote: On Thu, 2007-06-28 at 03:43 -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ +intel-iommu-dmar-detection-and-parsing-logic.patch +intel-iommu-pci-generic-helper-function.patch

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Zach Carter
On Thursday 28 June 2007 01:40:32 pm you wrote: > I'll provide more details on request, and when I get the chance. This > is a heads-up on the BUG in case someone has an "ah ha!" moment. I believe I have also reproduced this bug. I have an ABIT K9 Ultra motherboard with NFORCE hardware. My

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Zan Lynx
On Thu, 2007-06-28 at 03:43 -0700, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ > +intel-iommu-dmar-detection-and-parsing-logic.patch > +intel-iommu-pci-generic-helper-function.patch >

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Zan Lynx
On Thu, 2007-06-28 at 03:43 -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ +intel-iommu-dmar-detection-and-parsing-logic.patch +intel-iommu-pci-generic-helper-function.patch

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Zach Carter
On Thursday 28 June 2007 01:40:32 pm you wrote: I'll provide more details on request, and when I get the chance. This is a heads-up on the BUG in case someone has an ah ha! moment. I believe I have also reproduced this bug. I have an ABIT K9 Ultra motherboard with NFORCE hardware. My

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Robert Hancock
Zan Lynx wrote: On Thu, 2007-06-28 at 03:43 -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ +intel-iommu-dmar-detection-and-parsing-logic.patch +intel-iommu-pci-generic-helper-function.patch

RE: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64

2007-06-28 Thread Li, Shaohua
-Original Message- From: Robert Hancock [mailto:[EMAIL PROTECTED] Sent: Friday, June 29, 2007 8:59 AM To: Zan Lynx Cc: Andrew Morton; linux-kernel@vger.kernel.org; Raj, Ashok; Li, Shaohua; Keshavamurthy, Anil S Subject: Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64 Zan Lynx wrote