Re: 2.6.24-rc2 XFS nfsd hang

2007-11-21 Thread J. Bruce Fields
On Wed, Nov 21, 2007 at 03:07:46PM +, Christoph Hellwig wrote: > On Wed, Nov 14, 2007 at 01:08:38PM -0500, J. Bruce Fields wrote: > > > Personally I'd prefer it to only grow a struct stat or rather it's members > > > But the nfsd code currently expects a dentry so this might require some > > >

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 01:08:38PM -0500, J. Bruce Fields wrote: > > Personally I'd prefer it to only grow a struct stat or rather it's members > > But the nfsd code currently expects a dentry so this might require some > > major refactoring. > > Well, we need to check for mountpoints, for

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 01:08:38PM -0500, J. Bruce Fields wrote: Personally I'd prefer it to only grow a struct stat or rather it's members But the nfsd code currently expects a dentry so this might require some major refactoring. Well, we need to check for mountpoints, for example, so I

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-21 Thread J. Bruce Fields
On Wed, Nov 21, 2007 at 03:07:46PM +, Christoph Hellwig wrote: On Wed, Nov 14, 2007 at 01:08:38PM -0500, J. Bruce Fields wrote: Personally I'd prefer it to only grow a struct stat or rather it's members But the nfsd code currently expects a dentry so this might require some major

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Christian Kujau
On Sun, 18 Nov 2007, Justin Piszcz wrote: I wonder why so few people are seeing this, I'd have assumed that NFSv3 && XFS is not sooo exotic... Still on 2.6.23.x here (also use nfsv3 + xfs). So, it's the "too few people are testing -rc kernels" issue again :( Christian. -- BOFH excuse #118:

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Justin Piszcz
On Sun, 18 Nov 2007, Christian Kujau wrote: On Fri, 16 Nov 2007, Chris Wedgwood wrote: Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. I've opened

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Christian Kujau
On Fri, 16 Nov 2007, Chris Wedgwood wrote: Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. I've opened http://bugzilla.kernel.org/show_bug.cgi?id=9400 to track this one (and to not forget

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Christian Kujau
On Fri, 16 Nov 2007, Chris Wedgwood wrote: Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. I've opened http://bugzilla.kernel.org/show_bug.cgi?id=9400 to track this one (and to not forget

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Justin Piszcz
On Sun, 18 Nov 2007, Christian Kujau wrote: On Fri, 16 Nov 2007, Chris Wedgwood wrote: Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. I've opened

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-18 Thread Christian Kujau
On Sun, 18 Nov 2007, Justin Piszcz wrote: I wonder why so few people are seeing this, I'd have assumed that NFSv3 XFS is not sooo exotic... Still on 2.6.23.x here (also use nfsv3 + xfs). So, it's the too few people are testing -rc kernels issue again :( Christian. -- BOFH excuse #118: the

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Chris Wedgwood
On Fri, Nov 16, 2007 at 09:19:32AM -0500, Trond Myklebust wrote: > Very funny, but disabling XFS on the client won't help. Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. - To unsubscribe from

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Trond Myklebust
On Fri, 2007-11-16 at 03:03 -0800, Chris Wedgwood wrote: > On Fri, Nov 16, 2007 at 10:17:17AM +0100, Christian Kujau wrote: > > > OK, I'll try this. I hope this can be fixed somehow before 2.6.24... > > Well, one simple nasty idea would be something like: > > diff --git a/fs/Kconfig

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Chris Wedgwood
On Fri, Nov 16, 2007 at 10:17:17AM +0100, Christian Kujau wrote: > OK, I'll try this. I hope this can be fixed somehow before 2.6.24... Well, one simple nasty idea would be something like: diff --git a/fs/Kconfig b/fs/Kconfig index 429a002..da231fd 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Christian Kujau
On Fri, November 16, 2007 01:34, Chris Wedgwood wrote: > I'm not sure what you're doing here, but a viable work-around for now > might be to use nfsv2 mounts, something like > > mount -o vers=2 ... > or to keep v3 and disable readdirplus doing something like: > mount -o vers=3,nordirplus ... OK,

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Christian Kujau
On Fri, November 16, 2007 01:34, Chris Wedgwood wrote: I'm not sure what you're doing here, but a viable work-around for now might be to use nfsv2 mounts, something like mount -o vers=2 ... or to keep v3 and disable readdirplus doing something like: mount -o vers=3,nordirplus ... OK, I'll

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Chris Wedgwood
On Fri, Nov 16, 2007 at 10:17:17AM +0100, Christian Kujau wrote: OK, I'll try this. I hope this can be fixed somehow before 2.6.24... Well, one simple nasty idea would be something like: diff --git a/fs/Kconfig b/fs/Kconfig index 429a002..da231fd 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Trond Myklebust
On Fri, 2007-11-16 at 03:03 -0800, Chris Wedgwood wrote: On Fri, Nov 16, 2007 at 10:17:17AM +0100, Christian Kujau wrote: OK, I'll try this. I hope this can be fixed somehow before 2.6.24... Well, one simple nasty idea would be something like: diff --git a/fs/Kconfig b/fs/Kconfig

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-16 Thread Chris Wedgwood
On Fri, Nov 16, 2007 at 09:19:32AM -0500, Trond Myklebust wrote: Very funny, but disabling XFS on the client won't help. Oops, I meant it for NFSD... and I'm somewhat serious. I'm not saying it's a good long term solution, but a potentially safer short-term workaround. - To unsubscribe from

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Chris Wedgwood
On Thu, Nov 15, 2007 at 08:51:36AM +0100, Christian Kujau wrote: > [] mutex_lock_nested+0xcc/0x2c0 > [] do_lookup+0xa4/0x190 > [] __link_path_walk+0x749/0xd10 > [] link_path_walk+0x44/0xc0 > [] path_walk+0x18/0x20 > [] do_path_lookup+0x78/0x1c0 > [] __user_walk_fd+0x38/0x60 > []

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Thu, 15 Nov 2007, Christian Kujau wrote: Upon accessing the /data/sub part of the CIFS share, the client hung, waiting for the server to respond (the [cifs] kernel thread on the client was spinning, waiting for i/o). On the server, similar things as with the nfsd processes happened Turns

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Thu, November 15, 2007 08:51, Christian Kujau wrote: > Since NFS was not working (the nfsd processes were already in D state), > to mount a CIFS share from the very same server (and the same client). That should read: Since NFS was not working (the nfsd processes were already in D state), I

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Wed, 14 Nov 2007, Christian Kujau wrote: Yes, the nfsd process only got stuck when I did ls(1) (with or without -l) on a NFS share which contained a XFS partition. Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Wed, 14 Nov 2007, Christian Kujau wrote: Yes, the nfsd process only got stuck when I did ls(1) (with or without -l) on a NFS share which contained a XFS partition. Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Thu, November 15, 2007 08:51, Christian Kujau wrote: Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and the same client). That should read: Since NFS was not working (the nfsd processes were already in D state), I

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Thu, 15 Nov 2007, Christian Kujau wrote: Upon accessing the /data/sub part of the CIFS share, the client hung, waiting for the server to respond (the [cifs] kernel thread on the client was spinning, waiting for i/o). On the server, similar things as with the nfsd processes happened Turns

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Chris Wedgwood
On Thu, Nov 15, 2007 at 08:51:36AM +0100, Christian Kujau wrote: [c040914c] mutex_lock_nested+0xcc/0x2c0 [c016dc64] do_lookup+0xa4/0x190 [c016f6f9] __link_path_walk+0x749/0xd10 [c016fd04] link_path_walk+0x44/0xc0 [c016fd98] path_walk+0x18/0x20 [c016ff98] do_path_lookup+0x78/0x1c0

Re: 2.6.24-rc2 XFS nfsd hang --- filldir change responsible?

2007-11-14 Thread Christian Kujau
On Wed, 14 Nov 2007, Chris Wedgwood wrote: After some bisection pain (sg broken in the middle and XFS not compiling in other places) the regression seems to be: commit 051e7cd44ab8f0f7c2958371485b4a1ff64a8d1b Author: Christoph Hellwig <[EMAIL PROTECTED]> Date: Tue Aug 28 13:58:24

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christian Kujau
On Wed, 14 Nov 2007, J. Bruce Fields wrote: On Wed, Nov 14, 2007 at 09:43:40AM +0200, Benny Halevy wrote: I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Ah, thanks for noticing that. Christian Kujau, is /data an xfs partition?

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 06:02:41PM +, Christoph Hellwig wrote: > On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote: > > On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: > > > On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: > > > > This must have

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote: > On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: > > On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: > > > This must have come up before; feel free to remind me: is there any way > > > to make the

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: > On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: > > This must have come up before; feel free to remind me: is there any way > > to make the interface easier to use? (E.g. would it help if the filldir > >

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: > This must have come up before; feel free to remind me: is there any way > to make the interface easier to use? (E.g. would it help if the filldir > callback could be passed a dentry?) The best thing for the filesystem would be to

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 03:29:52PM +, Christoph Hellwig wrote: > On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: > > With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) > > see a hang when accessing some NFS exported XFS filesystems. Local > > access to these

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: > With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) > see a hang when accessing some NFS exported XFS filesystems. Local > access to these filesystems ahead of time works without problems. > > This does not occur

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 09:43:40AM +0200, Benny Halevy wrote: > I wonder if this is a similar hang to what Christian was seeing here: > http://lkml.org/lkml/2007/11/13/319 Ah, thanks for noticing that. Christian Kujau, is /data an xfs partition? There are a bunch of xfs commits in

2.6.24-rc2 XFS nfsd hang --- filldir change responsible?

2007-11-14 Thread Chris Wedgwood
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: > With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) > see a hang when accessing some NFS exported XFS filesystems. Local > access to these filesystems ahead of time works without problems. > > This does not occur

2.6.24-rc2 XFS nfsd hang --- filldir change responsible?

2007-11-14 Thread Chris Wedgwood
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these filesystems ahead of time works without problems. This does not occur with

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 09:43:40AM +0200, Benny Halevy wrote: I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Ah, thanks for noticing that. Christian Kujau, is /data an xfs partition? There are a bunch of xfs commits in

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these filesystems ahead of time works without problems. This does not occur with

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 03:29:52PM +, Christoph Hellwig wrote: On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: This must have come up before; feel free to remind me: is there any way to make the interface easier to use? (E.g. would it help if the filldir callback could be passed a dentry?) The best thing for the filesystem would be to

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote: On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: This must have come up before; feel free to remind me: is there any way to make the

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: This must have come up before; feel free to remind me: is there any way to make the interface easier to use? (E.g. would it help if the filldir callback could

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 06:02:41PM +, Christoph Hellwig wrote: On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote: On Wed, Nov 14, 2007 at 05:44:19PM +, Christoph Hellwig wrote: On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: This must have come up

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread Christian Kujau
On Wed, 14 Nov 2007, J. Bruce Fields wrote: On Wed, Nov 14, 2007 at 09:43:40AM +0200, Benny Halevy wrote: I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Ah, thanks for noticing that. Christian Kujau, is /data an xfs partition?

Re: 2.6.24-rc2 XFS nfsd hang --- filldir change responsible?

2007-11-14 Thread Christian Kujau
On Wed, 14 Nov 2007, Chris Wedgwood wrote: After some bisection pain (sg broken in the middle and XFS not compiling in other places) the regression seems to be: commit 051e7cd44ab8f0f7c2958371485b4a1ff64a8d1b Author: Christoph Hellwig [EMAIL PROTECTED] Date: Tue Aug 28 13:58:24 2007

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Benny Halevy
I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Benny On Nov. 14, 2007, 9:04 +0200, Chris Wedgwood <[EMAIL PROTECTED]> wrote: > With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) > see a hang when accessing some NFS

2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Chris Wedgwood
With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these filesystems ahead of time works without problems. This does not occur with 2.6.23.1. The filesystem does not appear to be corrupt. The call

2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Chris Wedgwood
With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these filesystems ahead of time works without problems. This does not occur with 2.6.23.1. The filesystem does not appear to be corrupt. The call

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Benny Halevy
I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Benny On Nov. 14, 2007, 9:04 +0200, Chris Wedgwood [EMAIL PROTECTED] wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported