Re: BUG and WARN kernel log levels

2016-08-17 Thread Joe Perches
On Wed, 2016-08-17 at 14:19 -0700, Kees Cook wrote: > On Wed, Aug 17, 2016 at 9:36 AM, Joe Perches wrote: [] > > And here I submitted patches: > > https://lkml.org/lkml/2010/10/30/176 > Ah, I see some of this series landed. I see commits scattered in the > tree, but not as many

Re: BUG and WARN kernel log levels

2016-08-17 Thread Joe Perches
On Wed, 2016-08-17 at 14:19 -0700, Kees Cook wrote: > On Wed, Aug 17, 2016 at 9:36 AM, Joe Perches wrote: [] > > And here I submitted patches: > > https://lkml.org/lkml/2010/10/30/176 > Ah, I see some of this series landed. I see commits scattered in the > tree, but not as many as you sent, I

Re: BUG and WARN kernel log levels

2016-08-17 Thread Kees Cook
On Wed, Aug 17, 2016 at 9:36 AM, Joe Perches wrote: > On Mon, 2016-08-15 at 12:00 -0700, Joe Perches wrote: >> On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: >> > >> > Hi, >> > >> > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: >> > >> > #ifndef

Re: BUG and WARN kernel log levels

2016-08-17 Thread Kees Cook
On Wed, Aug 17, 2016 at 9:36 AM, Joe Perches wrote: > On Mon, 2016-08-15 at 12:00 -0700, Joe Perches wrote: >> On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: >> > >> > Hi, >> > >> > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: >> > >> > #ifndef HAVE_ARCH_BUG >> >

Re: BUG and WARN kernel log levels

2016-08-17 Thread Joe Perches
On Mon, 2016-08-15 at 12:00 -0700, Joe Perches wrote: > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > > > > Hi, > > > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > > > #ifndef HAVE_ARCH_BUG > > #define BUG() do { \ > >    printk("BUG: failure at

Re: BUG and WARN kernel log levels

2016-08-17 Thread Joe Perches
On Mon, 2016-08-15 at 12:00 -0700, Joe Perches wrote: > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > > > > Hi, > > > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > > > #ifndef HAVE_ARCH_BUG > > #define BUG() do { \ > >    printk("BUG: failure at

Re: BUG and WARN kernel log levels

2016-08-15 Thread Joe Perches
On Mon, 2016-08-15 at 13:28 -0700, Kees Cook wrote: > On Mon, Aug 15, 2016 at 12:00 PM, Joe Perches wrote: > > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > > > > > #ifndef HAVE_ARCH_BUG > >

Re: BUG and WARN kernel log levels

2016-08-15 Thread Joe Perches
On Mon, 2016-08-15 at 13:28 -0700, Kees Cook wrote: > On Mon, Aug 15, 2016 at 12:00 PM, Joe Perches wrote: > > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > > > > > #ifndef HAVE_ARCH_BUG > > > #define BUG()

Re: BUG and WARN kernel log levels

2016-08-15 Thread Kees Cook
On Mon, Aug 15, 2016 at 12:00 PM, Joe Perches wrote: > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: >> Hi, >> >> So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: >> >> #ifndef HAVE_ARCH_BUG >> #define BUG() do { \ >>printk("BUG: failure at

Re: BUG and WARN kernel log levels

2016-08-15 Thread Kees Cook
On Mon, Aug 15, 2016 at 12:00 PM, Joe Perches wrote: > On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: >> Hi, >> >> So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: >> >> #ifndef HAVE_ARCH_BUG >> #define BUG() do { \ >>printk("BUG: failure at %s:%d/%s()!\n",

Re: BUG and WARN kernel log levels

2016-08-15 Thread Joe Perches
On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > Hi, > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > #ifndef HAVE_ARCH_BUG > #define BUG() do { \ >    printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); > \ > > Seems like it should

Re: BUG and WARN kernel log levels

2016-08-15 Thread Joe Perches
On Mon, 2016-08-15 at 11:53 -0700, Kees Cook wrote: > Hi, > > So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: > > #ifndef HAVE_ARCH_BUG > #define BUG() do { \ >    printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); > \ > > Seems like it should

BUG and WARN kernel log levels

2016-08-15 Thread Kees Cook
Hi, So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: #ifndef HAVE_ARCH_BUG #define BUG() do { \ printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \ Seems like it should have one? Also, I think we might want to examine WARN() a bit... it

BUG and WARN kernel log levels

2016-08-15 Thread Kees Cook
Hi, So, I noticed that asm-gemeric/bug.h defines BUG() without a log level: #ifndef HAVE_ARCH_BUG #define BUG() do { \ printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \ Seems like it should have one? Also, I think we might want to examine WARN() a bit... it