Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread John Hubbard
On 8/21/19 12:49 PM, Neil MacLeod wrote: The fix looks good - many thanks for the quick turnaround! Great news, and thanks for the bug report! thanks, -- John Hubbard NVIDIA On Wed, 21 Aug 2019 at 19:56, John Hubbard wrote: On 8/21/19 11:51 AM, Thomas Gleixner wrote: On Wed, 21 Aug

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread Neil MacLeod
The fix looks good - many thanks for the quick turnaround! Neil On Wed, 21 Aug 2019 at 19:56, John Hubbard wrote: > > On 8/21/19 11:51 AM, Thomas Gleixner wrote: > > On Wed, 21 Aug 2019, John Hubbard wrote: > >> On 8/21/19 10:05 AM, Neil MacLeod wrote: > >> static void

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread John Hubbard
On 8/21/19 11:51 AM, Thomas Gleixner wrote: On Wed, 21 Aug 2019, John Hubbard wrote: On 8/21/19 10:05 AM, Neil MacLeod wrote: static void sanitize_boot_params(struct boot_params *boot_params) { ... const struct boot_params_to_save to_save[] = {

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread Neil MacLeod
John & Thomas Thanks both - if you can ping me a suitable patch I'll test it and let you all know ASAP! Neil On Wed, 21 Aug 2019 at 19:51, Thomas Gleixner wrote: > > On Wed, 21 Aug 2019, John Hubbard wrote: > > On 8/21/19 10:05 AM, Neil MacLeod wrote: > > static void

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread Thomas Gleixner
On Wed, 21 Aug 2019, John Hubbard wrote: > On 8/21/19 10:05 AM, Neil MacLeod wrote: > static void sanitize_boot_params(struct boot_params *boot_params) > { > ... > const struct boot_params_to_save to_save[] = { > BOOT_PARAM_PRESERVE(screen_info), >

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread John Hubbard
On 8/21/19 11:32 AM, Neil MacLeod wrote: Hi John I can test any patches given a link to the diff, and am happy to do so. If I've understood your suggestion correctly, I will try commenting out all of the entries, then add them back one-by-one until I get a non-booting situation. I'll let you

Re: Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread Neil MacLeod
Hi John I can test any patches given a link to the diff, and am happy to do so. If I've understood your suggestion correctly, I will try commenting out all of the entries, then add them back one-by-one until I get a non-booting situation. I'll let you know how I get on. The OS I'm testing is

Boot failure due to: x86/boot: Save fields explicitly, zero out everything else

2019-08-21 Thread John Hubbard
On 8/21/19 10:05 AM, Neil MacLeod wrote: Hi John The following bug might be of interest: https://bugzilla.kernel.org/show_bug.cgi?id=204645 Let me know if I can be of any help. Hi Neil, First of all, I'm pasting in the bug information so that it's directly available here: