Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Ake
On Fri, Jan 28, 2005 at 03:09:40PM +, Hugh Dickins wrote: > > > BTW do you know if there is any plans for 2.6++ to actually use > > > RLIMIT_RSS? I saw a hint in that direction in mm/thrash.c > > > grab_swap_token but it is commented out and only skeleton code... > > > > Nope, RLIMIT_RSS does

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Marcelo Tosatti
On Fri, Jan 28, 2005 at 03:09:40PM +, Hugh Dickins wrote: > On Thu, 27 Jan 2005, Marcelo Tosatti wrote: > > On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: > > > On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: > > > > > > > > --- a/mm/filemap.c.orig 2004-11-17

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Hugh Dickins
On Thu, 27 Jan 2005, Marcelo Tosatti wrote: > On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: > > On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: > > > > > > --- a/mm/filemap.c.orig 2004-11-17 09:54:22.0 -0200 > > > +++ b/mm/filemap.c2005-01-26

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Marcelo Tosatti
On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: > On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: > > > There is also a misinformative comment in fs/proc/array.c > > in proc_pid_stat where it says > > > mm ? mm->rss : 0, /* you might want to shift this left 3 */ > > > the

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Marcelo Tosatti
On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: There is also a misinformative comment in fs/proc/array.c in proc_pid_stat where it says mm ? mm-rss : 0, /* you might want to shift this left 3 */ the number 3

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Hugh Dickins
On Thu, 27 Jan 2005, Marcelo Tosatti wrote: On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: --- a/mm/filemap.c.orig 2004-11-17 09:54:22.0 -0200 +++ b/mm/filemap.c2005-01-26 15:21:10.614842296 -0200

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Marcelo Tosatti
On Fri, Jan 28, 2005 at 03:09:40PM +, Hugh Dickins wrote: On Thu, 27 Jan 2005, Marcelo Tosatti wrote: On Thu, Jan 27, 2005 at 07:38:49AM +0100, Ake wrote: On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: --- a/mm/filemap.c.orig 2004-11-17 09:54:22.0 -0200

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-27 Thread Ake
On Fri, Jan 28, 2005 at 03:09:40PM +, Hugh Dickins wrote: BTW do you know if there is any plans for 2.6++ to actually use RLIMIT_RSS? I saw a hint in that direction in mm/thrash.c grab_swap_token but it is commented out and only skeleton code... Nope, RLIMIT_RSS does not seem to

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Ake
On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: > > There is also a misinformative comment in fs/proc/array.c > > in proc_pid_stat where it says > > mm ? mm->rss : 0, /* you might want to shift this left 3 */ > > the number 3 should probably be PAGE_SHIFT-10. Don't forget the

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Marcelo Tosatti
On Wed, Jan 26, 2005 at 12:07:50PM +0100, Ake wrote: > Use of rlim[RLIMIT_RSS] in mm/filemap.c is wrong. > It is passed down to kernel as a number of bytes but is being used as a > number of pages. > > There is also a misinformative comment in fs/proc/array.c > in proc_pid_stat where it says > mm

Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Ake
Use of rlim[RLIMIT_RSS] in mm/filemap.c is wrong. It is passed down to kernel as a number of bytes but is being used as a number of pages. There is also a misinformative comment in fs/proc/array.c in proc_pid_stat where it says mm ? mm->rss : 0, /* you might want to shift this left 3 */ the

Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Ake
Use of rlim[RLIMIT_RSS] in mm/filemap.c is wrong. It is passed down to kernel as a number of bytes but is being used as a number of pages. There is also a misinformative comment in fs/proc/array.c in proc_pid_stat where it says mm ? mm-rss : 0, /* you might want to shift this left 3 */ the number

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Marcelo Tosatti
On Wed, Jan 26, 2005 at 12:07:50PM +0100, Ake wrote: Use of rlim[RLIMIT_RSS] in mm/filemap.c is wrong. It is passed down to kernel as a number of bytes but is being used as a number of pages. There is also a misinformative comment in fs/proc/array.c in proc_pid_stat where it says mm ?

Re: Bug in 2.4.26 in mm/filemap.c when using RLIMIT_RSS

2005-01-26 Thread Ake
On Wed, Jan 26, 2005 at 12:49:04PM -0200, Marcelo Tosatti wrote: There is also a misinformative comment in fs/proc/array.c in proc_pid_stat where it says mm ? mm-rss : 0, /* you might want to shift this left 3 */ the number 3 should probably be PAGE_SHIFT-10. Don't forget the comment