Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hi Ricardo, On Mon, Feb 2, 2015 at 3:05 PM, Ricardo Ribalda Delgado wrote: > On Mon, Feb 2, 2015 at 2:04 PM, Geert Uytterhoeven > wrote: >>> void * pvar=varB; >> >> ... = >> >>> *pvar = ioread8(valid_memory); >>> >>> Depending if ioread8 returns a u8 or a unsigned int, aren't we also >>>

Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hello Geert On Mon, Feb 2, 2015 at 2:04 PM, Geert Uytterhoeven wrote: >> void * pvar=varB; > > ... = > >> *pvar = ioread8(valid_memory); >> >> Depending if ioread8 returns a u8 or a unsigned int, aren't we also >> accessing varC? >> >> Could not this be a problem? > > Please try to compile the

Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hi Ricardo, On Mon, Feb 2, 2015 at 1:49 PM, Ricardo Ribalda Delgado wrote: > Regarding ioread8 et al. > > On include/asm-generic/io.h is defined as: > extern unsigned int ioread8(void __iomem *); > > On include/asm-generic/io.h: > static inline u8 ioread8(const volatile void __iomem *addr) > >

Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hello Regarding ioread8 et al. On include/asm-generic/io.h is defined as: extern unsigned int ioread8(void __iomem *); On include/asm-generic/io.h: static inline u8 ioread8(const volatile void __iomem *addr) Please ignore the qualifiers right now. The first function returns an unsigned

Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hi Ricardo, On Mon, Feb 2, 2015 at 3:05 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: On Mon, Feb 2, 2015 at 2:04 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: void * pvar=varB; ... = varB; *pvar = ioread8(valid_memory); Depending if ioread8 returns a u8 or a

Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hello Geert On Mon, Feb 2, 2015 at 2:04 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: void * pvar=varB; ... = varB; *pvar = ioread8(valid_memory); Depending if ioread8 returns a u8 or a unsigned int, aren't we also accessing varC? Could not this be a problem? Please try to

Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hello Regarding ioread8 et al. On include/asm-generic/io.h is defined as: extern unsigned int ioread8(void __iomem *); On include/asm-generic/io.h: static inline u8 ioread8(const volatile void __iomem *addr) Please ignore the qualifiers right now. The first function returns an unsigned

Re: Can this be a invalid memory access? (was: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers)

Hi Ricardo, On Mon, Feb 2, 2015 at 1:49 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Regarding ioread8 et al. On include/asm-generic/io.h is defined as: extern unsigned int ioread8(void __iomem *); On include/asm-generic/io.h: static inline u8 ioread8(const volatile void