Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 10:31 AM Zhenzhong Duan wrote: > > Hi Meelis, > > Could you try below change? It force syncconfig for any 'make *config" > > so that autoconf.h and auto.conf are always updated. NACK. syncconfig should happen only when you are about to build something. This patch let

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 10:31 AM Zhenzhong Duan wrote: > > Hi Meelis, > > Could you try below change? It force syncconfig for any 'make *config" > > so that autoconf.h and auto.conf are always updated. NACK. syncconfig should happen only when you are about to build something. This patch let

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Zhenzhong Duan
Hi Meelis, Could you try below change? It force syncconfig for  any 'make *config" so that autoconf.h and auto.conf are always updated. diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 98e0c7a..802875b 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -38,7

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Zhenzhong Duan
Hi Meelis, Could you try below change? It force syncconfig for  any 'make *config" so that autoconf.h and auto.conf are always updated. diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 98e0c7a..802875b 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -38,7

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Zhenzhong Duan
Since commit '315bab4e972d kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE', arch/$(SRCARCH)/Makefile is moved ahead of include/config/%.conf synchonization in root Makefile. So all the CONFIG_* option used in arch/$(SRCARCH)/Makefile may have stale value if they

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Zhenzhong Duan
Since commit '315bab4e972d kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE', arch/$(SRCARCH)/Makefile is moved ahead of include/config/%.conf synchonization in root Makefile. So all the CONFIG_* option used in arch/$(SRCARCH)/Makefile may have stale value if they

Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Meelis Roos
Just tried 4.20-rc5 on an old K6-2 PC with gcc 5.3.1, got an error about non-retpoline compiler, turned CONFIG_RETPOLINE off and retried. To my surprise, compilation still breaks with arch/x86/Makefile:224: *** You are building kernel with non-retpoline compiler, please update your compiler..

Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Meelis Roos
Just tried 4.20-rc5 on an old K6-2 PC with gcc 5.3.1, got an error about non-retpoline compiler, turned CONFIG_RETPOLINE off and retried. To my surprise, compilation still breaks with arch/x86/Makefile:224: *** You are building kernel with non-retpoline compiler, please update your compiler..