Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-27 Thread Thomas Gleixner
On Tue, 27 May 2014, Amir Vadai wrote: > On 5/26/2014 3:39 PM, Thomas Gleixner wrote: > > Even if you'd solve that and have a callback in the driver, then the > > callback never can restart the napi session directly. All it can do is > > set a flag which needs to be checked in the RX path, right? >

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-27 Thread Amir Vadai
On 5/26/2014 3:39 PM, Thomas Gleixner wrote: [...] The rmap _IS_ instantiated by the driver, and both the driver and the networking core know about it. So it's not completely different consumers. Just because it's a library does not mean it's disjunct from the code which uses it. Aside of th

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Thomas Gleixner
On Mon, 26 May 2014, Amir Vadai wrote: > On 5/26/2014 2:34 PM, Thomas Gleixner wrote: > > You are not describing what needs to be notified and why. Please > > explain the details of that and how the RFS (whatever that is) and the > > network driver are connected > The goal of RFS is to increase dat

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:34 PM, Thomas Gleixner wrote: On Mon, 26 May 2014, Amir Vadai wrote: On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap notificatio

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Thomas Gleixner
On Mon, 26 May 2014, Amir Vadai wrote: > On 5/26/2014 2:15 PM, Thomas Gleixner wrote: > > On Sun, 25 May 2014, Amir Vadai wrote: > > > In order to do that, I need to add a new irq affinity notification > > > callback (In addition to the existing cpu_rmap notification). For > > > that I would like

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap notification). For that I would like to extend irq_set_affinity_notifier() to have a notifier call

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Thomas Gleixner
On Sun, 25 May 2014, Amir Vadai wrote: > In order to do that, I need to add a new irq affinity notification > callback (In addition to the existing cpu_rmap notification). For > that I would like to extend irq_set_affinity_notifier() to have a > notifier call-chain instead of a single notifier call

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
On 5/25/2014 3:15 PM, Amir Vadai wrote: Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even if the

Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even if the user changes the irq affinity, polling