Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread houlong wei
Hi Jassi, There is one request for one GCE h/w buffer which contains a list of registers operation. I will resubmit a version and please review again. Thanks, Houlong On Thu, 2018-01-18 at 16:01 +0800, Jassi Brar wrote: > On Mon, Jan 8, 2018 at 2:08 PM, houlong wei

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread houlong wei
Hi Jassi, There is one request for one GCE h/w buffer which contains a list of registers operation. I will resubmit a version and please review again. Thanks, Houlong On Thu, 2018-01-18 at 16:01 +0800, Jassi Brar wrote: > On Mon, Jan 8, 2018 at 2:08 PM, houlong wei wrote: > > Hi Jassi, > > > >

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread Jassi Brar
On Mon, Jan 8, 2018 at 2:08 PM, houlong wei wrote: > Hi Jassi, > > Sorry for reply so late. > According to previous discussion, there are two methods to move > dma_map_single() outside of spin_lock. > (1) put in mtk-cmdq-helper.c, as described by HS on 2017-02-09. > >

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread Jassi Brar
On Mon, Jan 8, 2018 at 2:08 PM, houlong wei wrote: > Hi Jassi, > > Sorry for reply so late. > According to previous discussion, there are two methods to move > dma_map_single() outside of spin_lock. > (1) put in mtk-cmdq-helper.c, as described by HS on 2017-02-09. > > I think a trade-off

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Sorry to send the mail again because I missed some mail lists by mistake. Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > > Sorry for

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Sorry to send the mail again because I missed some mail lists by mistake. Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > > Sorry for

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-08 Thread houlong wei
Hi Jassi, Sorry for reply so late. According to previous discussion, there are two methods to move dma_map_single() outside of spin_lock. (1) put in mtk-cmdq-helper.c, as described by HS on 2017-02-09. > I think a trade-off solution is to put in mtk-cmdq-helper.c. > Although it is a mailbox

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-08 Thread houlong wei
Hi Jassi, Sorry for reply so late. According to previous discussion, there are two methods to move dma_map_single() outside of spin_lock. (1) put in mtk-cmdq-helper.c, as described by HS on 2017-02-09. > I think a trade-off solution is to put in mtk-cmdq-helper.c. > Although it is a mailbox