[PATCH 3.2 164/221] x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround

2015-05-04 Thread Ben Hutchings
3.2.69-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Jones commit 7a20c2fad61aa3624e83c671d36dbd36b2661476 upstream. This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text.

[PATCH 3.2 164/221] x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround

2015-05-04 Thread Ben Hutchings
3.2.69-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Jones da...@redhat.com commit 7a20c2fad61aa3624e83c671d36dbd36b2661476 upstream. This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Mon, Sep 30, 2013 at 01:15:02PM +1000, Dave Airlie wrote: > On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett wrote: > > Likely indicates that our ACPI reboot handling still isn't bug > > compatible with Windows. We'd do better fixing that than adding more DMI > > entries. > > are these only

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread H. Peter Anvin
On 09/29/2013 08:15 PM, Dave Airlie wrote: >> >> Likely indicates that our ACPI reboot handling still isn't bug >> compatible with Windows. We'd do better fixing that than adding more DMI >> entries. > > are these only with VTd enabled? I have some Dells that won't reboot > with VTd turned on, I

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Dave Airlie
On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett wrote: > On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: >> On 09/29/2013 07:57 PM, Matthew Garrett wrote: >> > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: >> >> >> >> It really is starting to feel like *ALL*

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: > On 09/29/2013 07:57 PM, Matthew Garrett wrote: > > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > >> > >> It really is starting to feel like *ALL* Dell machines need reboot=pci? > > > > Now that ACPI is default,

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread H. Peter Anvin
On 09/29/2013 07:57 PM, Matthew Garrett wrote: > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: >> >> It really is starting to feel like *ALL* Dell machines need reboot=pci? > > Now that ACPI is default, I'd be surprised if any of them do. > Look at the stream of Dell machines

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > > It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread H. Peter Anvin
On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be surprised if any of them do. Look at the stream of Dell machines we're

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like *ALL* Dell machines need reboot=pci? Now that ACPI is default, I'd be

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Dave Airlie
On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote: On 09/29/2013 07:57 PM, Matthew Garrett wrote: On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: It really is starting to feel like

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread H. Peter Anvin
On 09/29/2013 08:15 PM, Dave Airlie wrote: Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. are these only with VTd enabled? I have some Dells that won't reboot with VTd turned on, I remember

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-29 Thread Matthew Garrett
On Mon, Sep 30, 2013 at 01:15:02PM +1000, Dave Airlie wrote: On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett mj...@srcf.ucam.org wrote: Likely indicates that our ACPI reboot handling still isn't bug compatible with Windows. We'd do better fixing that than adding more DMI entries. are

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread H. Peter Anvin
On 09/27/2013 01:19 PM, Dave Jones wrote: > > Either that or 'bios'. The question I have is, of those marked 'bios', does > =pci > work too ? If we knew that was true, I'd probably say yes. > Who knows. reboot=bios used to only work on 32 bits until very recently. -hpa -- To

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread Dave Jones
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: > On 09/24/2013 07:13 PM, Dave Jones wrote: > > This seems to have been copied from the Optiplex 990 entry above, but > > somoene > > forgot to change the ident text. > > > > Signed-off-by: Dave Jones > > > > diff --git

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread H. Peter Anvin
On 09/24/2013 07:13 PM, Dave Jones wrote: > This seems to have been copied from the Optiplex 990 entry above, but somoene > forgot to change the ident text. > > Signed-off-by: Dave Jones > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > index f6835d8..ea2aaca 100644 > ---

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread H. Peter Anvin
On 09/24/2013 07:13 PM, Dave Jones wrote: This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread Dave Jones
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote: On 09/24/2013 07:13 PM, Dave Jones wrote: This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org diff

Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-27 Thread H. Peter Anvin
On 09/27/2013 01:19 PM, Dave Jones wrote: Either that or 'bios'. The question I have is, of those marked 'bios', does =pci work too ? If we knew that was true, I'd probably say yes. Who knows. reboot=bios used to only work on 32 bits until very recently. -hpa -- To

[tip:x86/urgent] x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround

2013-09-25 Thread tip-bot for Dave Jones
-n-paste mistake in Dell reboot workaround This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones Link: http://lkml.kernel.org/r/20130925001344.ga13...@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel

[tip:x86/urgent] x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround

2013-09-25 Thread tip-bot for Dave Jones
+0200 x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org Link: http://lkml.kernel.org/r/20130925001344.ga13

Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-24 Thread Dave Jones
This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index f6835d8..ea2aaca 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c

Fix apparent cut-n-paste mistake in Dell reboot workaround.

2013-09-24 Thread Dave Jones
This seems to have been copied from the Optiplex 990 entry above, but somoene forgot to change the ident text. Signed-off-by: Dave Jones da...@fedoraproject.org diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index f6835d8..ea2aaca 100644 --- a/arch/x86/kernel/reboot.c +++