Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Pavel Machek
Hi! > > Pavel, Felipe's remark was valid.. > > > > > > No, I'll not polish patch for hardware I don't have and have little > > > > interest in. wanted to help you, but according to your first reply, > > > > you do not really want help. > > > > > > that's your call. Now how about you stop being

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Pavel Machek
Hi! > > > No, I'll not polish patch for hardware I don't have and have little > > > interest in. wanted to help you, but according to your first reply, > > > you do not really want help. > > > > that's your call. Now how about you stop being such a baby and go fix > > your mistakes to start

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Felipe Balbi
Hi, On Wed, Sep 25, 2013 at 05:39:39PM +0200, Bartlomiej Zolnierkiewicz wrote: > Pavel, Felipe's remark was valid.. > > > > No, I'll not polish patch for hardware I don't have and have little > > > interest in. wanted to help you, but according to your first reply, > > > you do not really want

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, September 18, 2013 09:11:06 AM Felipe Balbi wrote: > Hi, > > On Wed, Sep 18, 2013 at 11:20:27AM +0200, Pavel Machek wrote: > > On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: > > > On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: > > > > On Tue 2013-09-17

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, September 18, 2013 09:11:06 AM Felipe Balbi wrote: Hi, On Wed, Sep 18, 2013 at 11:20:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 10:42:30, Felipe

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Felipe Balbi
Hi, On Wed, Sep 25, 2013 at 05:39:39PM +0200, Bartlomiej Zolnierkiewicz wrote: Pavel, Felipe's remark was valid.. No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Pavel Machek
Hi! No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help. that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just

Re: Fix style in s3c-hsotg.c

2013-09-25 Thread Pavel Machek
Hi! Pavel, Felipe's remark was valid.. No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help. that's your call. Now how about you stop being such a baby and go

Re: Fix style in s3c-hsotg.c

2013-09-18 Thread Felipe Balbi
Hi, On Wed, Sep 18, 2013 at 11:20:27AM +0200, Pavel Machek wrote: > On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: > > On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: > > > On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Mon, Sep 02, 2013 at

Re: Fix style in s3c-hsotg.c

2013-09-18 Thread Pavel Machek
On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: > On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: > > On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: > > > > Hi! > > > > > > > > checkpatch.pl has

Re: Fix style in s3c-hsotg.c

2013-09-18 Thread Pavel Machek
On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: Hi! checkpatch.pl has some valid complaints

Re: Fix style in s3c-hsotg.c

2013-09-18 Thread Felipe Balbi
Hi, On Wed, Sep 18, 2013 at 11:20:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 20:45:39, Felipe Balbi wrote: On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Felipe Balbi
On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: > On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: > > Hi, > > > > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c : > > > macro

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Pavel Machek
On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: > Hi, > > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: > > Hi! > > > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c : > > macro with if should be really enclosed in do {} while, and puts is > > going to be

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Felipe Balbi
Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: > Hi! > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c : > macro with if should be really enclosed in do {} while, and puts is > going to be slightly faster. > > Here's suggested patch. I don't have the

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Felipe Balbi
Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: Hi! checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware,

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Pavel Machek
On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: Hi! checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Re: Fix style in s3c-hsotg.c

2013-09-17 Thread Felipe Balbi
On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote: On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: Hi, On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: Hi! checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be

Re: Fix style in s3c-hsotg.c

2013-09-02 Thread Sergei Shtylyov
Hello. On 09/02/2013 05:58 PM, Pavel Machek wrote: checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware, so it is completely

Fix style in s3c-hsotg.c

2013-09-02 Thread Pavel Machek
Hi! checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware, so it is completely untested. Signed-off-by: Pavel Machek, diff --git

Fix style in s3c-hsotg.c

2013-09-02 Thread Pavel Machek
Hi! checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware, so it is completely untested. Signed-off-by: Pavel Machek, pa...@denx.de

Re: Fix style in s3c-hsotg.c

2013-09-02 Thread Sergei Shtylyov
Hello. On 09/02/2013 05:58 PM, Pavel Machek wrote: checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware, so it is completely