Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-04 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote: | | SNIP | | > | | > | | > | could you please change this, so it's nop for arch != powerpc | > | via #ifdef I guess.. or some other smart way ;-) | > | > I was trying to avoid the #ifdef

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-04 Thread Jiri Olsa
On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote: SNIP > | > | > | could you please change this, so it's nop for arch != powerpc > | via #ifdef I guess.. or some other smart way ;-) > > I was trying to avoid the #ifdef in the middle of the function. > > How about adding a

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-04 Thread Jiri Olsa
On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote: SNIP | | | could you please change this, so it's nop for arch != powerpc | via #ifdef I guess.. or some other smart way ;-) I was trying to avoid the #ifdef in the middle of the function. How about adding a

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-04 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote: | | SNIP | | | | | | | could you please change this, so it's nop for arch != powerpc | | via #ifdef I guess.. or some other smart way ;-) | | I was trying to avoid the #ifdef in

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-03 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote: | > On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote: | > > Jiri Olsa [jo...@redhat.com] wrote: | > > | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bhattiprolu wrote: | > > | >

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-03 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote: | On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote: | Jiri Olsa [jo...@redhat.com] wrote: | | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bhattiprolu wrote: | | Hi

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-02 Thread Jiri Olsa
On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote: > On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote: > > Jiri Olsa [jo...@redhat.com] wrote: > > | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bhattiprolu wrote: > > | > Hi Arnaldo, Jiri > > | > > > | > Do you have

Re: Fw: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-06-02 Thread Jiri Olsa
On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote: On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bhattiprolu wrote: | Hi Arnaldo, Jiri | | Do you have any comments