Re: I2C algorithm IDs

2005-01-31 Thread Greg KH
On Sat, Jan 22, 2005 at 05:47:18PM +, Russell King wrote:
> Greg,
> 
> Are I2C algorithm IDs supposed to be unique?  Do they have any meaning in
> reality at all?  If the answer is yes to either of these questions, the
> following should probably be resolved:

Yes, they are used in some places, and yes they do need to be unique.

> #define I2C_ALGO_PCA0x15/* PCA 9564 style adapters  */
> #define I2C_ALGO_SIBYTE 0x15/* Broadcom SiByte SOCs */

Thanks for pointing this out, I've gone and fixed this up and will send
the patch upward.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: I2C algorithm IDs

2005-01-31 Thread Greg KH
On Sat, Jan 22, 2005 at 05:47:18PM +, Russell King wrote:
 Greg,
 
 Are I2C algorithm IDs supposed to be unique?  Do they have any meaning in
 reality at all?  If the answer is yes to either of these questions, the
 following should probably be resolved:

Yes, they are used in some places, and yes they do need to be unique.

 #define I2C_ALGO_PCA0x15/* PCA 9564 style adapters  */
 #define I2C_ALGO_SIBYTE 0x15/* Broadcom SiByte SOCs */

Thanks for pointing this out, I've gone and fixed this up and will send
the patch upward.

thanks,

greg k-h
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


I2C algorithm IDs

2005-01-22 Thread Russell King
Greg,

Are I2C algorithm IDs supposed to be unique?  Do they have any meaning in
reality at all?  If the answer is yes to either of these questions, the
following should probably be resolved:

#define I2C_ALGO_PCA0x15/* PCA 9564 style adapters  */
#define I2C_ALGO_SIBYTE 0x15/* Broadcom SiByte SOCs */

-- 
Russell King

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


I2C algorithm IDs

2005-01-22 Thread Russell King
Greg,

Are I2C algorithm IDs supposed to be unique?  Do they have any meaning in
reality at all?  If the answer is yes to either of these questions, the
following should probably be resolved:

#define I2C_ALGO_PCA0x15/* PCA 9564 style adapters  */
#define I2C_ALGO_SIBYTE 0x15/* Broadcom SiByte SOCs */

-- 
Russell King

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/