Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-28 Thread Tan Xiaojun
On 2016/6/28 12:57, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: >> Hi everyone, >> >> I'm sorry to bother you. But I was confused. >> >> The IP ID check (flush_id) in inet_gro_receive is only used by >> tcp_gro_receive, and in tcp_gro_receive we have

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-28 Thread Tan Xiaojun
On 2016/6/28 12:57, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: >> Hi everyone, >> >> I'm sorry to bother you. But I was confused. >> >> The IP ID check (flush_id) in inet_gro_receive is only used by >> tcp_gro_receive, and in tcp_gro_receive we have

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: > Hi everyone, > > I'm sorry to bother you. But I was confused. > > The IP ID check (flush_id) in inet_gro_receive is only used by > tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure > the order of skbs, >

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Eric Dumazet
On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: > Hi everyone, > > I'm sorry to bother you. But I was confused. > > The IP ID check (flush_id) in inet_gro_receive is only used by > tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure > the order of skbs, >

IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Tan Xiaojun
Hi everyone, I'm sorry to bother you. But I was confused. The IP ID check (flush_id) in inet_gro_receive is only used by tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure the order of skbs, like below: flush |= (__force int)(th->ack_seq ^

IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Tan Xiaojun
Hi everyone, I'm sorry to bother you. But I was confused. The IP ID check (flush_id) in inet_gro_receive is only used by tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure the order of skbs, like below: flush |= (__force int)(th->ack_seq ^