Re: Inconsistency in clk framework

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 05:13:37PM +1300, Tony Prisk wrote: > On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote: > > On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: > > > On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > > > > On Wed, 2012-12-19 at 09:26 +,

Re: Inconsistency in clk framework

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 05:13:37PM +1300, Tony Prisk wrote: On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote: On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: On Wed, 2012-12-19 at 09:26 +, Russell King

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: > > On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > > > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > > > > On Wed, Dec 19, 2012 at

Re: Inconsistency in clk framework

2012-12-19 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: > On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > > > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > > > > Hi Mike, > > > > > > > > In

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > > > Hi Mike, > > > > > > In attempting to remove some IS_ERR_OR_NULL references, it was pointed > > > out

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > > Hi Mike, > > > > In attempting to remove some IS_ERR_OR_NULL references, it was pointed > > out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. >

Re: Inconsistency in clk framework

2012-12-19 Thread Russell King - ARM Linux
On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > Hi Mike, > > In attempting to remove some IS_ERR_OR_NULL references, it was pointed > out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. That is correct - but why is that a problem? As far as users are concerned,

Re: Inconsistency in clk framework

2012-12-19 Thread Russell King - ARM Linux
On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: Hi Mike, In attempting to remove some IS_ERR_OR_NULL references, it was pointed out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. That is correct - but why is that a problem? As far as users are concerned, NULL

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: Hi Mike, In attempting to remove some IS_ERR_OR_NULL references, it was pointed out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. That is

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: Hi Mike, In attempting to remove some IS_ERR_OR_NULL references, it was pointed out that clk_get() can

Re: Inconsistency in clk framework

2012-12-19 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: Hi Mike, In attempting to remove some

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote: On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: On Wed, Dec 19, 2012 at 05:10:33PM +1300,

Inconsistency in clk framework

2012-12-18 Thread Tony Prisk
Hi Mike, In attempting to remove some IS_ERR_OR_NULL references, it was pointed out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. This seems to contradict the kernel docs associated with the normal clk_get (when HAVE_CLK is defined) which states: * Returns a struct clk

Inconsistency in clk framework

2012-12-18 Thread Tony Prisk
Hi Mike, In attempting to remove some IS_ERR_OR_NULL references, it was pointed out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined. This seems to contradict the kernel docs associated with the normal clk_get (when HAVE_CLK is defined) which states: * Returns a struct clk