Re: Linux 4.19 and GCC 9

2019-06-25 Thread Greg KH
On Tue, Jun 25, 2019 at 03:50:29PM +0800, Greg KH wrote: > On Mon, Jun 24, 2019 at 11:42:34AM +0100, Ignat Korchagin wrote: > > Hi Greg, > > > > > > For us it seems applying the following 4 mainline patches makes 4.19.x > > > > branch perf compile with GCC-9: > > > > > > > >

Re: Linux 4.19 and GCC 9

2019-06-25 Thread Greg KH
On Mon, Jun 24, 2019 at 11:42:34AM +0100, Ignat Korchagin wrote: > Hi Greg, > > > > For us it seems applying the following 4 mainline patches makes 4.19.x > > > branch perf compile with GCC-9: > > > > > > 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use > > > strlcpy() as a shorter

Re: Linux 4.19 and GCC 9

2019-06-24 Thread Ignat Korchagin
Hi Greg, > > For us it seems applying the following 4 mainline patches makes 4.19.x > > branch perf compile with GCC-9: > > > > 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use > > strlcpy() as a shorter form of strncpy() + explicit set nul > >

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 10, 2019 at 05:25:42PM +0200, Greg KH escreveu: > On Mon, Jun 10, 2019 at 12:14:07PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jun 10, 2019 at 12:21:51AM -0700, Ivan Babrou escreveu: > > > Looks like 4.19.49 received some patches for GCC 9+, but unfortunately > > > perf still

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Greg KH
On Mon, Jun 10, 2019 at 12:14:07PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 10, 2019 at 12:21:51AM -0700, Ivan Babrou escreveu: > > Looks like 4.19.49 received some patches for GCC 9+, but unfortunately > > perf still doesn't want to compile: > > > > [07:15:32]In file included from

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 10, 2019 at 12:21:51AM -0700, Ivan Babrou escreveu: > Looks like 4.19.49 received some patches for GCC 9+, but unfortunately > perf still doesn't want to compile: > > [07:15:32]In file included from /usr/include/string.h:635, > [07:15:32] from util/debug.h:7, > [07:15:32] from

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Miguel Ojeda
On Mon, Jun 10, 2019 at 4:49 PM Greg KH wrote: > > On Mon, Jun 10, 2019 at 04:42:27PM +0200, Miguel Ojeda wrote: > > I think Josh Poimboeuf added support for a few related things in GCC 8 > > (e.g. 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions")). > > That commit is already in all

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Ignat Korchagin
On Mon, Jun 10, 2019 at 3:49 PM Greg KH wrote: > > > > > I typically compile a bare-bones GCC for those things, it is quite quick. > > Pointers to how to do that is appreciated. It's been years since I had > to build gcc "from scratch". This is how we do it, but we use it for some other

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Greg KH
On Mon, Jun 10, 2019 at 04:42:27PM +0200, Miguel Ojeda wrote: > On Mon, Jun 10, 2019 at 4:21 PM Greg KH wrote: > > > > > I also checked that 4.19.49 compiles fine with GCC 9, although with a > > > lot of warnings, mostly from objtool, like "warning: objtool: > > > sock_register()+0xd: sibling

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Miguel Ojeda
On Mon, Jun 10, 2019 at 4:21 PM Greg KH wrote: > > > I also checked that 4.19.49 compiles fine with GCC 9, although with a > > lot of warnings, mostly from objtool, like "warning: objtool: > > sock_register()+0xd: sibling call from callable instruction with > > modified stack frame". But it's a

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Greg KH
On Mon, Jun 10, 2019 at 10:32:25AM +0100, Ignat Korchagin wrote: > Hi Greg, > > For us it seems applying the following 4 mainline patches makes 4.19.x > branch perf compile with GCC-9: > > 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use > strlcpy() as a shorter form of strncpy()

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Ignat Korchagin
Hi Greg, For us it seems applying the following 4 mainline patches makes 4.19.x branch perf compile with GCC-9: 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use strlcpy() as a shorter form of strncpy() + explicit set nul b6313899f4ed2e76b8375cf8069556f5b94fbff0: perf help: Remove

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Greg KH
On Mon, Jun 10, 2019 at 12:21:51AM -0700, Ivan Babrou wrote: > Looks like 4.19.49 received some patches for GCC 9+, but unfortunately > perf still doesn't want to compile: > > [07:15:32]In file included from /usr/include/string.h:635, > [07:15:32] from util/debug.h:7, > [07:15:32] from

Re: Linux 4.19 and GCC 9

2019-06-10 Thread Ivan Babrou
Looks like 4.19.49 received some patches for GCC 9+, but unfortunately perf still doesn't want to compile: [07:15:32]In file included from /usr/include/string.h:635, [07:15:32] from util/debug.h:7, [07:15:32] from builtin-help.c:15: [07:15:32]In function 'strncpy', [07:15:32] inlined from

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Arnaldo Carvalho de Melo
On May 17, 2019 2:23:10 PM GMT-03:00, Ivan Babrou wrote: >On Fri, May 17, 2019 at 8:22 AM Arnaldo Carvalho de Melo > wrote: >> >> Em Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda escreveu: >> > On Fri, May 17, 2019 at 10:51 AM Greg KH > wrote: >> > > >> > > On Fri, May 17, 2019 at

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Ivan Babrou
On Fri, May 17, 2019 at 8:22 AM Arnaldo Carvalho de Melo wrote: > > Em Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda escreveu: > > On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > > On Fri, May 17, 2019 at 9:38

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Arnaldo Carvalho de Melo
Em Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda escreveu: > On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra > > > wrote: > > > > > > > > Right; if there is anything

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Greg KH
On Fri, May 17, 2019 at 11:42:17AM +0200, Greg KH wrote: > On Fri, May 17, 2019 at 11:27:41AM +0200, Miguel Ojeda wrote: > > On Fri, May 17, 2019 at 11:23 AM Greg KH wrote: > > > > > > On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > > > > > > > a6e60d84989f

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Greg KH
On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra > > > wrote: > > > > > > > > Right; if there is anything you

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Greg KH
On Fri, May 17, 2019 at 11:27:41AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 11:23 AM Greg KH wrote: > > > > On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > > > > > a6e60d84989f ("include/linux/module.h: copy __init/__exit attrs to > > > init/cleanup_module") > > > >

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Miguel Ojeda
On Fri, May 17, 2019 at 11:23 AM Greg KH wrote: > > On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > > > a6e60d84989f ("include/linux/module.h: copy __init/__exit attrs to > > init/cleanup_module") > > That patch I applied now. Note that this one requires the second one

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Greg KH
On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra > > > wrote: > > > > > > > > Right; if there is anything you

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Miguel Ojeda
On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote: > > > > > > Right; if there is anything you can reproduce on linus.git I'll happily > > > have a look. If it doesn't

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Greg KH
On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote: > > > > On Fri, May 17, 2019 at 07:09:31AM +0200, Greg KH wrote: > > > On Thu, May 16, 2019 at 08:14:25PM -0700, Ivan Babrou wrote: > > > > We are building the upstream kernel.

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Miguel Ojeda
On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote: > > On Fri, May 17, 2019 at 07:09:31AM +0200, Greg KH wrote: > > On Thu, May 16, 2019 at 08:14:25PM -0700, Ivan Babrou wrote: > > > We are building the upstream kernel. There are a few patches, but > > > nothing related to objtool. > > > > > >

Re: Linux 4.19 and GCC 9

2019-05-17 Thread Peter Zijlstra
On Fri, May 17, 2019 at 07:09:31AM +0200, Greg KH wrote: > On Thu, May 16, 2019 at 08:14:25PM -0700, Ivan Babrou wrote: > > We are building the upstream kernel. There are a few patches, but > > nothing related to objtool. > > > > Unless you mean mainline/stable by upstream, I haven't tried that.

Re: Linux 4.19 and GCC 9

2019-05-16 Thread Greg KH
On Thu, May 16, 2019 at 08:14:25PM -0700, Ivan Babrou wrote: > We are building the upstream kernel. There are a few patches, but > nothing related to objtool. > > Unless you mean mainline/stable by upstream, I haven't tried that. We > stick to LTS. Please work and all of these issues fixed up in

Re: Linux 4.19 and GCC 9

2019-05-16 Thread Ivan Babrou
We are building the upstream kernel. There are a few patches, but nothing related to objtool. Unless you mean mainline/stable by upstream, I haven't tried that. We stick to LTS. On Thu, May 16, 2019 at 7:04 PM Josh Poimboeuf wrote: > > On Thu, May 16, 2019 at 11:20:54PM +0200, Miguel Ojeda

Re: Linux 4.19 and GCC 9

2019-05-16 Thread Josh Poimboeuf
On Thu, May 16, 2019 at 11:20:54PM +0200, Miguel Ojeda wrote: > > mm/slub.o: warning: objtool: init_cache_random_seq()+0x36: sibling > > call from callable instruction with modified stack frame > > mm/slub.o: warning: objtool: slab_out_of_memory()+0x3b: sibling call > > from callable instruction

Re: Linux 4.19 and GCC 9

2019-05-16 Thread Ivan Babrou
On Thu, May 16, 2019 at 2:21 PM Miguel Ojeda wrote: > > Hi, > > On Thu, May 16, 2019 at 10:11 PM Ivan Babrou wrote: > > > > Hey Miguel, > > > > The first error is during perf build process (make -C tools/perf install): > > > > [17:38:21] In file included from /usr/include/string.h:635, > >

Re: Linux 4.19 and GCC 9

2019-05-16 Thread Miguel Ojeda
Hi, On Thu, May 16, 2019 at 10:11 PM Ivan Babrou wrote: > > Hey Miguel, > > The first error is during perf build process (make -C tools/perf install): > > [17:38:21] In file included from /usr/include/string.h:635, > [17:38:21] from ui/tui/helpline.c:4: > [17:38:21] In function