[PATCH 4.9 61/71] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Nava kishore Manne
commit 260683137ab5276113fc322fdbbc578024185fee upstream.
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Cc: stable
Signed-off-by: Michal Simek
Signed-off-by: Greg Kroah-Hartman
---
drivers/tty/serial/xilinx_uartps.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -128,7 +128,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -362,7 +362,7 @@ static irqreturn_t cdns_uart_isr(int irq
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
[PATCH 4.14 086/101] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Nava kishore Manne
commit 260683137ab5276113fc322fdbbc578024185fee upstream.
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Cc: stable
Signed-off-by: Michal Simek
Signed-off-by: Greg Kroah-Hartman
---
drivers/tty/serial/xilinx_uartps.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -130,7 +130,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -366,7 +366,7 @@ static irqreturn_t cdns_uart_isr(int irq
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
[PATCH 4.19 141/170] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
4.19-stable review patch. If anyone has any objections, please let me know.
--
From: Nava kishore Manne
commit 260683137ab5276113fc322fdbbc578024185fee upstream.
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Cc: stable
Signed-off-by: Michal Simek
Signed-off-by: Greg Kroah-Hartman
---
drivers/tty/serial/xilinx_uartps.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -125,7 +125,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -362,7 +362,7 @@ static irqreturn_t cdns_uart_isr(int irq
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
[PATCH 4.20 109/145] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
4.20-stable review patch. If anyone has any objections, please let me know.
--
From: Nava kishore Manne
commit 260683137ab5276113fc322fdbbc578024185fee upstream.
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Cc: stable
Signed-off-by: Michal Simek
Signed-off-by: Greg Kroah-Hartman
---
drivers/tty/serial/xilinx_uartps.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -123,7 +123,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -364,7 +364,7 @@ static irqreturn_t cdns_uart_isr(int irq
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
[PATCH v2 4/4] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
From: Nava kishore Manne
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Signed-off-by: Michal Simek
---
Changes in v2:
- Fix Nava's email address to align with patch email address
drivers/tty/serial/xilinx_uartps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index c6d38617d622..094f2958cb2b 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -123,7 +123,7 @@
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -364,7 +364,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
--
1.9.1
[PATCH] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
From: Nava kishore Manne
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Signed-off-by: Michal Simek
---
drivers/tty/serial/xilinx_uartps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index c6d38617d622..094f2958cb2b 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -123,7 +123,7 @@
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -364,7 +364,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
--
1.9.1
[PATCH] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly
From: Nava kishore Manne
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne
Signed-off-by: Michal Simek
---
drivers/tty/serial/xilinx_uartps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index c6d38617d622..094f2958cb2b 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -123,7 +123,7 @@
#define CDNS_UART_IXR_RXTRIG 0x0001 /* RX FIFO trigger interrupt */
#define CDNS_UART_IXR_RXFULL 0x0004 /* RX FIFO full interrupt. */
#define CDNS_UART_IXR_RXEMPTY 0x0002 /* RX FIFO empty interrupt. */
-#define CDNS_UART_IXR_MASK 0x1FFF /* Valid bit mask */
+#define CDNS_UART_IXR_RXMASK 0x21e7 /* Valid RX bit mask */
/*
* Do not enable parity error interrupt for the following
@@ -364,7 +364,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
cdns_uart_handle_tx(dev_id);
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- if (isrstatus & CDNS_UART_IXR_MASK)
+ if (isrstatus & CDNS_UART_IXR_RXMASK)
cdns_uart_handle_rx(dev_id, isrstatus);
spin_unlock(>lock);
--
1.9.1
Re: Mask Issue?
On (24/09/07 18:07), Chris Holvenstot didst pronounce: > > On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: > > On (19/09/07 17:57), Chris Holvenstot didst pronounce: > > > Still being a little new at this I am not sure if this is an issue at > > > all or not but I noted that while building the 2.6.23-rc6-git8 kernel > > > this afternoon I received the following error message: > > > > > > Building modules, stage 2. > > > MODPOST 1670 modules > > > WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 > > > > > > I have been building each of the kernels in the 2.6.23-rc series and had > > > not noted this message before. I apologize if this is a non-issue. > > > > > > > I noticed this in a -mm recently and never got around to kicking it > > properly because I suspected it was a compiler issue. What version > > of gcc and binutils are you using? > > > > David Woodhouse added to cc in case this is a known problem. > > > > Mel - > > Thank you for the response. I was a little unsure if this was to > trivial to report. > It's never trivial but don't be discouraged if your report appears to fall between the cracks - it happens from time to time particularly when the subject is a bit obtuse. > In any case to answer your question I use version 4.1.2 of GCC and the > binutils package shows as 2.17.20070103cvs-0ubuntu2 > As David says the check will go away in the near future, I reckon it's safe to ignore the problem (unless David objects) and disable it in your .config and continue with your testing. As the driver is specific to the One Laptop Per Child project, I'm guessing you are not affected. Thanks for testing and reporting. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On (24/09/07 18:07), Chris Holvenstot didst pronounce: On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: On (19/09/07 17:57), Chris Holvenstot didst pronounce: Still being a little new at this I am not sure if this is an issue at all or not but I noted that while building the 2.6.23-rc6-git8 kernel this afternoon I received the following error message: Building modules, stage 2. MODPOST 1670 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 I have been building each of the kernels in the 2.6.23-rc series and had not noted this message before. I apologize if this is a non-issue. I noticed this in a -mm recently and never got around to kicking it properly because I suspected it was a compiler issue. What version of gcc and binutils are you using? David Woodhouse added to cc in case this is a known problem. Mel - Thank you for the response. I was a little unsure if this was to trivial to report. It's never trivial but don't be discouraged if your report appears to fall between the cracks - it happens from time to time particularly when the subject is a bit obtuse. In any case to answer your question I use version 4.1.2 of GCC and the binutils package shows as 2.17.20070103cvs-0ubuntu2 As David says the check will go away in the near future, I reckon it's safe to ignore the problem (unless David objects) and disable it in your .config and continue with your testing. As the driver is specific to the One Laptop Per Child project, I'm guessing you are not affected. Thanks for testing and reporting. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: > On (19/09/07 17:57), Chris Holvenstot didst pronounce: > > Still being a little new at this I am not sure if this is an issue at > > all or not but I noted that while building the 2.6.23-rc6-git8 kernel > > this afternoon I received the following error message: > > > > Building modules, stage 2. > > MODPOST 1670 modules > > WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 > > > > I have been building each of the kernels in the 2.6.23-rc series and had > > not noted this message before. I apologize if this is a non-issue. > > > > I noticed this in a -mm recently and never got around to kicking it > properly because I suspected it was a compiler issue. What version > of gcc and binutils are you using? > > David Woodhouse added to cc in case this is a known problem. > Mel - Thank you for the response. I was a little unsure if this was to trivial to report. In any case to answer your question I use version 4.1.2 of GCC and the binutils package shows as 2.17.20070103cvs-0ubuntu2 Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: > I noticed this in a -mm recently and never got around to kicking it > properly because I suspected it was a compiler issue. What version > of gcc and binutils are you using? > > David Woodhouse added to cc in case this is a known problem. The only reason for this is because once upon a time, the early FPGA versions of the CAFÉ chip had the same PCI ident for all three functions. The cluebat was applied; the chip was fixed long before tape-out. We can just drop the whole class/mask thing, I suspect -- I just want to boot it on and OLPC machine before I commit that. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On (19/09/07 17:57), Chris Holvenstot didst pronounce: > Still being a little new at this I am not sure if this is an issue at > all or not but I noted that while building the 2.6.23-rc6-git8 kernel > this afternoon I received the following error message: > > Building modules, stage 2. > MODPOST 1670 modules > WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 > > I have been building each of the kernels in the 2.6.23-rc series and had > not noted this message before. I apologize if this is a non-issue. > I noticed this in a -mm recently and never got around to kicking it properly because I suspected it was a compiler issue. What version of gcc and binutils are you using? David Woodhouse added to cc in case this is a known problem. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On (19/09/07 17:57), Chris Holvenstot didst pronounce: Still being a little new at this I am not sure if this is an issue at all or not but I noted that while building the 2.6.23-rc6-git8 kernel this afternoon I received the following error message: Building modules, stage 2. MODPOST 1670 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 I have been building each of the kernels in the 2.6.23-rc series and had not noted this message before. I apologize if this is a non-issue. I noticed this in a -mm recently and never got around to kicking it properly because I suspected it was a compiler issue. What version of gcc and binutils are you using? David Woodhouse added to cc in case this is a known problem. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: I noticed this in a -mm recently and never got around to kicking it properly because I suspected it was a compiler issue. What version of gcc and binutils are you using? David Woodhouse added to cc in case this is a known problem. The only reason for this is because once upon a time, the early FPGA versions of the CAFÉ chip had the same PCI ident for all three functions. The cluebat was applied; the chip was fixed long before tape-out. We can just drop the whole class/mask thing, I suspect -- I just want to boot it on and OLPC machine before I commit that. -- dwmw2 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Mask Issue?
On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: On (19/09/07 17:57), Chris Holvenstot didst pronounce: Still being a little new at this I am not sure if this is an issue at all or not but I noted that while building the 2.6.23-rc6-git8 kernel this afternoon I received the following error message: Building modules, stage 2. MODPOST 1670 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 I have been building each of the kernels in the 2.6.23-rc series and had not noted this message before. I apologize if this is a non-issue. I noticed this in a -mm recently and never got around to kicking it properly because I suspected it was a compiler issue. What version of gcc and binutils are you using? David Woodhouse added to cc in case this is a known problem. Mel - Thank you for the response. I was a little unsure if this was to trivial to report. In any case to answer your question I use version 4.1.2 of GCC and the binutils package shows as 2.17.20070103cvs-0ubuntu2 Chris - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Mask Issue?
Still being a little new at this I am not sure if this is an issue at all or not but I noted that while building the 2.6.23-rc6-git8 kernel this afternoon I received the following error message: Building modules, stage 2. MODPOST 1670 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 I have been building each of the kernels in the 2.6.23-rc series and had not noted this message before. I apologize if this is a non-issue. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Mask Issue?
Still being a little new at this I am not sure if this is an issue at all or not but I noted that while building the 2.6.23-rc6-git8 kernel this afternoon I received the following error message: Building modules, stage 2. MODPOST 1670 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:0 I have been building each of the kernels in the 2.6.23-rc series and had not noted this message before. I apologize if this is a non-issue. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
